From: "Jan Beulich" <JBeulich@novell.com>
To: "Rusty Russell" <rusty@rustcorp.com.au>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Michal Marek" <mmarek@suse.cz>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] no need to align .modinfo strings
Date: Mon, 06 Sep 2010 09:34:50 +0100 [thread overview]
Message-ID: <4C84C3CA0200007800014730@vpn.id2.novell.com> (raw)
In-Reply-To: <201009061749.56921.rusty@rustcorp.com.au>
>>> On 06.09.10 at 10:19, Rusty Russell <rusty@rustcorp.com.au> wrote:
> On Thu, 2 Sep 2010 09:54:40 pm Jan Beulich wrote:
>> Their use is not performance critical, and hence it seems better to
>> save some space.
>>
>> Signed-off-by: Jan Beulich <jbeulich@novell.com>
>
> Acked-by: Rusty Russell <rusty@rustcorp.com.au>
>
> The real question is: why is gcc aligning these? Should it be aligning
A performance consideration for those cases where strings are being
used a lot, I believe.
> any string literals at all? If so, should we look for other such wastes
> of space?
I think we should, at least I'm keeping an eye open to spot any such.
Jan
prev parent reply other threads:[~2010-09-06 8:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 12:24 Jan Beulich
2010-09-06 8:19 ` Rusty Russell
2010-09-06 8:34 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C84C3CA0200007800014730@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®