* Potential race in irq_chip_set_defaults()?
@ 2010-09-24 0:23 Jeremy Fitzhardinge
2010-09-24 8:45 ` Thomas Gleixner
0 siblings, 1 reply; 2+ messages in thread
From: Jeremy Fitzhardinge @ 2010-09-24 0:23 UTC (permalink / raw)
To: Thomas Gleixner, Linux Kernel Mailing List
irq_chip_set_defaults() modifies the irq_chip structure in-place when
setting up an irq. If that happens on multiple CPUs at once then it
could leave the irq_chip structure in an inconsistent state.
Is there anything preventing that case from happening? There's no
locking, and as far as I know there's no rule forbidding concurrent
calls to set_irq_chip()/irq_chip_set_defaults().
Thanks,
J
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Potential race in irq_chip_set_defaults()?
2010-09-24 0:23 Potential race in irq_chip_set_defaults()? Jeremy Fitzhardinge
@ 2010-09-24 8:45 ` Thomas Gleixner
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Gleixner @ 2010-09-24 8:45 UTC (permalink / raw)
To: Jeremy Fitzhardinge; +Cc: Linux Kernel Mailing List
Jeremy
On Thu, 23 Sep 2010, Jeremy Fitzhardinge wrote:
> irq_chip_set_defaults() modifies the irq_chip structure in-place when
> setting up an irq. If that happens on multiple CPUs at once then it
> could leave the irq_chip structure in an inconsistent state.
>
> Is there anything preventing that case from happening? There's no
> locking, and as far as I know there's no rule forbidding concurrent
> calls to set_irq_chip()/irq_chip_set_defaults().
that's true. Never thought about that. Will have a look.
Thanks,
tglx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-24 8:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-24 0:23 Potential race in irq_chip_set_defaults()? Jeremy Fitzhardinge
2010-09-24 8:45 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome