mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Piotr Oniszczuk <piotr.oniszczuk@gmail.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
	Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
	Bryan O'Donoghue <bod@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Stanimir Varbanov <stanimir.varbanov@linaro.org>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: venus: allow interlaced video streams
Date: Sat, 28 Feb 2026 21:54:20 +0100	[thread overview]
Message-ID: <4CA1838F-504D-4EEA-99F4-B3CC5EB10EDA@gmail.com> (raw)
In-Reply-To: <20260228-venus-mpeg2-v1-1-c13aa7cb6e93@oss.qualcomm.com>



> Wiadomość napisana przez Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> w dniu 28 lut 2026, o godz. 10:49:
> 
> Venus driver errors out on the interlaced streams with the 'field isn't
> supported' error message, which e.g. prevents decoding of the MPEG2
> video streams. Don't error out if the buffer is set to contain
> interlaced data.
> 
> Tested with the fluster enabled to handle MPEG2 through Gstreamer:
> 
> ./fluster.py r -d GStreamer-MPEG2_VIDEO-V4L2-Gst1.0 -s -so venus-mpeg2.md -j 1
> 
> GLOBAL SUMMARY
> |TOTALS|GStreamer-MPEG2_VIDEO-V4L2-Gst1.0|
> |-|-|
> |TOTAL|30/52|
> |TOTAL TIME|75.526s|
> |-|-|
> |Profile|GStreamer-MPEG2_VIDEO-V4L2-Gst1.0|
> |MAIN|26/32|
> |PROFILE_4_2_2|0/9|
> |SIMPLE|4/11|
> |-|-|
> 
> Fixes: 059790467bf4 ("media: venus: helpers: handle correctly vbuf field")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> drivers/media/platform/qcom/venus/helpers.c | 5 -----
> 1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c
> index 747c388fe25f..71e79093a4c7 100644
> --- a/drivers/media/platform/qcom/venus/helpers.c
> +++ b/drivers/media/platform/qcom/venus/helpers.c
> @@ -1466,11 +1466,6 @@ int venus_helper_vb2_buf_prepare(struct vb2_buffer *vb)
> if (V4L2_TYPE_IS_OUTPUT(vb->vb2_queue->type)) {
> if (vbuf->field == V4L2_FIELD_ANY)
> vbuf->field = V4L2_FIELD_NONE;
> - if (vbuf->field != V4L2_FIELD_NONE) {
> - dev_err(inst->core->dev, "%s field isn't supported\n",
> - __func__);
> - return -EINVAL;
> - }
> }
> 
> if (vb->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE &&
> 
> ---
> base-commit: 779cae956c8316aebc1946ef86ca001f99658270
> change-id: 20260228-venus-mpeg2-495f9187a1ec
> 
> Best regards,
> -- 
> With best wishes
> Dmitry
> 
> 


Dmitry,
I applied this on 6.19.4 mainline and give run with interlaced content (hd tv) on qcs6490 (radxa dragon sbc).
Playback fails like this: https://gist.github.com/warpme/a368983678af0a76af85314808773076
pls see a bootom kernel output showing venus failure.
my sw stack plays ok on e.g rpi4 stateful v4l2m2m so i think root cause isn't in my userspace....
pls let me know if anything extra is required to fix venus decoder issue.
br 
   

  reply	other threads:[~2026-02-28 20:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-28  9:49 Dmitry Baryshkov
2026-02-28 20:54 ` Piotr Oniszczuk [this message]
2026-02-28 22:35   ` Dmitry Baryshkov
2026-03-02  7:31     ` Vikash Garodia
2026-03-02 11:11       ` Piotr Oniszczuk
2026-03-02 11:28       ` Dmitry Baryshkov
2026-03-04 13:28         ` Vikash Garodia
2026-03-06 11:04           ` Piotr Oniszczuk
2026-08-15 17:55             ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CA1838F-504D-4EEA-99F4-B3CC5EB10EDA@gmail.com \
    --to=piotr.oniszczuk@gmail.com \
    --cc=bod@kernel.org \
    --cc=dikshita.agarwal@oss.qualcomm.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab+samsung@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=stanimir.varbanov@linaro.org \
    --cc=vikash.garodia@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®