From: Pekka Enberg <penberg@kernel.org>
To: David Rientjes <rientjes@google.com>
Cc: Christoph Lameter <cl@linux.com>,
Bart Van Assche <bvanassche@acm.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] slub: Fix sysfs circular locking dependency
Date: Tue, 11 Jan 2011 08:37:29 +0200 [thread overview]
Message-ID: <4D2BFAA9.2050200@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1101101230190.11969@chino.kir.corp.google.com>
On 1/10/11 10:30 PM, David Rientjes wrote:
> On Mon, 10 Jan 2011, Christoph Lameter wrote:
>
>> New patch that just covers the slub changes.
>>
>> Subject: slub: Avoid use of slub_lock in show_slab_objects()
>>
>> The purpose of the locking is to prevent removal and additions
>> of nodes when statistics are gathered for a slab cache. So we
>> need to avoid racing with memory hotplug functionality.
>>
>> It is enough to take the memory hotplug locks there instead
>> of the slub_lock.
>>
>> online_pages() currently does not acquire the memory_hotplug
>> lock. Another patch will be submitted by the memory hotplug
>> authors to take the memory hotplug lock and describe the
>> uses of the memory hotplug lock to protect against
>> adding and removal of nodes from non hotplug data structures.
>>
>> Signed-off-by: Christoph Lameter<cl@linux.com>
> Acked-by: David Rientjes<rientjes@google.com>
Is this safe to be applied without the other hotplug parts?
next prev parent reply other threads:[~2011-01-11 6:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 20:25 Pekka Enberg
2011-01-05 3:44 ` David Rientjes
2011-01-05 15:51 ` Christoph Lameter
2011-01-05 17:10 ` Christoph Lameter
2011-01-05 18:26 ` Pekka Enberg
2011-01-05 18:50 ` Bart Van Assche
2011-01-05 18:53 ` Pekka Enberg
2011-01-06 8:29 ` David Rientjes
2011-01-06 18:10 ` Christoph Lameter
2011-01-06 20:47 ` David Rientjes
2011-01-07 0:11 ` KAMEZAWA Hiroyuki
2011-01-07 15:22 ` Christoph Lameter
2011-01-07 20:34 ` David Rientjes
2011-01-08 7:42 ` Bart Van Assche
2011-01-08 8:28 ` Pekka Enberg
2011-01-10 16:15 ` Christoph Lameter
2011-01-10 20:30 ` David Rientjes
2011-01-11 6:37 ` Pekka Enberg [this message]
2011-01-11 7:44 ` [PATCH] one more lock on memory hotplug (Re: " KAMEZAWA Hiroyuki
2011-01-11 8:21 ` David Rientjes
2011-01-11 14:41 ` Christoph Lameter
2011-01-11 15:25 ` Pekka Enberg
2011-01-11 8:24 ` David Rientjes
2011-01-11 8:29 ` Pekka Enberg
2011-01-08 8:29 ` Pekka Enberg
2011-01-10 16:12 ` Christoph Lameter
2011-01-11 0:47 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2BFAA9.2050200@kernel.org \
--to=penberg@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bvanassche@acm.org \
--cc=cl@linux.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®