mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Lameter <cl@linux.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Bart Van Assche <bvanassche@acm.org>,
	David Rientjes <rientjes@google.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] slub: Fix sysfs circular locking dependency
Date: Mon, 10 Jan 2011 10:15:15 -0600 (CST)	[thread overview]
Message-ID: <alpine.DEB.2.00.1101101014470.12243@router.home> (raw)
In-Reply-To: <1294475323.5248.74.camel@jaguar>

New patch that just covers the slub changes.

Subject: slub: Avoid use of slub_lock in show_slab_objects()

The purpose of the locking is to prevent removal and additions
of nodes when statistics are gathered for a slab cache. So we
need to avoid racing with memory hotplug functionality.

It is enough to take the memory hotplug locks there instead
of the slub_lock.

online_pages() currently does not acquire the memory_hotplug
lock. Another patch will be submitted by the memory hotplug
authors to take the memory hotplug lock and describe the
uses of the memory hotplug lock to protect against
adding and removal of nodes from non hotplug data structures.

Signed-off-by: Christoph Lameter <cl@linux.com>

---
 mm/memory_hotplug.c |   17 +++++++++++------
 mm/slub.c           |    4 ++--
 2 files changed, 13 insertions(+), 8 deletions(-)

Index: linux-2.6/mm/slub.c
===================================================================
--- linux-2.6.orig/mm/slub.c	2011-01-10 09:02:08.000000000 -0600
+++ linux-2.6/mm/slub.c	2011-01-10 10:10:46.000000000 -0600
@@ -3781,7 +3781,7 @@ static ssize_t show_slab_objects(struct
 		}
 	}

-	down_read(&slub_lock);
+	lock_memory_hotplug();
 #ifdef CONFIG_SLUB_DEBUG
 	if (flags & SO_ALL) {
 		for_each_node_state(node, N_NORMAL_MEMORY) {
@@ -3822,7 +3822,7 @@ static ssize_t show_slab_objects(struct
 			x += sprintf(buf + x, " N%d=%lu",
 					node, nodes[node]);
 #endif
-	up_read(&slub_lock);
+	unlock_memory_hotplug();
 	kfree(nodes);
 	return x + sprintf(buf + x, "\n");
 }


  reply	other threads:[~2011-01-10 16:15 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-04 20:25 Pekka Enberg
2011-01-05  3:44 ` David Rientjes
2011-01-05 15:51   ` Christoph Lameter
2011-01-05 17:10     ` Christoph Lameter
2011-01-05 18:26       ` Pekka Enberg
2011-01-05 18:50         ` Bart Van Assche
2011-01-05 18:53           ` Pekka Enberg
2011-01-06  8:29             ` David Rientjes
2011-01-06 18:10               ` Christoph Lameter
2011-01-06 20:47                 ` David Rientjes
2011-01-07  0:11                 ` KAMEZAWA Hiroyuki
2011-01-07 15:22                   ` Christoph Lameter
2011-01-07 20:34                     ` David Rientjes
2011-01-08  7:42                       ` Bart Van Assche
2011-01-08  8:28                         ` Pekka Enberg
2011-01-10 16:15                           ` Christoph Lameter [this message]
2011-01-10 20:30                             ` David Rientjes
2011-01-11  6:37                               ` Pekka Enberg
2011-01-11  7:44                                 ` [PATCH] one more lock on memory hotplug (Re: " KAMEZAWA Hiroyuki
2011-01-11  8:21                                   ` David Rientjes
2011-01-11 14:41                                   ` Christoph Lameter
2011-01-11 15:25                                     ` Pekka Enberg
2011-01-11  8:24                                 ` David Rientjes
2011-01-11  8:29                                   ` Pekka Enberg
2011-01-08  8:29                       ` Pekka Enberg
2011-01-10 16:12                         ` Christoph Lameter
2011-01-11  0:47                           ` KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1101101014470.12243@router.home \
    --to=cl@linux.com \
    --cc=akpm@linux-foundation.org \
    --cc=bvanassche@acm.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®