* Re: [PATCH 0/2] RFC: introduce typechecking to platform_{get,set}_drvdata
[not found] ` <20110216135547.8940e19d.akpm@linux-foundation.org>
@ 2011-02-16 21:59 ` Marc Kleine-Budde
0 siblings, 0 replies; 3+ messages in thread
From: Marc Kleine-Budde @ 2011-02-16 21:59 UTC (permalink / raw)
To: Andrew Morton; +Cc: kernel, Greg Kroah-Hartman, LKML
[-- Attachment #1: Type: text/plain, Size: 1126 bytes --]
On 02/16/2011 10:55 PM, Andrew Morton wrote:
> On Wed, 16 Feb 2011 22:49:52 +0100
> Marc Kleine-Budde <mkl@pengutronix.de> wrote:
>
>> From: Marc Kleine-Budde <mkl@pengutronix.de>
>> To: kernel@pengutronix.de
>> Cc: Greg Kroah-Hartman <gregkh@suse.de>, Andrew Morton <akpm@linux-foundation.org>
>
> No mailing list was cc'ed.
just noticed, sorry :(
>> Subject: [PATCH 0/2] RFC: introduce typechecking to platform_{get,set}_drvdata
>> Date: Wed, 16 Feb 2011 22:49:52 +0100
>> X-Mailer: git-send-email 1.7.2.3
>>
>> Hello,
>>
>> just found a mis-user of platform_set_drvdata(), so introduce typechecking
>> to these macro definitions.
>
> ick.
>
>> An alternative would be to make them static inline
>> functions.
>
> A vastly preferable alternative! How's about doing that?
Sure...wait for "v2"
regards, Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 0/2] RFC: introduce typechecking to platform_{get,set}_drvdata
@ 2011-02-16 21:55 Marc Kleine-Budde
2011-02-16 22:02 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Marc Kleine-Budde @ 2011-02-16 21:55 UTC (permalink / raw)
To: kernel; +Cc: Greg Kroah-Hartman, Andrew Morton, linux-kernel
Hello,
just found a mis-user of platform_set_drvdata(), so introduce typechecking
to these macro definitions. An alternative would be to make them static inline
functions.
comments welcome,
Marc
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 0/2] RFC: introduce typechecking to platform_{get,set}_drvdata
2011-02-16 21:55 Marc Kleine-Budde
@ 2011-02-16 22:02 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2011-02-16 22:02 UTC (permalink / raw)
To: Marc Kleine-Budde; +Cc: kernel, Andrew Morton, linux-kernel
On Wed, Feb 16, 2011 at 10:55:49PM +0100, Marc Kleine-Budde wrote:
> Hello,
>
> just found a mis-user of platform_set_drvdata(), so introduce typechecking
> to these macro definitions. An alternative would be to make them static inline
> functions.
Make it a static inline, that way you don't have to create that new
macro, as the build will warn/break right away.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-16 22:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1297892994-30801-1-git-send-email-mkl@pengutronix.de>
[not found] ` <20110216135547.8940e19d.akpm@linux-foundation.org>
2011-02-16 21:59 ` [PATCH 0/2] RFC: introduce typechecking to platform_{get,set}_drvdata Marc Kleine-Budde
2011-02-16 21:55 Marc Kleine-Budde
2011-02-16 22:02 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome