From: Lars-Peter Clausen <lars@metafoo.de>
To: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
linus.walleij@stericsson.com, tglx@linutronix.de,
lars@metafoo.de
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:irq/core] genirq: Add IRQCHIP_SET_TYPE_MASKED flag
Date: Mon, 21 Feb 2011 14:17:13 +0100 [thread overview]
Message-ID: <4D6265D9.8020406@metafoo.de> (raw)
In-Reply-To: <tip-d4d5e08960844a062da8387ee5f16ca7a33200d0@git.kernel.org>
> @@ -588,11 +596,13 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned
int irq,
>
> if (chip != desc->irq_data.chip)
> irq_chip_set_defaults(desc->irq_data.chip);
> - return 0;
> + ret = 0;
I've just tested the patch and noticed that a 'break' is missing here.
> default:
> pr_err("setting trigger mode %lu for irq %u failed (%pF)\n",
> flags, irq, chip->irq_set_type);
> }
> + if (unmask)
> + unmask_irq(desc);
> return ret;
> }
>
> @@ -669,7 +679,7 @@ again:
>
> #ifdef CONFIG_SMP
> /*
> - * Check whether we need to change the affinity of the interrupt thread.
> + * Check whether we need to chasnge the affinity of the interrupt thread.
> */
> static void
> irq_thread_check_affinity(struct irq_desc *desc, struct irqaction *action)
next parent reply other threads:[~2011-02-21 13:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-d4d5e08960844a062da8387ee5f16ca7a33200d0@git.kernel.org>
2011-02-21 13:17 ` Lars-Peter Clausen [this message]
2011-02-21 13:18 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6265D9.8020406@metafoo.de \
--to=lars@metafoo.de \
--cc=hpa@zytor.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®