mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
	linus.walleij@stericsson.com, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:irq/core] genirq: Add IRQCHIP_SET_TYPE_MASKED flag
Date: Mon, 21 Feb 2011 14:18:53 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.00.1102211418220.2701@localhost6.localdomain6> (raw)
In-Reply-To: <4D6265D9.8020406@metafoo.de>

On Mon, 21 Feb 2011, Lars-Peter Clausen wrote:

>  > @@ -588,11 +596,13 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned
> int irq,
> >  
> >  		if (chip != desc->irq_data.chip)
> >  			irq_chip_set_defaults(desc->irq_data.chip);
> > -		return 0;
> > +		ret = 0;
> 
> I've just tested the patch and noticed that a 'break' is missing here.

Grmbl. Thanks for catching that !

Thanks,

	tglx

      reply	other threads:[~2011-02-21 13:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tip-d4d5e08960844a062da8387ee5f16ca7a33200d0@git.kernel.org>
2011-02-21 13:17 ` Lars-Peter Clausen
2011-02-21 13:18   ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1102211418220.2701@localhost6.localdomain6 \
    --to=tglx@linutronix.de \
    --cc=hpa@zytor.com \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®