mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luka Gejak <luka.gejak@linux.dev>
To: Jie Feng <hjf3108@gmail.com>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bitterblue Smith <rtl8821cerfe2@gmail.com>
Subject: Re: [PATCH rtw-next v4 1/7] wifi: rtw88: 8812a, 8814a: enable STBC for HT transmissions
Date: Mon, 16 Nov 2026 09:06:48 +0100	[thread overview]
Message-ID: <4E88B598-B337-49A2-92E5-AE122A6B1D85@linux.dev> (raw)
In-Reply-To: <CABOQOSU4Oebap-U=6oGa_VQsZwm4szumK93XFJ__w0Q4f25=iQ@mail.gmail.com>

On November 16, 2026 7:54:02 AM GMT+01:00, Jie Feng <hjf3108@gmail.com>
wrote:
>On Sun, 15 Nov 2026 at 05:35, Luka Gejak <luka.gejak@linux.dev> wrote:
>>
>> Hi Jie Feng,
>>
>> Thanks for the update. Two comments below.
>>
>> On November 15, 2026 12:43:27 PM GMT+01:00, Ho Jie Feng
><hjf3108@gmail.com>
>> wrote:
>>
>> > 8812a and 8814a support STBC, enable it.
>>
>> Could you mention here that this enables HT TX STBC on these chips? As
>> far as I can see, VHT TX STBC was already advertised when more than one
>RF
>> path is available, so that would make the scope clearer.
>The commit subject line already mentions HT explicitly, do you think
>it will be better
>to put it again in the description too?

The subject makes the HT scope clear. I think it would still help to
explain that these chips already advertised VHT TX STBC but did not
advertise it for HT. That would give the change a little more context.

>
>> [ ... ]
>>
>> > Tested on RTL8812AU, STBC packets were captured in monitor mode.
>>
>> Were these HT transmissions from the RTL8812AU, for example on 2.4 GHz
>> or with an HT only AP? As far as I can see, we already advertise VHT TX
>> STBC on this chip, so a VHT capture would not confirm the change here.
>Yes it is a HT only AP, I see HT STBC packets in the capture.
>

Thanks, that answers my question.

Best regards,
Luka Gejak

  reply	other threads:[~2026-11-16  8:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 11:43 [PATCH rtw-next v4 0/7] wifi: rtw88: extend 88xxA support Ho Jie Feng
2026-11-15 11:43 ` [PATCH rtw-next v4 1/7] wifi: rtw88: 8812a, 8814a: enable STBC for HT transmissions Ho Jie Feng
2026-11-15 13:35   ` Luka Gejak
2026-11-16  6:54     ` Jie Feng
2026-11-16  8:06       ` Luka Gejak [this message]
2026-11-15 11:43 ` [PATCH rtw-next v4 2/7] wifi: rtw88: skip the dynamic CSI rate without a cfg_csi_rate op Ho Jie Feng
2026-11-15 11:43 ` [PATCH rtw-next v4 3/7] wifi: rtw88: correctly expose beamformee capabilities Ho Jie Feng
2026-11-15 13:20   ` Luka Gejak
2026-11-15 13:36   ` Luka Gejak
2026-11-15 13:37   ` Luka Gejak
2026-11-15 13:39     ` Luka Gejak
2026-11-15 11:43 ` [PATCH rtw-next v4 4/7] wifi: rtw88: 88xxa: receive VHT SU beamformed transmissions Ho Jie Feng
2026-11-15 11:43 ` [PATCH rtw-next v4 5/7] wifi: rtw88: prepare frequency-offset correction for more chips Ho Jie Feng
2026-11-15 13:41   ` Luka Gejak
2026-11-15 11:43 ` [PATCH rtw-next v4 6/7] wifi: rtw88: 88xxa: correct carrier-frequency offset Ho Jie Feng
2026-11-15 13:20   ` Luka Gejak
2026-11-15 13:42   ` Luka Gejak
2026-11-15 11:43 ` [PATCH rtw-next v4 7/7] wifi: rtw88: 8812a, 8821a: respect peer A-MPDU size limits Ho Jie Feng
2026-11-15 13:43   ` Luka Gejak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E88B598-B337-49A2-92E5-AE122A6B1D85@linux.dev \
    --to=luka.gejak@linux.dev \
    --cc=hjf3108@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    --cc=rtl8821cerfe2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®