mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: spi-devel-general@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, qi.wang@intel.com,
	yong.y.wang@intel.com, joel.clark@intel.com,
	kok.howg.ewe@intel.com, toshiharu-linux@dsn.okisemi.com
Subject: Re: [PATCH 1/5] spi-topcliff-pch: add tx-memory clear after complete transmitting
Date: Tue, 04 Oct 2011 18:15:26 +0900	[thread overview]
Message-ID: <4E8ACEAE.3040400@dsn.lapis-semi.com> (raw)
In-Reply-To: <1315295914-6862-1-git-send-email-tomoya-linux@dsn.okisemi.com>

Hi Grant,

1 month has passed. You look very busy, right ?
We've been long waiting for your accept.
Could you review these patch series ?

Thanks in advance.

(2011/09/06 16:58), Tomoya MORINAGA wrote:
> Currently, in case of reading date from SPI flash,
> command is sent twice.
> The cause is that tx-memory clear processing is missing .
> This patch adds the tx-momory clear processing.
> 
> Signed-off-by: Tomoya MORINAGA<tomoya-linux@dsn.okisemi.com>
> ---
>   drivers/spi/spi-topcliff-pch.c |    5 +++++
>   1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
> index 540c290..1b98b7e 100644
> --- a/drivers/spi/spi-topcliff-pch.c
> +++ b/drivers/spi/spi-topcliff-pch.c
> @@ -839,6 +839,11 @@ static void pch_spi_start_transfer(struct pch_spi_data *data)
> 
>   	dma_sync_sg_for_cpu(&data->master->dev, dma->sg_rx_p, dma->nent,
>   			    DMA_FROM_DEVICE);
> +
> +	dma_sync_sg_for_cpu(&data->master->dev, dma->sg_tx_p, dma->nent,
> +			    DMA_FROM_DEVICE);
> +	memset(data->dma.tx_buf_virt, 0, PAGE_SIZE);
> +
>   	async_tx_ack(dma->desc_rx);
>   	async_tx_ack(dma->desc_tx);
>   	kfree(dma->sg_tx_p);


-- 
tomoya
ROHM Co., Ltd.

  parent reply	other threads:[~2011-10-04  9:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-06  7:58 Tomoya MORINAGA
2011-09-06  7:58 ` [PATCH 2/5] spi-topcliff-pch: Fix SSN Control issue Tomoya MORINAGA
2011-09-06  7:58 ` [PATCH 3/5] spi-topcliff-pch: Fix CPU read complete condition issue Tomoya MORINAGA
2011-09-06  7:58 ` [PATCH 4/5] spi-topcliff-pch: Add recovery processing in case FIFO overrun error occurs Tomoya MORINAGA
2011-09-06  7:58 ` [PATCH 5/5] spi-topcliff-pch: Fix overrun issue Tomoya MORINAGA
2011-10-04  9:15 ` Tomoya MORINAGA [this message]
2011-10-04 10:35   ` [PATCH 1/5] spi-topcliff-pch: add tx-memory clear after complete transmitting Alan Cox
2011-10-04 16:03   ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8ACEAE.3040400@dsn.lapis-semi.com \
    --to=tomoya-linux@dsn.lapis-semi.com \
    --cc=grant.likely@secretlab.ca \
    --cc=joel.clark@intel.com \
    --cc=kok.howg.ewe@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qi.wang@intel.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    --cc=toshiharu-linux@dsn.okisemi.com \
    --cc=yong.y.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®