mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] tracing: fix event system memory leak
@ 2011-10-28  6:55 Li Zefan
  0 siblings, 0 replies; only message in thread
From: Li Zefan @ 2011-10-28  6:55 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: LKML

system->ref_count = system->nr_events + ref_count for opening "enable"
and "filter"

so when removing a module, it's wrong to drop ref_count only when nr_events
drops to 0.

Cc: stable <stable@kernel.org>
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
 kernel/trace/trace_events.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 581876f..281a60a 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -1252,8 +1252,8 @@ static void remove_subsystem_dir(const char *name)
 			if (!--system->nr_events) {
 				debugfs_remove_recursive(system->entry);
 				list_del(&system->list);
-				__put_system(system);
 			}
+			__put_system(system);
 			break;
 		}
 	}
-- 
1.7.3.1

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-10-28  6:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-28  6:55 [PATCH] tracing: fix event system memory leak Li Zefan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®