From: Thomas Jarosch <thomas.jarosch@intra2net.com>
To: Haavard Skinnemoen <hskinnemoen@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: AVR32 code: Mismatching comparison
Date: Thu, 17 Nov 2011 21:50:37 +0100 [thread overview]
Message-ID: <4EC5739D.9010008@intra2net.com> (raw)
Hi Haavard,
consider this piece of code from
arch/avr32/kernel/module.c:
....
case R_AVR32_GOT18SW:
if ((relocation & 0xfffe0003) != 0
&& (relocation & 0xfffc0003) != 0xffff0000)
return reloc_overflow(module, "R_AVR32_GOT18SW",
relocation);
relocation >>= 2;
/* fall through */
...
cppcheck reports for line 267:
"Mismatching comparison, the result is always true"
This probably needs a fix.
Cheers,
Thomas
reply other threads:[~2011-11-17 20:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC5739D.9010008@intra2net.com \
--to=thomas.jarosch@intra2net.com \
--cc=hskinnemoen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome