mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* AVR32 code: Mismatching comparison
@ 2011-11-17 20:50 Thomas Jarosch
  0 siblings, 0 replies; only message in thread
From: Thomas Jarosch @ 2011-11-17 20:50 UTC (permalink / raw)
  To: Haavard Skinnemoen; +Cc: linux-kernel

Hi Haavard,

consider this piece of code from
arch/avr32/kernel/module.c:

....
case R_AVR32_GOT18SW:
    if ((relocation & 0xfffe0003) != 0
        && (relocation & 0xfffc0003) != 0xffff0000)
        return reloc_overflow(module, "R_AVR32_GOT18SW",
                    relocation);
    relocation >>= 2;
    /* fall through */
...

cppcheck reports for line 267:
"Mismatching comparison, the result is always true"

This probably needs a fix.

Cheers,
Thomas

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-11-17 20:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-17 20:50 AVR32 code: Mismatching comparison Thomas Jarosch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome