mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Thomas Gleixner <tglx@linutronix.de>,
	H Peter Anvin <hpa@zytor.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Tony Luck <tony.luck@intel.com>,
	Arjan van de Ven <arjan.van.de.ven@intel.com>,
	Suresh B Siddha <suresh.b.siddha@intel.com>,
	Len Brown <len.brown@intel.com>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-pm <linux-pm@vger.kernel.org>, x86 <x86@kernel.org>,
	Tejun Heo <tj@kernel.org>, Borislav Petkov <bp@amd64.org>,
	"Herrmann3, Andreas" <Andreas.Herrmann3@amd.com>
Subject: Re: [PATCH v4 0/7] x86: BSP or CPU0 online/offline
Date: Tue, 06 Dec 2011 16:55:02 +0530	[thread overview]
Message-ID: <4EDDFB8E.10801@linux.vnet.ibm.com> (raw)
In-Reply-To: <4EDDF2DE.7020701@linux.vnet.ibm.com>

On 12/06/2011 04:17 PM, Srivatsa S. Bhat wrote:

> On 12/06/2011 04:05 PM, Ingo Molnar wrote:
> 
>>
>> * Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> wrote:
>>
>>>> But the hibernation angle should be considered. Hibernation 
>>>> already has to deal with the case where someone physically 
>>>> unplugs a CPU and then resumes from the disk image, right? 
>>>> How does the hibernation code handle that case currently?
>>>
>>> Oh, wait a minute. Are we talking about physical CPU Hotplug 
>>> in between hibernation and restore? AFAIK, currently we don't 
>>> handle that at all. [...]
>>
>> Well, not hotplug, but plain old-fashioned: 'hibernate the box, 
>> take out a CPU physically and thaw' kind of hardware change.
>>
> 
> 
> Well, actually that's what I meant, taking this same idea a bit
> further: hibernate the box, take out a CPU physically, insert a
> slightly different CPU (which needs a different microcode image)
> and thaw.
> 
> In this case, the other patch that I mentioned in my previous mail
> would be required (or an equivalent), because the optimization
> patch which is now in mainline, would apply the same old microcode
> image on this new CPU too, blindly.
> 


By the way, this problem is not tied to CPU0 alone, it exists for any
CPU! (as long as we are talking about plugging in/out CPUs physically).

Regards,
Srivatsa S. Bhat


  reply	other threads:[~2011-12-06 11:25 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-12  5:26 Fenghua Yu
2011-11-12  5:26 ` [PATCH v4 1/7] x86/topology.c: Support functions for BSP online/offline Fenghua Yu
2011-11-12  5:26 ` [PATCH v4 2/7] x86/common.c: Init BSP data during BSP online Fenghua Yu
2011-11-12  5:26 ` [PATCH v4 3/7] x86/mtrr/main.c: Ask the first online CPU to save mtrr Fenghua Yu
2011-11-12  5:26 ` [PATCH v4 4/7] x86/smpboot.c: Don't offline BSP if any irq can not be migrated out of it Fenghua Yu
2011-11-12  5:26 ` [PATCH v4 5/7] Documentations/cpu-hotplug.tx, kernel-parameters.txt: Add x86 CPU0 online/offline feature Fenghua Yu
2011-11-12  5:26 ` [PATCH v4 6/7] x86/i387.c: Thread xstate is initialized only on BSP once Fenghua Yu
2011-11-13 15:17   ` Brian Gerst
2011-11-12  5:26 ` [PATCH v4 7/7] x86/power/cpu.c: Don't hibernate/suspend if CPU0 is offline Fenghua Yu
2011-12-06  8:42 ` [PATCH v4 0/7] x86: BSP or CPU0 online/offline Ingo Molnar
2011-12-06  8:58   ` Ingo Molnar
2011-12-06  9:52     ` Srivatsa S. Bhat
2011-12-06 10:35       ` Ingo Molnar
2011-12-06 10:47         ` Srivatsa S. Bhat
2011-12-06 11:25           ` Srivatsa S. Bhat [this message]
2011-12-06 13:03             ` Borislav Petkov
2011-12-06 13:52               ` Ingo Molnar
2011-12-07  0:04                 ` Yu, Fenghua
2011-12-07  0:15               ` Yu, Fenghua
2011-12-07  7:40                 ` Ingo Molnar
2011-12-07 17:08                   ` Luck, Tony
2011-12-07 22:21                     ` Ingo Molnar
2011-12-08  0:53                       ` Luck, Tony
2011-12-08  4:43                         ` Ingo Molnar
2011-12-06 13:00           ` Borislav Petkov
2011-12-06 14:04             ` Srivatsa S. Bhat
2011-12-06 14:15               ` Borislav Petkov
2011-12-06 14:19                 ` Srivatsa S. Bhat
2011-12-06 14:58     ` Van De Ven, Arjan
2011-12-06 14:15   ` Srivatsa S. Bhat
2011-12-09  0:41   ` Yu, Fenghua
2011-12-09  7:28     ` Ingo Molnar
2011-12-15 18:38   ` Yu, Fenghua
2011-12-15 18:57     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EDDFB8E.10801@linux.vnet.ibm.com \
    --to=srivatsa.bhat@linux.vnet.ibm.com \
    --cc=Andreas.Herrmann3@amd.com \
    --cc=akpm@linux-foundation.org \
    --cc=arjan.van.de.ven@intel.com \
    --cc=bp@amd64.org \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=konrad.wilk@oracle.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=rdunlap@xenotime.net \
    --cc=rjw@sisk.pl \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome