From: Lars-Peter Clausen <lars@metafoo.de>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: broonie@opensource.wolfsonmicro.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH V4 2/2] regmap: add regmap_bulk_write() for register write
Date: Sun, 12 Feb 2012 12:57:25 +0100 [thread overview]
Message-ID: <4F37A925.90507@metafoo.de> (raw)
In-Reply-To: <1329036556-15408-1-git-send-email-ldewangan@nvidia.com>
On 02/12/2012 09:49 AM, Laxman Dewangan wrote:
> [...]
> + } else {
> + for (i = 0; i < val_count; i++) {
> + memcpy(&ival, val + (i * val_bytes), val_bytes);
This will have endianess issues. You'll need something like regcache_get_val.
> + ret = _regmap_write(map, reg + i, ival);
> + if (ret) {
> + dev_err(map->dev,
> + "Error in register %u write, ret %d\n",
> + reg + i, ret);
> + break;
> + }
> + }
> + }
> [...]
next prev parent reply other threads:[~2012-02-12 11:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-12 8:49 Laxman Dewangan
2012-02-12 11:57 ` Lars-Peter Clausen [this message]
2012-02-12 13:11 ` Mark Brown
2012-02-12 14:14 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F37A925.90507@metafoo.de \
--to=lars@metafoo.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gregkh@linuxfoundation.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome