Re: [PATCH V4 2/2] regmap: add regmap_bulk_write() for register write

[Laxman Dewangan <ldewangan@nvidia.com>]

On Sunday 12 February 2012 06:41 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Sun, Feb 12, 2012 at 12:57:25PM +0100, Lars-Peter Clausen wrote:
>> On 02/12/2012 09:49 AM, Laxman Dewangan wrote:
>>> [...]
>>> +	} else {
>>> +		for (i = 0; i<  val_count; i++) {
>>> +			memcpy(&ival, val + (i * val_bytes), val_bytes);
>> This will have endianess issues. You'll need something like regcache_get_val.
The data pointer of this function is in cpu-endianess and so I am just 
copying it because regmap_write takes integer type value.
>>> +			ret = _regmap_write(map, reg + i, ival);
> Or just don't provide this fallback at all - it's not something the
> underlying device supports anyway and none of the other block or bulk
> operations work on these devices either.
Yaah, Seeing other function I think I can remove this fallback.

> * Unknown Key
> * 0x6E30FDDD