* [PATCH RFC] spi/omap: Trivial cleanup
@ 2012-02-29 14:04 Shubhrajyoti D
2012-03-06 10:16 ` Cousson, Benoit
0 siblings, 1 reply; 3+ messages in thread
From: Shubhrajyoti D @ 2012-02-29 14:04 UTC (permalink / raw)
To: spi-devel-general
Cc: linux-omap, linux-kernel, Shubhrajyoti D, Benoit Cousson
The context is stored directly inside drvdata structure post
[f887876 spi/omap: Remove bus_num usage for instance index].
Remove the OMAP2_MCSPI_MAX_CTRL macro as it is not needed anymore.
Cc: Benoit Cousson <b-cousson@ti.com>
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
Applies on Benoit's for_3.4/dt_spi_eth
drivers/spi/spi-omap2-mcspi.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
index d1eb26c..3526281 100644
--- a/drivers/spi/spi-omap2-mcspi.c
+++ b/drivers/spi/spi-omap2-mcspi.c
@@ -45,9 +45,6 @@
#define OMAP2_MCSPI_MAX_FREQ 48000000
-/* OMAP2 has 3 SPI controllers, while OMAP3 has 4 */
-#define OMAP2_MCSPI_MAX_CTRL 4
-
#define OMAP2_MCSPI_REVISION 0x00
#define OMAP2_MCSPI_SYSSTATUS 0x14
#define OMAP2_MCSPI_IRQSTATUS 0x18
--
1.7.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RFC] spi/omap: Trivial cleanup
2012-02-29 14:04 [PATCH RFC] spi/omap: Trivial cleanup Shubhrajyoti D
@ 2012-03-06 10:16 ` Cousson, Benoit
2012-03-06 13:15 ` Shubhrajyoti
0 siblings, 1 reply; 3+ messages in thread
From: Cousson, Benoit @ 2012-03-06 10:16 UTC (permalink / raw)
To: Shubhrajyoti D; +Cc: spi-devel-general, linux-omap, linux-kernel
Hi Shubhro,
On 2/29/2012 3:04 PM, Shubhrajyoti D wrote:
> The context is stored directly inside drvdata structure post
> [f887876 spi/omap: Remove bus_num usage for instance index].
> Remove the OMAP2_MCSPI_MAX_CTRL macro as it is not needed anymore.
>
> Cc: Benoit Cousson<b-cousson@ti.com>
> Signed-off-by: Shubhrajyoti D<shubhrajyoti@ti.com>
Thanks for that extra cleanup, I missed it.
Acked-by: Benoit Cousson <b-cousson@ti.com>
> ---
> Applies on Benoit's for_3.4/dt_spi_eth
>
> drivers/spi/spi-omap2-mcspi.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
> index d1eb26c..3526281 100644
> --- a/drivers/spi/spi-omap2-mcspi.c
> +++ b/drivers/spi/spi-omap2-mcspi.c
> @@ -45,9 +45,6 @@
>
> #define OMAP2_MCSPI_MAX_FREQ 48000000
>
> -/* OMAP2 has 3 SPI controllers, while OMAP3 has 4 */
> -#define OMAP2_MCSPI_MAX_CTRL 4
> -
I guess it can be included in the "spi/omap: Remove bus_num usage for
instance index"?
Is that OK for you?
Thanks,
Benoit
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RFC] spi/omap: Trivial cleanup
2012-03-06 10:16 ` Cousson, Benoit
@ 2012-03-06 13:15 ` Shubhrajyoti
0 siblings, 0 replies; 3+ messages in thread
From: Shubhrajyoti @ 2012-03-06 13:15 UTC (permalink / raw)
To: Cousson, Benoit; +Cc: spi-devel-general, linux-omap, linux-kernel
On Tuesday 06 March 2012 03:46 PM, Cousson, Benoit wrote:
> Hi Shubhro,
>
> On 2/29/2012 3:04 PM, Shubhrajyoti D wrote:
>> The context is stored directly inside drvdata structure post
>> [f887876 spi/omap: Remove bus_num usage for instance index].
>> Remove the OMAP2_MCSPI_MAX_CTRL macro as it is not needed anymore.
>>
>> Cc: Benoit Cousson<b-cousson@ti.com>
>> Signed-off-by: Shubhrajyoti D<shubhrajyoti@ti.com>
>
> Thanks for that extra cleanup, I missed it.
>
> Acked-by: Benoit Cousson <b-cousson@ti.com>
>
>> ---
>> Applies on Benoit's for_3.4/dt_spi_eth
>>
>> drivers/spi/spi-omap2-mcspi.c | 3 ---
>> 1 files changed, 0 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/spi/spi-omap2-mcspi.c
>> b/drivers/spi/spi-omap2-mcspi.c
>> index d1eb26c..3526281 100644
>> --- a/drivers/spi/spi-omap2-mcspi.c
>> +++ b/drivers/spi/spi-omap2-mcspi.c
>> @@ -45,9 +45,6 @@
>>
>> #define OMAP2_MCSPI_MAX_FREQ 48000000
>>
>> -/* OMAP2 has 3 SPI controllers, while OMAP3 has 4 */
>> -#define OMAP2_MCSPI_MAX_CTRL 4
>> -
>
> I guess it can be included in the "spi/omap: Remove bus_num usage for
> instance index"?
> Is that OK for you?
Yes, sure.
>
>
> Thanks,
> Benoit
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-06 13:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-29 14:04 [PATCH RFC] spi/omap: Trivial cleanup Shubhrajyoti D
2012-03-06 10:16 ` Cousson, Benoit
2012-03-06 13:15 ` Shubhrajyoti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome