mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] modpost: fix ALL_INIT_DATA_SECTIONS
@ 2012-03-08  9:41 Jan Beulich
  2012-03-26 20:41 ` Michal Marek
  0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2012-03-08  9:41 UTC (permalink / raw)
  To: rusty, Michal Marek; +Cc: linux-kbuild, linux-kernel

This was lacking a comma between two supposed to be separate strings.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

---
 scripts/mod/modpost.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- 3.3-rc6/scripts/mod/modpost.c
+++ 3.3-rc6-modpost-all-init-data/scripts/mod/modpost.c
@@ -849,7 +849,7 @@ static void check_section(const char *mo
 
 #define ALL_INIT_DATA_SECTIONS \
 	".init.setup$", ".init.rodata$", \
-	".devinit.rodata$", ".cpuinit.rodata$", ".meminit.rodata$" \
+	".devinit.rodata$", ".cpuinit.rodata$", ".meminit.rodata$", \
 	".init.data$", ".devinit.data$", ".cpuinit.data$", ".meminit.data$"
 #define ALL_EXIT_DATA_SECTIONS \
 	".exit.data$", ".devexit.data$", ".cpuexit.data$", ".memexit.data$"




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] modpost: fix ALL_INIT_DATA_SECTIONS
  2012-03-08  9:41 [PATCH] modpost: fix ALL_INIT_DATA_SECTIONS Jan Beulich
@ 2012-03-26 20:41 ` Michal Marek
  2012-03-27  6:46   ` Jan Beulich
  0 siblings, 1 reply; 3+ messages in thread
From: Michal Marek @ 2012-03-26 20:41 UTC (permalink / raw)
  To: Jan Beulich; +Cc: rusty, linux-kbuild, linux-kernel

On Thu, Mar 08, 2012 at 09:41:25AM +0000, Jan Beulich wrote:
> This was lacking a comma between two supposed to be separate strings.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> ---
>  scripts/mod/modpost.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- 3.3-rc6/scripts/mod/modpost.c
> +++ 3.3-rc6-modpost-all-init-data/scripts/mod/modpost.c
> @@ -849,7 +849,7 @@ static void check_section(const char *mo
>  
>  #define ALL_INIT_DATA_SECTIONS \
>  	".init.setup$", ".init.rodata$", \
> -	".devinit.rodata$", ".cpuinit.rodata$", ".meminit.rodata$" \
> +	".devinit.rodata$", ".cpuinit.rodata$", ".meminit.rodata$", \

Applied to kbuild.git#kbuild with a Cc: stable. BTW, was it causing actual
false positives to be reported?

Thanks,
Michal

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] modpost: fix ALL_INIT_DATA_SECTIONS
  2012-03-26 20:41 ` Michal Marek
@ 2012-03-27  6:46   ` Jan Beulich
  0 siblings, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2012-03-27  6:46 UTC (permalink / raw)
  To: Michal Marek; +Cc: rusty, linux-kbuild, linux-kernel

>>> On 26.03.12 at 22:41, Michal Marek <mmarek@suse.cz> wrote:
> On Thu, Mar 08, 2012 at 09:41:25AM +0000, Jan Beulich wrote:
>> This was lacking a comma between two supposed to be separate strings.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> 
>> ---
>>  scripts/mod/modpost.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> --- 3.3-rc6/scripts/mod/modpost.c
>> +++ 3.3-rc6-modpost-all-init-data/scripts/mod/modpost.c
>> @@ -849,7 +849,7 @@ static void check_section(const char *mo
>>  
>>  #define ALL_INIT_DATA_SECTIONS \
>>  	".init.setup$", ".init.rodata$", \
>> -	".devinit.rodata$", ".cpuinit.rodata$", ".meminit.rodata$" \
>> +	".devinit.rodata$", ".cpuinit.rodata$", ".meminit.rodata$", \
> 
> Applied to kbuild.git#kbuild with a Cc: stable. BTW, was it causing actual
> false positives to be reported?

No, I just noticed this in the context of a bigger (PCI related) patch
that so far I didn't get any reaction on from you (intending to resend
at some point).

Jan


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-03-27  6:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-08  9:41 [PATCH] modpost: fix ALL_INIT_DATA_SECTIONS Jan Beulich
2012-03-26 20:41 ` Michal Marek
2012-03-27  6:46   ` Jan Beulich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®