mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] regmap: Rejig struct declarations for stubbed API
@ 2012-03-11 11:56 Mark Brown
  2012-03-11 15:52 ` Randy Dunlap
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2012-03-11 11:56 UTC (permalink / raw)
  To: linux-kernel; +Cc: patches, Mark Brown

Ensure we have a forward declaration of struct regmap that isn't just
the return value of regmap_init() and make the definition of the
register defaults available.

Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 include/linux/regmap.h |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/linux/regmap.h b/include/linux/regmap.h
index 33d5f1d..14b8252 100644
--- a/include/linux/regmap.h
+++ b/include/linux/regmap.h
@@ -16,11 +16,10 @@
 #include <linux/device.h>
 #include <linux/list.h>
 
-#ifdef CONFIG_REGMAP
-
 struct module;
 struct i2c_client;
 struct spi_device;
+struct regmap;
 
 /* An enum of all the supported cache types */
 enum regcache_type {
@@ -42,6 +41,8 @@ struct reg_default {
 	unsigned int def;
 };
 
+#ifdef CONFIG_REGMAP
+
 /**
  * Configuration for the register map of a device.
  *
-- 
1.7.9.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] regmap: Rejig struct declarations for stubbed API
  2012-03-11 11:56 [PATCH] regmap: Rejig struct declarations for stubbed API Mark Brown
@ 2012-03-11 15:52 ` Randy Dunlap
  0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2012-03-11 15:52 UTC (permalink / raw)
  To: Mark Brown; +Cc: linux-kernel, patches

On 03/11/2012 04:56 AM, Mark Brown wrote:

> Ensure we have a forward declaration of struct regmap that isn't just
> the return value of regmap_init() and make the definition of the
> register defaults available.
> 
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>


Acked-by: Randy Dunlap <rdunlap@xenotime.net>

Thanks.

> ---
>  include/linux/regmap.h |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/regmap.h b/include/linux/regmap.h
> index 33d5f1d..14b8252 100644
> --- a/include/linux/regmap.h
> +++ b/include/linux/regmap.h
> @@ -16,11 +16,10 @@
>  #include <linux/device.h>
>  #include <linux/list.h>
>  
> -#ifdef CONFIG_REGMAP
> -
>  struct module;
>  struct i2c_client;
>  struct spi_device;
> +struct regmap;
>  
>  /* An enum of all the supported cache types */
>  enum regcache_type {
> @@ -42,6 +41,8 @@ struct reg_default {
>  	unsigned int def;
>  };
>  
> +#ifdef CONFIG_REGMAP
> +
>  /**
>   * Configuration for the register map of a device.
>   *



-- 
~Randy

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-03-11 15:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-11 11:56 [PATCH] regmap: Rejig struct declarations for stubbed API Mark Brown
2012-03-11 15:52 ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome