* Re: [PATCH] ARM: v3.4-rc1 amba-pl011 regression (NULL pointer dereference)
[not found] <4F84E4F7.3020107@am.sony.com>
@ 2012-04-11 2:14 ` Frank Rowand
0 siblings, 0 replies; only message in thread
From: Frank Rowand @ 2012-04-11 2:14 UTC (permalink / raw)
To: linux-kernel
Cc: Linus Torvalds, Linus Walleij, Shreshtha Kumar Sahu, Chanho Min,
Russell King, Jong-Sung Kim, stable, Greg Kroah-Hartman
linux-kernel was left off the original message, resending.
commit 9b96fbac introduced use of pointer before it is initialized,
resulting in a NULL pointer dereference on boot for the ARM Realview.
uap->port.membase is initialized to base a few lines later, so just
use base.
Signed-off-by: Frank Rowand <frank.rowand@am.sony.com>
---
drivers/tty/serial/amba-pl011.c | 4 2 + 2 - 0 !
1 file changed, 2 insertions(+), 2 deletions(-)
Index: b/drivers/tty/serial/amba-pl011.c
===================================================================
--- a/drivers/tty/serial/amba-pl011.c
+++ b/drivers/tty/serial/amba-pl011.c
@@ -1947,8 +1947,8 @@ static int pl011_probe(struct amba_devic
}
/* Ensure interrupts from this UART are masked and cleared */
- writew(0, uap->port.membase + UART011_IMSC);
- writew(0xffff, uap->port.membase + UART011_ICR);
+ writew(0, base + UART011_IMSC);
+ writew(0xffff, base + UART011_ICR);
uap->vendor = vendor;
uap->lcrh_rx = vendor->lcrh_rx;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-04-11 2:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <4F84E4F7.3020107@am.sony.com>
2012-04-11 2:14 ` [PATCH] ARM: v3.4-rc1 amba-pl011 regression (NULL pointer dereference) Frank Rowand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome