mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
	mingo@elte.hu, acme@redhat.com
Subject: Re: [PATCH v2 5/5] perf: make perf buildid-list work better with pipe mode
Date: Tue, 15 May 2012 21:55:36 -0600	[thread overview]
Message-ID: <4FB32538.1070004@gmail.com> (raw)
In-Reply-To: <1337081295-10303-6-git-send-email-eranian@google.com>

On 5/15/12 5:28 AM, Stephane Eranian wrote:
> In order for perf buildid-list to work with pipe-mode files,
> it needs to process buildids and event attr structs.
>
> $ perf record -o - noploop 2 | ./perf inject -b | perf buildid-list -i - -H
> noploop for 2 seconds
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.084 MB - (~3678 samples) ]
> 0000000000000000000000000000000000000000 [kernel.kallsyms]
> 3a0d0629efe74a8da3eeba372cdbd74ad9b8f5d5 /usr/local/bin/noploop
>
> The reason [kernel.kallsyms] shows a 0 build-id comes from the
> way buildids are injected in the stream. The buildid for the kernel
> is provided by a BUILD_ID record. The [kernel.kallsyms] is provided
> by a MMAP record. There is no clean and obvious way to link the two,
> unfortunately. In regular mode, the kernel buildid is generated from
> reading the ELF image or kallsyms and perf knows to associate
> [kernel.kallsyms] to it. Later on, when perf processes the
> [kernel.kallsyms] MMAP record, it will already have a dso for it.
>
> So for now, make sure perf buildid-list shows the buildids for
> everything but the kernel image.
>
> Signed-off-by: Stephane Eranian<eranian@google.com>
> ---
>   tools/perf/builtin-buildid-list.c |    6 +++++-
>   tools/perf/util/build-id.c        |    2 ++
>   2 files changed, 7 insertions(+), 1 deletions(-)

Reviewed-and-tested-by: David Ahern <dsahern@gmail.com>

  reply	other threads:[~2012-05-16  3:55 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-15 11:28 [PATCH v2 0/5] perf tools: add meta-data header support in " Stephane Eranian
2012-05-15 11:28 ` [PATCH v2 1/5] perf inject: fix broken perf inject -b Stephane Eranian
2012-05-16  1:58   ` David Ahern
2012-05-23 15:29   ` [tip:perf/core] perf inject: Fix " tip-bot for Stephane Eranian
2012-05-15 11:28 ` [PATCH v2 2/5] perf tools: fix piped mode read code Stephane Eranian
2012-05-16  2:24   ` David Ahern
2012-05-23 15:29   ` [tip:perf/core] perf tools: Fix " tip-bot for Stephane Eranian
2012-05-15 11:28 ` [PATCH v2 3/5] perf tools: rename HEADER_TRACE_INFO to HEADER_TRACING_DATA Stephane Eranian
2012-05-16  2:34   ` David Ahern
2012-05-23 15:28   ` [tip:perf/core] " tip-bot for Stephane Eranian
2012-05-15 11:28 ` [PATCH v2 4/5] perf record: add meta-data support for pipe-mode Stephane Eranian
2012-05-16  3:34   ` David Ahern
2012-05-16  7:41     ` Stephane Eranian
2012-05-18 16:50       ` David Ahern
2012-05-18 17:19         ` Arnaldo Carvalho de Melo
2012-05-22 17:33           ` Peter Zijlstra
2012-05-22 17:51             ` Stephane Eranian
2012-05-23  0:45               ` Namhyung Kim
2012-05-23  1:01                 ` Arnaldo Carvalho de Melo
2012-05-23  8:10                   ` Peter Zijlstra
2012-05-23  8:21               ` Peter Zijlstra
2012-05-23 13:06                 ` Stephane Eranian
2012-05-24 15:36               ` David Ahern
2012-05-24 16:19                 ` Arnaldo Carvalho de Melo
2012-05-24 16:22                   ` David Ahern
2012-05-24 16:44                     ` Arnaldo Carvalho de Melo
2012-05-15 11:28 ` [PATCH v2 5/5] perf: make perf buildid-list work better with pipe mode Stephane Eranian
2012-05-16  3:55   ` David Ahern [this message]
2012-05-23 15:30   ` [tip:perf/core] perf buildid-list: Work " tip-bot for Stephane Eranian
2012-05-16  1:34 ` [PATCH v2 0/5] perf tools: add meta-data header support in " Namhyung Kim
2012-05-16  2:05   ` David Ahern
2012-05-16  2:32     ` Namhyung Kim
2012-05-16  2:38       ` David Ahern
2012-05-16  2:50         ` Namhyung Kim
2012-05-16 15:03         ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB32538.1070004@gmail.com \
    --to=dsahern@gmail.com \
    --cc=acme@redhat.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome