From: David Ahern <dsahern@gmail.com>
To: Stephane Eranian <eranian@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [PATCH v2 4/5] perf record: add meta-data support for pipe-mode
Date: Thu, 24 May 2012 09:36:35 -0600 [thread overview]
Message-ID: <4FBE5583.8070405@gmail.com> (raw)
In-Reply-To: <CABPqkBTQ=K-=qkgzC0TZPi1xyHtqT6QQroRg-7o0k8rFmjH_Bw@mail.gmail.com>
On 5/22/12 11:51 AM, Stephane Eranian wrote:
> The problem is that the headers as they are written to the file need
> seeking in the file to update the offset table. That is NOT possible when
> you operate in pipe mode. As such you need to inject the header infos
> very much like kernel PERF_RECORD_*. That is also why you have
> perf inject -b. Buildids are added at the end of the run in file mode,
> and that's another seek to the offset table if I recall correctly.
Perhaps I am being too simple minded here, but why not dump the features
to the pipe as a series of structs when the perf session is created?
struct pipe_data {
u32 length;
u32 type;
char data[0];
}
It would require the features to be written to a buffer first to get the
length, but that's manageable without too much code change. Endianness
would need to be handled -- maybe a u8 flags at the beginning.
David
next prev parent reply other threads:[~2012-05-24 15:36 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 11:28 [PATCH v2 0/5] perf tools: add meta-data header support in pipe mode Stephane Eranian
2012-05-15 11:28 ` [PATCH v2 1/5] perf inject: fix broken perf inject -b Stephane Eranian
2012-05-16 1:58 ` David Ahern
2012-05-23 15:29 ` [tip:perf/core] perf inject: Fix " tip-bot for Stephane Eranian
2012-05-15 11:28 ` [PATCH v2 2/5] perf tools: fix piped mode read code Stephane Eranian
2012-05-16 2:24 ` David Ahern
2012-05-23 15:29 ` [tip:perf/core] perf tools: Fix " tip-bot for Stephane Eranian
2012-05-15 11:28 ` [PATCH v2 3/5] perf tools: rename HEADER_TRACE_INFO to HEADER_TRACING_DATA Stephane Eranian
2012-05-16 2:34 ` David Ahern
2012-05-23 15:28 ` [tip:perf/core] " tip-bot for Stephane Eranian
2012-05-15 11:28 ` [PATCH v2 4/5] perf record: add meta-data support for pipe-mode Stephane Eranian
2012-05-16 3:34 ` David Ahern
2012-05-16 7:41 ` Stephane Eranian
2012-05-18 16:50 ` David Ahern
2012-05-18 17:19 ` Arnaldo Carvalho de Melo
2012-05-22 17:33 ` Peter Zijlstra
2012-05-22 17:51 ` Stephane Eranian
2012-05-23 0:45 ` Namhyung Kim
2012-05-23 1:01 ` Arnaldo Carvalho de Melo
2012-05-23 8:10 ` Peter Zijlstra
2012-05-23 8:21 ` Peter Zijlstra
2012-05-23 13:06 ` Stephane Eranian
2012-05-24 15:36 ` David Ahern [this message]
2012-05-24 16:19 ` Arnaldo Carvalho de Melo
2012-05-24 16:22 ` David Ahern
2012-05-24 16:44 ` Arnaldo Carvalho de Melo
2012-05-15 11:28 ` [PATCH v2 5/5] perf: make perf buildid-list work better with pipe mode Stephane Eranian
2012-05-16 3:55 ` David Ahern
2012-05-23 15:30 ` [tip:perf/core] perf buildid-list: Work " tip-bot for Stephane Eranian
2012-05-16 1:34 ` [PATCH v2 0/5] perf tools: add meta-data header support in " Namhyung Kim
2012-05-16 2:05 ` David Ahern
2012-05-16 2:32 ` Namhyung Kim
2012-05-16 2:38 ` David Ahern
2012-05-16 2:50 ` Namhyung Kim
2012-05-16 15:03 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBE5583.8070405@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome