From: Mikko Perttunen <cyndis@kapsi.fi>
To: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>,
Thierry Reding <thierry.reding@gmail.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Jonathan Hunter <jonathanh@nvidia.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-tegra@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: tegra: Add NVJPG node
Date: Tue, 10 Jun 2025 14:01:01 +0900 [thread overview]
Message-ID: <4a02f671-2be0-45c9-b471-071596b22338@kapsi.fi> (raw)
In-Reply-To: <20250606-diogo-nvjpg-v1-3-5f2c36feeb39@tecnico.ulisboa.pt>
On 6/6/25 7:45 PM, Diogo Ivo wrote:
> The Tegra X1 chip contains a NVJPG accelerator capable of
> encoding/decoding JPEG files in hardware, so add its DT node.
>
> Signed-off-by: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
> ---
> arch/arm64/boot/dts/nvidia/tegra210.dtsi | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> index 6f8cdf012f0f12a16716e9d479c46b330bbb7dda..087f38256fd40f57c4685e907f9682eb49ee31db 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> @@ -253,7 +253,13 @@ vic@54340000 {
> nvjpg@54380000 {
> compatible = "nvidia,tegra210-nvjpg";
> reg = <0x0 0x54380000 0x0 0x00040000>;
> - status = "disabled";
> + clocks = <&tegra_car TEGRA210_CLK_NVJPG>;
> + clock-names = "nvjpg";
> + resets = <&tegra_car 195>;
> + reset-names = "nvjpg";
> +
> + iommus = <&mc TEGRA_SWGROUP_NVJPG>;
> + power-domains = <&pd_nvjpg>;
> };
>
> dsib: dsi@54400000 {
>
Please mention Tegra210 in the commit subject, and perhaps adjust the
commit message to say that you're updating and enabling the device tree
node (rather than adding, since it's already there).
With that,
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
next prev parent reply other threads:[~2025-06-10 5:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 10:45 [PATCH 0/3] NVIDIA Tegra210 NVJPG support Diogo Ivo
2025-06-06 10:45 ` [PATCH 1/3] drm/tegra: Add NVJPG driver Diogo Ivo
2025-06-10 3:26 ` Mikko Perttunen
2025-06-10 8:44 ` Thierry Reding
2025-06-11 11:50 ` Diogo Ivo
2025-06-11 11:47 ` Diogo Ivo
2025-06-06 10:45 ` [PATCH 2/3] arm64: tegra: Add NVJPG power-domain node Diogo Ivo
2025-06-10 4:57 ` Mikko Perttunen
2025-06-11 11:51 ` Diogo Ivo
2025-06-06 10:45 ` [PATCH 3/3] arm64: tegra: Add NVJPG node Diogo Ivo
2025-06-10 5:01 ` Mikko Perttunen [this message]
2025-06-11 11:51 ` Diogo Ivo
2025-06-10 8:58 ` [PATCH 0/3] NVIDIA Tegra210 NVJPG support Thierry Reding
2025-06-11 11:56 ` Diogo Ivo
2025-06-10 9:05 ` Thierry Reding
2025-06-10 9:52 ` Mikko Perttunen
2025-06-11 12:05 ` Diogo Ivo
2025-06-11 15:06 ` Thierry Reding
2025-06-12 1:55 ` Mikko Perttunen
2025-06-16 10:23 ` Diogo Ivo
2025-06-17 4:34 ` Mikko Perttunen
2025-06-16 10:21 ` Diogo Ivo
2025-06-17 4:40 ` Mikko Perttunen
2025-06-17 9:26 ` Diogo Ivo
2025-06-30 6:14 ` Mikko Perttunen
2025-06-30 8:52 ` Diogo Ivo
2025-06-11 12:04 ` Diogo Ivo
2025-06-11 15:10 ` Thierry Reding
2025-06-16 10:26 ` Diogo Ivo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a02f671-2be0-45c9-b471-071596b22338@kapsi.fi \
--to=cyndis@kapsi.fi \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=diogo.ivo@tecnico.ulisboa.pt \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®