* [PATCH] drm/nouveau/flcn/qmgr: Move assignment outside if condition
[not found] <20230711034221.79302-1-xujianghui@cdjrlc.com>
@ 2023-07-11 3:43 ` sunran001
0 siblings, 0 replies; only message in thread
From: sunran001 @ 2023-07-11 3:43 UTC (permalink / raw)
To: airlied, daniel; +Cc: dri-devel, nouveau, linux-kernel
Fixes the following checkpatch errors:
ERROR: do not use assignment in if condition
Signed-off-by: Ran Sun <sunran001@208suo.com>
---
drivers/gpu/drm/nouveau/nvkm/falcon/qmgr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/falcon/qmgr.c
b/drivers/gpu/drm/nouveau/nvkm/falcon/qmgr.c
index a453de341a75..48abdb124326 100644
--- a/drivers/gpu/drm/nouveau/nvkm/falcon/qmgr.c
+++ b/drivers/gpu/drm/nouveau/nvkm/falcon/qmgr.c
@@ -73,7 +73,8 @@ nvkm_falcon_qmgr_new(struct nvkm_falcon *falcon,
struct nvkm_falcon_qmgr *qmgr;
int i;
- if (!(qmgr = *pqmgr = kzalloc(sizeof(*qmgr), GFP_KERNEL)))
+ qmgr = *pqmgr = kzalloc(sizeof(*qmgr), GFP_KERNEL);
+ if (!qmgr)
return -ENOMEM;
qmgr->falcon = falcon;
^ permalink raw reply [flat|nested] only message in thread