[PATCH] drm/radeon: add late_register for connector

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

* [PATCH] drm/radeon: add late_register for connector
@ 2024-10-03  6:06 Wu Hoi Pok
  2024-10-03 15:54 ` Alex Deucher
       [not found] ` <d2704a2b-ceb2-4919-81d3-f6ff58a734fe@xenosoft.de>
  0 siblings, 2 replies; 9+ messages in thread
From: Wu Hoi Pok @ 2024-10-03  6:06 UTC (permalink / raw)
  Cc: Hoi Pok Wu, Christophe Leroy, Christian Zigotzky, Alex Deucher,
	Christian König, Xinhui Pan, David Airlie, Simona Vetter,
	open list:RADEON and AMDGPU DRM DRIVERS, open list:DRM DRIVERS,
	open list

This is a fix patch not tested yet,
for a bug I introduce in previous rework of radeon driver.
The bug is a null dereference in 'aux.dev', which is the
'device' not registered, resulting in kernel panic. By having
'late_register', the connector should be registered after
'drm_dev_register' automatically.

Please help testing thank you.

Signed-off-by: Wu Hoi Pok <wuhoipok@gmail.com>
---
 drivers/gpu/drm/radeon/atombios_dp.c       |  9 ++-------
 drivers/gpu/drm/radeon/radeon_connectors.c | 17 +++++++++++++++++
 2 files changed, 19 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/radeon/atombios_dp.c b/drivers/gpu/drm/radeon/atombios_dp.c
index fca8b08535a5..6328627b7c34 100644
--- a/drivers/gpu/drm/radeon/atombios_dp.c
+++ b/drivers/gpu/drm/radeon/atombios_dp.c
@@ -228,10 +228,8 @@ void radeon_dp_aux_init(struct radeon_connector *radeon_connector)
 {
 	struct drm_device *dev = radeon_connector->base.dev;
 	struct radeon_device *rdev = dev->dev_private;
-	int ret;
 
 	radeon_connector->ddc_bus->rec.hpd = radeon_connector->hpd.hpd;
-	radeon_connector->ddc_bus->aux.dev = radeon_connector->base.kdev;
 	radeon_connector->ddc_bus->aux.drm_dev = radeon_connector->base.dev;
 	if (ASIC_IS_DCE5(rdev)) {
 		if (radeon_auxch)
@@ -242,11 +240,8 @@ void radeon_dp_aux_init(struct radeon_connector *radeon_connector)
 		radeon_connector->ddc_bus->aux.transfer = radeon_dp_aux_transfer_atom;
 	}
 
-	ret = drm_dp_aux_register(&radeon_connector->ddc_bus->aux);
-	if (!ret)
-		radeon_connector->ddc_bus->has_aux = true;
-
-	WARN(ret, "drm_dp_aux_register() failed with error %d\n", ret);
+	drm_dp_aux_init(&radeon_connector->ddc_bus->aux);
+	radeon_connector->ddc_bus->has_aux = true;
 }
 
 /***** general DP utility functions *****/
diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c
index 528a8f3677c2..f9c73c55f04f 100644
--- a/drivers/gpu/drm/radeon/radeon_connectors.c
+++ b/drivers/gpu/drm/radeon/radeon_connectors.c
@@ -1786,6 +1786,20 @@ static enum drm_mode_status radeon_dp_mode_valid(struct drm_connector *connector
 	return MODE_OK;
 }
 
+static int
+radeon_connector_late_register(struct drm_connector *connector)
+{
+	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
+	int r = 0;
+
+	if (radeon_connector->ddc_bus->has_aux) {
+		radeon_connector->ddc_bus->aux.dev = radeon_connector->base.kdev;
+		r = drm_dp_aux_register(&radeon_connector->ddc_bus->aux);
+	}
+
+	return r;
+}
+
 static const struct drm_connector_helper_funcs radeon_dp_connector_helper_funcs = {
 	.get_modes = radeon_dp_get_modes,
 	.mode_valid = radeon_dp_mode_valid,
@@ -1800,6 +1814,7 @@ static const struct drm_connector_funcs radeon_dp_connector_funcs = {
 	.early_unregister = radeon_connector_unregister,
 	.destroy = radeon_connector_destroy,
 	.force = radeon_dvi_force,
+	.late_register = radeon_connector_late_register,
 };
 
 static const struct drm_connector_funcs radeon_edp_connector_funcs = {
@@ -1810,6 +1825,7 @@ static const struct drm_connector_funcs radeon_edp_connector_funcs = {
 	.early_unregister = radeon_connector_unregister,
 	.destroy = radeon_connector_destroy,
 	.force = radeon_dvi_force,
+	.late_register = radeon_connector_late_register,
 };
 
 static const struct drm_connector_funcs radeon_lvds_bridge_connector_funcs = {
@@ -1820,6 +1836,7 @@ static const struct drm_connector_funcs radeon_lvds_bridge_connector_funcs = {
 	.early_unregister = radeon_connector_unregister,
 	.destroy = radeon_connector_destroy,
 	.force = radeon_dvi_force,
+	.late_register = radeon_connector_late_register,
 };
 
 void
-- 
2.46.2


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/radeon: add late_register for connector
  2024-10-03  6:06 [PATCH] drm/radeon: add late_register for connector Wu Hoi Pok
@ 2024-10-03 15:54 ` Alex Deucher
  2024-10-03 17:48   ` Hans de Goede
       [not found] ` <d2704a2b-ceb2-4919-81d3-f6ff58a734fe@xenosoft.de>
  1 sibling, 1 reply; 9+ messages in thread
From: Alex Deucher @ 2024-10-03 15:54 UTC (permalink / raw)
  To: Wu Hoi Pok, Hans de Goede
  Cc: Christophe Leroy, Christian Zigotzky, Alex Deucher,
	Christian König, Xinhui Pan, David Airlie, Simona Vetter,
	open list:RADEON and AMDGPU DRM DRIVERS, open list:DRM DRIVERS,
	open list

+ Hans

On Thu, Oct 3, 2024 at 2:33 AM Wu Hoi Pok <wuhoipok@gmail.com> wrote:
>
> This is a fix patch not tested yet,
> for a bug I introduce in previous rework of radeon driver.
> The bug is a null dereference in 'aux.dev', which is the
> 'device' not registered, resulting in kernel panic. By having
> 'late_register', the connector should be registered after
> 'drm_dev_register' automatically.
>
> Please help testing thank you.
>
> Signed-off-by: Wu Hoi Pok <wuhoipok@gmail.com>
> ---
>  drivers/gpu/drm/radeon/atombios_dp.c       |  9 ++-------
>  drivers/gpu/drm/radeon/radeon_connectors.c | 17 +++++++++++++++++
>  2 files changed, 19 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/atombios_dp.c b/drivers/gpu/drm/radeon/atombios_dp.c
> index fca8b08535a5..6328627b7c34 100644
> --- a/drivers/gpu/drm/radeon/atombios_dp.c
> +++ b/drivers/gpu/drm/radeon/atombios_dp.c
> @@ -228,10 +228,8 @@ void radeon_dp_aux_init(struct radeon_connector *radeon_connector)
>  {
>         struct drm_device *dev = radeon_connector->base.dev;
>         struct radeon_device *rdev = dev->dev_private;
> -       int ret;
>
>         radeon_connector->ddc_bus->rec.hpd = radeon_connector->hpd.hpd;
> -       radeon_connector->ddc_bus->aux.dev = radeon_connector->base.kdev;
>         radeon_connector->ddc_bus->aux.drm_dev = radeon_connector->base.dev;
>         if (ASIC_IS_DCE5(rdev)) {
>                 if (radeon_auxch)
> @@ -242,11 +240,8 @@ void radeon_dp_aux_init(struct radeon_connector *radeon_connector)
>                 radeon_connector->ddc_bus->aux.transfer = radeon_dp_aux_transfer_atom;
>         }
>
> -       ret = drm_dp_aux_register(&radeon_connector->ddc_bus->aux);
> -       if (!ret)
> -               radeon_connector->ddc_bus->has_aux = true;
> -
> -       WARN(ret, "drm_dp_aux_register() failed with error %d\n", ret);
> +       drm_dp_aux_init(&radeon_connector->ddc_bus->aux);
> +       radeon_connector->ddc_bus->has_aux = true;
>  }
>
>  /***** general DP utility functions *****/
> diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c
> index 528a8f3677c2..f9c73c55f04f 100644
> --- a/drivers/gpu/drm/radeon/radeon_connectors.c
> +++ b/drivers/gpu/drm/radeon/radeon_connectors.c
> @@ -1786,6 +1786,20 @@ static enum drm_mode_status radeon_dp_mode_valid(struct drm_connector *connector
>         return MODE_OK;
>  }
>
> +static int
> +radeon_connector_late_register(struct drm_connector *connector)
> +{
> +       struct radeon_connector *radeon_connector = to_radeon_connector(connector);
> +       int r = 0;
> +
> +       if (radeon_connector->ddc_bus->has_aux) {
> +               radeon_connector->ddc_bus->aux.dev = radeon_connector->base.kdev;
> +               r = drm_dp_aux_register(&radeon_connector->ddc_bus->aux);
> +       }
> +
> +       return r;
> +}
> +
>  static const struct drm_connector_helper_funcs radeon_dp_connector_helper_funcs = {
>         .get_modes = radeon_dp_get_modes,
>         .mode_valid = radeon_dp_mode_valid,
> @@ -1800,6 +1814,7 @@ static const struct drm_connector_funcs radeon_dp_connector_funcs = {
>         .early_unregister = radeon_connector_unregister,
>         .destroy = radeon_connector_destroy,
>         .force = radeon_dvi_force,
> +       .late_register = radeon_connector_late_register,
>  };
>
>  static const struct drm_connector_funcs radeon_edp_connector_funcs = {
> @@ -1810,6 +1825,7 @@ static const struct drm_connector_funcs radeon_edp_connector_funcs = {
>         .early_unregister = radeon_connector_unregister,
>         .destroy = radeon_connector_destroy,
>         .force = radeon_dvi_force,
> +       .late_register = radeon_connector_late_register,
>  };
>
>  static const struct drm_connector_funcs radeon_lvds_bridge_connector_funcs = {
> @@ -1820,6 +1836,7 @@ static const struct drm_connector_funcs radeon_lvds_bridge_connector_funcs = {
>         .early_unregister = radeon_connector_unregister,
>         .destroy = radeon_connector_destroy,
>         .force = radeon_dvi_force,
> +       .late_register = radeon_connector_late_register,
>  };
>
>  void
> --
> 2.46.2
>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/radeon: add late_register for connector
  2024-10-03 15:54 ` Alex Deucher
@ 2024-10-03 17:48   ` Hans de Goede
  0 siblings, 0 replies; 9+ messages in thread
From: Hans de Goede @ 2024-10-03 17:48 UTC (permalink / raw)
  To: Alex Deucher, Wu Hoi Pok
  Cc: Christophe Leroy, Christian Zigotzky, Alex Deucher,
	Christian König, Xinhui Pan, David Airlie, Simona Vetter,
	open list:RADEON and AMDGPU DRM DRIVERS, open list:DRM DRIVERS,
	open list

Hi,

On 3-Oct-24 5:54 PM, Alex Deucher wrote:
> + Hans
> 
> On Thu, Oct 3, 2024 at 2:33 AM Wu Hoi Pok <wuhoipok@gmail.com> wrote:
>>
>> This is a fix patch not tested yet,
>> for a bug I introduce in previous rework of radeon driver.
>> The bug is a null dereference in 'aux.dev', which is the
>> 'device' not registered, resulting in kernel panic. By having
>> 'late_register', the connector should be registered after
>> 'drm_dev_register' automatically.
>>
>> Please help testing thank you.
>>
>> Signed-off-by: Wu Hoi Pok <wuhoipok@gmail.com>

Thank you both for the Cc and the patch. I can confirm that this
fixes the crash which I was seeing. Also IHMO this should have
a fixes tag for the original commit introducing the problem:

Fixes: 90985660ba48 ("drm/radeon: remove load callback from kms_driver")
Tested-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans





>> ---
>>  drivers/gpu/drm/radeon/atombios_dp.c       |  9 ++-------
>>  drivers/gpu/drm/radeon/radeon_connectors.c | 17 +++++++++++++++++
>>  2 files changed, 19 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/atombios_dp.c b/drivers/gpu/drm/radeon/atombios_dp.c
>> index fca8b08535a5..6328627b7c34 100644
>> --- a/drivers/gpu/drm/radeon/atombios_dp.c
>> +++ b/drivers/gpu/drm/radeon/atombios_dp.c
>> @@ -228,10 +228,8 @@ void radeon_dp_aux_init(struct radeon_connector *radeon_connector)
>>  {
>>         struct drm_device *dev = radeon_connector->base.dev;
>>         struct radeon_device *rdev = dev->dev_private;
>> -       int ret;
>>
>>         radeon_connector->ddc_bus->rec.hpd = radeon_connector->hpd.hpd;
>> -       radeon_connector->ddc_bus->aux.dev = radeon_connector->base.kdev;
>>         radeon_connector->ddc_bus->aux.drm_dev = radeon_connector->base.dev;
>>         if (ASIC_IS_DCE5(rdev)) {
>>                 if (radeon_auxch)
>> @@ -242,11 +240,8 @@ void radeon_dp_aux_init(struct radeon_connector *radeon_connector)
>>                 radeon_connector->ddc_bus->aux.transfer = radeon_dp_aux_transfer_atom;
>>         }
>>
>> -       ret = drm_dp_aux_register(&radeon_connector->ddc_bus->aux);
>> -       if (!ret)
>> -               radeon_connector->ddc_bus->has_aux = true;
>> -
>> -       WARN(ret, "drm_dp_aux_register() failed with error %d\n", ret);
>> +       drm_dp_aux_init(&radeon_connector->ddc_bus->aux);
>> +       radeon_connector->ddc_bus->has_aux = true;
>>  }
>>
>>  /***** general DP utility functions *****/
>> diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c
>> index 528a8f3677c2..f9c73c55f04f 100644
>> --- a/drivers/gpu/drm/radeon/radeon_connectors.c
>> +++ b/drivers/gpu/drm/radeon/radeon_connectors.c
>> @@ -1786,6 +1786,20 @@ static enum drm_mode_status radeon_dp_mode_valid(struct drm_connector *connector
>>         return MODE_OK;
>>  }
>>
>> +static int
>> +radeon_connector_late_register(struct drm_connector *connector)
>> +{
>> +       struct radeon_connector *radeon_connector = to_radeon_connector(connector);
>> +       int r = 0;
>> +
>> +       if (radeon_connector->ddc_bus->has_aux) {
>> +               radeon_connector->ddc_bus->aux.dev = radeon_connector->base.kdev;
>> +               r = drm_dp_aux_register(&radeon_connector->ddc_bus->aux);
>> +       }
>> +
>> +       return r;
>> +}
>> +
>>  static const struct drm_connector_helper_funcs radeon_dp_connector_helper_funcs = {
>>         .get_modes = radeon_dp_get_modes,
>>         .mode_valid = radeon_dp_mode_valid,
>> @@ -1800,6 +1814,7 @@ static const struct drm_connector_funcs radeon_dp_connector_funcs = {
>>         .early_unregister = radeon_connector_unregister,
>>         .destroy = radeon_connector_destroy,
>>         .force = radeon_dvi_force,
>> +       .late_register = radeon_connector_late_register,
>>  };
>>
>>  static const struct drm_connector_funcs radeon_edp_connector_funcs = {
>> @@ -1810,6 +1825,7 @@ static const struct drm_connector_funcs radeon_edp_connector_funcs = {
>>         .early_unregister = radeon_connector_unregister,
>>         .destroy = radeon_connector_destroy,
>>         .force = radeon_dvi_force,
>> +       .late_register = radeon_connector_late_register,
>>  };
>>
>>  static const struct drm_connector_funcs radeon_lvds_bridge_connector_funcs = {
>> @@ -1820,6 +1836,7 @@ static const struct drm_connector_funcs radeon_lvds_bridge_connector_funcs = {
>>         .early_unregister = radeon_connector_unregister,
>>         .destroy = radeon_connector_destroy,
>>         .force = radeon_dvi_force,
>> +       .late_register = radeon_connector_late_register,
>>  };
>>
>>  void
>> --
>> 2.46.2
>>
> 


^ permalink raw reply	[flat|nested] 9+ messages in thread

[parent not found: <d2704a2b-ceb2-4919-81d3-f6ff58a734fe@xenosoft.de>]

* Re: [PATCH] drm/radeon: add late_register for connector
       [not found] ` <d2704a2b-ceb2-4919-81d3-f6ff58a734fe@xenosoft.de>
@ 2024-10-06 17:37   ` Christophe Leroy
  2024-10-06 18:01     ` Christian Zigotzky
                       ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Christophe Leroy @ 2024-10-06 17:37 UTC (permalink / raw)
  To: Christian Zigotzky, Wu Hoi Pok
  Cc: Alex Deucher, Christian König, Xinhui Pan, David Airlie,
	Simona Vetter, open list:RADEON and AMDGPU DRM DRIVERS,
	open list:DRM DRIVERS, open list, linuxppc-dev, R.T.Dickinson,
	mad skateman, hypexed, Christian Zigotzky, Darren Stevens



Le 06/10/2024 à 18:56, Christian Zigotzky a écrit :
> On 03 October 2024 at 08:06 am, Wu Hoi Pok wrote:
>> This is a fix patch not tested yet,
>> for a bug I introduce in previous rework of radeon driver.
>> The bug is a null dereference in 'aux.dev', which is the
>> 'device' not registered, resulting in kernel panic. By having
>> 'late_register', the connector should be registered after
>> 'drm_dev_register' automatically.
>>
>> Please help testing thank you.
> Hello Wu Hoi Pok,
> 
> Thanks a lot for your patch. Unfortunately there is a new issue after 
> patching the RC1. Could you please fix the following issue?
> 
> Thanks,
> Christian
> 
> ---
> 
> Linux fienix 6.12.0-rc1-2-powerpc64-smp #1 SMP Fri Oct  4 08:55:45 CEST 
> 2024 ppc64 GNU/Linux
> 
> [   29.167145] systemd[1]: Sent message type=signal sender=n/a 
> destination=n/a 
> path=/org/freedesktop/systemd1/unit/NetworkManager_2eservice 
> interface=org.freedesktop.DBus.Properties member=PropertiesChanged 
> cookie=103 reply_cookie=0 signature=sa{sv}as error-name=n/a 
> error-message=n/a
> [   29.542140] systemd-journald[1301]: Successfully sent stream file 
> descriptor to service manager.
> [   29.561863] BUG: Kernel NULL pointer dereference on read at 0x00000000
> [   29.567156] Faulting instruction address: 0xc000000000c973c0
> [   29.571574] cpu 0x1: Vector: 300 (Data Access) at [c000000006f97640]
> [   29.576637]     pc: c000000000c973c0: .drm_gem_object_free+0x20/0x70
> [   29.581708]     lr: c000000000d28dd8: .radeon_bo_unref+0x58/0x90
> [   29.586428]     sp: c000000006f978e0
> [   29.588695]    msr: 9000000000009032
> [   29.590962]    dar: 0
> [   29.591925]  dsisr: 40000000
> [   29.593496]   current = 0xc0000000085b1f00
> [   29.596286]   paca    = 0xc00000003ffff680     irqmask: 0x03 
> irq_happened: 0x01
> [   29.602119]     pid   = 1524, comm = Xorg.wrap
> [   29.605257] Linux version 6.12.0-rc1-2-powerpc64-smp 
> (geeko@buildhost) (powerpc64-suse-linux-gcc (SUSE Linux) 7.5.0, GNU ld 
> (GNU Binutils; devel:gcc / SLE-15) 2.43.1.20240828-150300.536) #1 SMP 
> Fri Oct  4 08:55:45 CEST 2024
> [   29.623892] enter ? for help
> [   29.625487] [c000000006f97960] c000000000d28dd8 
> .radeon_bo_unref+0x58/0x90
> [   29.631083] [c000000006f979e0] c000000000e287b0 
> .radeon_vm_fini+0x260/0x330
> [   29.636765] [c000000006f97aa0] c000000000d07c94 
> .radeon_driver_postclose_kms+0x1a4/0x1f0
> [   29.643579] [c000000006f97b30] c000000000c9374c 
> .drm_file_free+0x28c/0x300
> [   29.649174] [c000000006f97be0] c000000000c93900 .drm_release+0x90/0x170
> [   29.654508] [c000000006f97c70] c000000000304790 .__fput+0x120/0x3b0
> [   29.659495] [c000000006f97d10] c0000000002fe0fc .__se_sys_close+0x4c/0xc0
> [   29.665004] [c000000006f97d90] c000000000025bac 
> .system_call_exception+0x22c/0x260
> [   29.671295] [c000000006f97e10] c00000000000b554 
> system_call_common+0xf4/0x258
> [   29.677164] --- Exception: c00 (System Call) at 00000000006b2b48
> [   29.681876] SP (fff4b3d0) is in userspace
> [   29.684577] 1:mon>  <no input ...>
> [   31.666727] Oops: Kernel access of bad area, sig: 11 [#1]
> [   31.670829] BE PAGE_SIZE=4K MMU=Hash SMP NR_CPUS=2 A-EON Amigaone X1000
> [   31.676144] Modules linked in: snd_hda_codec_idt 
> snd_hda_codec_generic snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg 
> snd_hda_codec snd_hda_core dm_mod
> [   31.688703] CPU: 1 UID: 0 PID: 1524 Comm: Xorg.wrap Not tainted 
> 6.12.0-rc1-2-powerpc64-smp #1
> [   31.695932] Hardware name: pasemi,nemo PA6T 0x900102 A-EON Amigaone X1000
> [   31.701417] NIP:  c000000000c973c0 LR: c000000000d28dd8 CTR: 
> c000000000d07af0
> [   31.707250] REGS: c000000006f97640 TRAP: 0300   Not tainted 
> (6.12.0-rc1-2-powerpc64-smp)
> [   31.714128] MSR:  9000000000009032 <SF,HV,EE,ME,IR,DR,RI> CR: 
> 28002222  XER: 20000000
> [   31.720773] DAR: 0000000000000000 DSISR: 40000000 IRQMASK: 0
>                 GPR00: c000000000d28dd8 c000000006f978e0 
> c00000000207a800 c0000000085f5468
>                 GPR04: 0000000000000b9b 0000000000000b9a 
> 0000000179779000 c0000000086a4b00
>                 GPR08: 0000000000000000 0000000000000000 
> 0000000000000001 0000000000000000
>                 GPR12: 0000000048002202 c00000003ffff680 
> 0000000000000000 0000000000000000
>                 GPR16: 00000000006e3318 0000000000000001 
> 00000000006e289c 0000000000000063
>                 GPR20: 00000000c04064a0 00000000007f0088 
> 00000000fff4c734 00000000007d165c
>                 GPR24: 00000000007d1668 c000000024b6a220 
> c000000003588000 c000000024b6a200
>                 GPR28: c000000003b3cc00 c000000024b6a248 
> c000000002d48820 c0000000085f5468
> [   31.778903] NIP [c000000000c973c0] .drm_gem_object_free+0x20/0x70
> [   31.783701] LR [c000000000d28dd8] .radeon_bo_unref+0x58/0x90
> [   31.788062] Call Trace:
> [   31.789199] [c000000006f978e0] [c000000006f97990] 0xc000000006f97990 
> (unreliable)
> [   31.795388] [c000000006f97960] [c000000000d28dd8] 
> .radeon_bo_unref+0x58/0x90
> [   31.801142] [c000000006f979e0] [c000000000e287b0] 
> .radeon_vm_fini+0x260/0x330
> [   31.806982] [c000000006f97aa0] [c000000000d07c94] 
> .radeon_driver_postclose_kms+0x1a4/0x1f0
> [   31.813954] [c000000006f97b30] [c000000000c9374c] 
> .drm_file_free+0x28c/0x300
> [   31.819707] [c000000006f97be0] [c000000000c93900] .drm_release+0x90/0x170
> [   31.825197] [c000000006f97c70] [c000000000304790] .__fput+0x120/0x3b0
> [   31.830342] [c000000006f97d10] [c0000000002fe0fc] 
> .__se_sys_close+0x4c/0xc0
> [   31.836010] [c000000006f97d90] [c000000000025bac] 
> .system_call_exception+0x22c/0x260
> [   31.842460] [c000000006f97e10] [c00000000000b554] 
> system_call_common+0xf4/0x258
> [   31.848476] --- interrupt: c00 at 0x6b2b48
> [   31.851267] NIP:  00000000006b2b48 LR: 00000000006b2b20 CTR: 
> 0000000000000000
> [   31.857101] REGS: c000000006f97e80 TRAP: 0c00   Not tainted 
> (6.12.0-rc1-2-powerpc64-smp)
> [   31.863978] MSR:  100000000200f032 <HV,VEC,EE,PR,FP,ME,IR,DR,RI>  CR: 
> 28002400  XER: 00000000
> [   31.871235] IRQMASK: 0
>                 GPR00: 0000000000000006 00000000fff4b3d0 
> 00000000f7b7f3a0 0000000000000003
>                 GPR04: 0000000000000000 0000000000000000 
> 0000000000000000 0000000000000000
>                 GPR08: 0000000000000000 0000000000000000 
> 0000000000000000 0000000000000000
>                 GPR12: 0000000000000000 00000000007efff4 
> 0000000000000000 0000000000000000
>                 GPR16: 00000000006e3318 0000000000000001 
> 00000000006e289c 0000000000000063
>                 GPR20: 00000000c04064a0 00000000007f0088 
> 00000000fff4c734 00000000007d165c
>                 GPR24: 00000000007d1668 00000000fff4b400 
> 0000000000000001 0000000000000001
>                 GPR28: 00000000fff4b46c 0000000000000000 
> 00000000007bfff4 0000000000000003
> [   31.926053] NIP [00000000006b2b48] 0x6b2b48
> [   31.928930] LR [00000000006b2b20] 0x6b2b20
> [   31.931720] --- interrupt: c00
> [   31.933466] Code: ebe1fff8 7c0803a6 4e800020 60000000 7c0802a6 
> fbe1fff8 7c7f1b78 f8010010 f821ff81 60000000 60000000 e93f0140 
> <e9290000> 7d2a0074 794ad182 0b0a0000
> [   31.946913] ---[ end trace 0000000000000000 ]---
> 
> 

That's a NULL pointer dereference in drm_gem_object_free().

Trying to read obj->funcs->free while obj->funcs is NULL.

Christophe

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] drm/radeon: add late_register for connector
  2024-10-06 17:37   ` Christophe Leroy
@ 2024-10-06 18:01     ` Christian Zigotzky
  2024-10-07  3:19       ` Kernel doesn't boot after DRM updates (drm-next-2024-09-19) Christian Zigotzky
  2024-10-07  4:49     ` [PATCH] drm/radeon: add late_register for connector Hoi Pok Wu
  2024-10-07 13:17     ` Alex Deucher
  2 siblings, 1 reply; 9+ messages in thread
From: Christian Zigotzky @ 2024-10-06 18:01 UTC (permalink / raw)
  To: Christophe Leroy, Wu Hoi Pok
  Cc: Alex Deucher, Christian König, Xinhui Pan, David Airlie,
	Simona Vetter, open list:RADEON and AMDGPU DRM DRIVERS,
	open list:DRM DRIVERS, open list, linuxppc-dev, R.T.Dickinson,
	mad skateman, hypexed, Christian Zigotzky, Darren Stevens

On 06 October 2024 at 7:37pm, Christophe Leroy wrote:
>
> Le 06/10/2024 à 18:56, Christian Zigotzky a écrit :
>> Hello Wu Hoi Pok,
>>
>> Thanks a lot for your patch. Unfortunately there is a new issue after 
>> patching the RC1. Could you please fix the following issue?
>>
>> Thanks,
>> Christian
>>
>> ---
>>
>> Linux fienix 6.12.0-rc1-2-powerpc64-smp #1 SMP Fri Oct  4 08:55:45 
>> CEST 2024 ppc64 GNU/Linux
>>
>> [   29.167145] systemd[1]: Sent message type=signal sender=n/a 
>> destination=n/a 
>> path=/org/freedesktop/systemd1/unit/NetworkManager_2eservice 
>> interface=org.freedesktop.DBus.Properties member=PropertiesChanged 
>> cookie=103 reply_cookie=0 signature=sa{sv}as error-name=n/a 
>> error-message=n/a
>> [   29.542140] systemd-journald[1301]: Successfully sent stream file 
>> descriptor to service manager.
>> [   29.561863] BUG: Kernel NULL pointer dereference on read at 
>> 0x00000000
>> [   29.567156] Faulting instruction address: 0xc000000000c973c0
>> [   29.571574] cpu 0x1: Vector: 300 (Data Access) at [c000000006f97640]
>> [   29.576637]     pc: c000000000c973c0: .drm_gem_object_free+0x20/0x70
>> [   29.581708]     lr: c000000000d28dd8: .radeon_bo_unref+0x58/0x90
>> [   29.586428]     sp: c000000006f978e0
>> [   29.588695]    msr: 9000000000009032
>> [   29.590962]    dar: 0
>> [   29.591925]  dsisr: 40000000
>> [   29.593496]   current = 0xc0000000085b1f00
>> [   29.596286]   paca    = 0xc00000003ffff680     irqmask: 0x03 
>> irq_happened: 0x01
>> [   29.602119]     pid   = 1524, comm = Xorg.wrap
>> [   29.605257] Linux version 6.12.0-rc1-2-powerpc64-smp 
>> (geeko@buildhost) (powerpc64-suse-linux-gcc (SUSE Linux) 7.5.0, GNU 
>> ld (GNU Binutils; devel:gcc / SLE-15) 2.43.1.20240828-150300.536) #1 
>> SMP Fri Oct  4 08:55:45 CEST 2024
>> [   29.623892] enter ? for help
>> [   29.625487] [c000000006f97960] c000000000d28dd8 
>> .radeon_bo_unref+0x58/0x90
>> [   29.631083] [c000000006f979e0] c000000000e287b0 
>> .radeon_vm_fini+0x260/0x330
>> [   29.636765] [c000000006f97aa0] c000000000d07c94 
>> .radeon_driver_postclose_kms+0x1a4/0x1f0
>> [   29.643579] [c000000006f97b30] c000000000c9374c 
>> .drm_file_free+0x28c/0x300
>> [   29.649174] [c000000006f97be0] c000000000c93900 
>> .drm_release+0x90/0x170
>> [   29.654508] [c000000006f97c70] c000000000304790 .__fput+0x120/0x3b0
>> [   29.659495] [c000000006f97d10] c0000000002fe0fc 
>> .__se_sys_close+0x4c/0xc0
>> [   29.665004] [c000000006f97d90] c000000000025bac 
>> .system_call_exception+0x22c/0x260
>> [   29.671295] [c000000006f97e10] c00000000000b554 
>> system_call_common+0xf4/0x258
>> [   29.677164] --- Exception: c00 (System Call) at 00000000006b2b48
>> [   29.681876] SP (fff4b3d0) is in userspace
>> [   29.684577] 1:mon>  <no input ...>
>> [   31.666727] Oops: Kernel access of bad area, sig: 11 [#1]
>> [   31.670829] BE PAGE_SIZE=4K MMU=Hash SMP NR_CPUS=2 A-EON Amigaone 
>> X1000
>> [   31.676144] Modules linked in: snd_hda_codec_idt 
>> snd_hda_codec_generic snd_hda_codec_hdmi snd_hda_intel 
>> snd_intel_dspcfg snd_hda_codec snd_hda_core dm_mod
>> [   31.688703] CPU: 1 UID: 0 PID: 1524 Comm: Xorg.wrap Not tainted 
>> 6.12.0-rc1-2-powerpc64-smp #1
>> [   31.695932] Hardware name: pasemi,nemo PA6T 0x900102 A-EON 
>> Amigaone X1000
>> [   31.701417] NIP:  c000000000c973c0 LR: c000000000d28dd8 CTR: 
>> c000000000d07af0
>> [   31.707250] REGS: c000000006f97640 TRAP: 0300   Not tainted 
>> (6.12.0-rc1-2-powerpc64-smp)
>> [   31.714128] MSR:  9000000000009032 <SF,HV,EE,ME,IR,DR,RI> CR: 
>> 28002222  XER: 20000000
>> [   31.720773] DAR: 0000000000000000 DSISR: 40000000 IRQMASK: 0
>>                 GPR00: c000000000d28dd8 c000000006f978e0 
>> c00000000207a800 c0000000085f5468
>>                 GPR04: 0000000000000b9b 0000000000000b9a 
>> 0000000179779000 c0000000086a4b00
>>                 GPR08: 0000000000000000 0000000000000000 
>> 0000000000000001 0000000000000000
>>                 GPR12: 0000000048002202 c00000003ffff680 
>> 0000000000000000 0000000000000000
>>                 GPR16: 00000000006e3318 0000000000000001 
>> 00000000006e289c 0000000000000063
>>                 GPR20: 00000000c04064a0 00000000007f0088 
>> 00000000fff4c734 00000000007d165c
>>                 GPR24: 00000000007d1668 c000000024b6a220 
>> c000000003588000 c000000024b6a200
>>                 GPR28: c000000003b3cc00 c000000024b6a248 
>> c000000002d48820 c0000000085f5468
>> [   31.778903] NIP [c000000000c973c0] .drm_gem_object_free+0x20/0x70
>> [   31.783701] LR [c000000000d28dd8] .radeon_bo_unref+0x58/0x90
>> [   31.788062] Call Trace:
>> [   31.789199] [c000000006f978e0] [c000000006f97990] 
>> 0xc000000006f97990 (unreliable)
>> [   31.795388] [c000000006f97960] [c000000000d28dd8] 
>> .radeon_bo_unref+0x58/0x90
>> [   31.801142] [c000000006f979e0] [c000000000e287b0] 
>> .radeon_vm_fini+0x260/0x330
>> [   31.806982] [c000000006f97aa0] [c000000000d07c94] 
>> .radeon_driver_postclose_kms+0x1a4/0x1f0
>> [   31.813954] [c000000006f97b30] [c000000000c9374c] 
>> .drm_file_free+0x28c/0x300
>> [   31.819707] [c000000006f97be0] [c000000000c93900] 
>> .drm_release+0x90/0x170
>> [   31.825197] [c000000006f97c70] [c000000000304790] .__fput+0x120/0x3b0
>> [   31.830342] [c000000006f97d10] [c0000000002fe0fc] 
>> .__se_sys_close+0x4c/0xc0
>> [   31.836010] [c000000006f97d90] [c000000000025bac] 
>> .system_call_exception+0x22c/0x260
>> [   31.842460] [c000000006f97e10] [c00000000000b554] 
>> system_call_common+0xf4/0x258
>> [   31.848476] --- interrupt: c00 at 0x6b2b48
>> [   31.851267] NIP:  00000000006b2b48 LR: 00000000006b2b20 CTR: 
>> 0000000000000000
>> [   31.857101] REGS: c000000006f97e80 TRAP: 0c00   Not tainted 
>> (6.12.0-rc1-2-powerpc64-smp)
>> [   31.863978] MSR:  100000000200f032 <HV,VEC,EE,PR,FP,ME,IR,DR,RI>  
>> CR: 28002400  XER: 00000000
>> [   31.871235] IRQMASK: 0
>>                 GPR00: 0000000000000006 00000000fff4b3d0 
>> 00000000f7b7f3a0 0000000000000003
>>                 GPR04: 0000000000000000 0000000000000000 
>> 0000000000000000 0000000000000000
>>                 GPR08: 0000000000000000 0000000000000000 
>> 0000000000000000 0000000000000000
>>                 GPR12: 0000000000000000 00000000007efff4 
>> 0000000000000000 0000000000000000
>>                 GPR16: 00000000006e3318 0000000000000001 
>> 00000000006e289c 0000000000000063
>>                 GPR20: 00000000c04064a0 00000000007f0088 
>> 00000000fff4c734 00000000007d165c
>>                 GPR24: 00000000007d1668 00000000fff4b400 
>> 0000000000000001 0000000000000001
>>                 GPR28: 00000000fff4b46c 0000000000000000 
>> 00000000007bfff4 0000000000000003
>> [   31.926053] NIP [00000000006b2b48] 0x6b2b48
>> [   31.928930] LR [00000000006b2b20] 0x6b2b20
>> [   31.931720] --- interrupt: c00
>> [   31.933466] Code: ebe1fff8 7c0803a6 4e800020 60000000 7c0802a6 
>> fbe1fff8 7c7f1b78 f8010010 f821ff81 60000000 60000000 e93f0140 
>> <e9290000> 7d2a0074 794ad182 0b0a0000
>> [   31.946913] ---[ end trace 0000000000000000 ]---
>>
>>
>
> That's a NULL pointer dereference in drm_gem_object_free().
>
> Trying to read obj->funcs->free while obj->funcs is NULL.
>
> Christophe

Hello Christophe,

Thank you for the hint. Could you please create a patch? I would like to 
apply it to the RC2 tomorrow.

Thanks,
Christian

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Kernel doesn't boot after DRM updates (drm-next-2024-09-19)
  2024-10-06 18:01     ` Christian Zigotzky
@ 2024-10-07  3:19       ` Christian Zigotzky
  0 siblings, 0 replies; 9+ messages in thread
From: Christian Zigotzky @ 2024-10-07  3:19 UTC (permalink / raw)
  To: Christophe Leroy, Wu Hoi Pok
  Cc: Alex Deucher, Christian König, Xinhui Pan, David Airlie,
	Simona Vetter, open list:RADEON and AMDGPU DRM DRIVERS,
	open list:DRM DRIVERS, open list, linuxppc-dev, R.T.Dickinson,
	mad skateman, hypexed, Christian Zigotzky, Darren Stevens

On 06 October 2024 at 8:01pm, Christian Zigotzky wrote:
> On 06 October 2024 at 7:37pm, Christophe Leroy wrote:
>>
>> Le 06/10/2024 à 18:56, Christian Zigotzky a écrit :
>>> Hello Wu Hoi Pok,
>>>
>>> Thanks a lot for your patch. Unfortunately there is a new issue 
>>> after patching the RC1. Could you please fix the following issue?
>>>
>>> Thanks,
>>> Christian
>>>
>>> ---
>>>
>>> Linux fienix 6.12.0-rc1-2-powerpc64-smp #1 SMP Fri Oct  4 08:55:45 
>>> CEST 2024 ppc64 GNU/Linux
>>>
>>> [   29.167145] systemd[1]: Sent message type=signal sender=n/a 
>>> destination=n/a 
>>> path=/org/freedesktop/systemd1/unit/NetworkManager_2eservice 
>>> interface=org.freedesktop.DBus.Properties member=PropertiesChanged 
>>> cookie=103 reply_cookie=0 signature=sa{sv}as error-name=n/a 
>>> error-message=n/a
>>> [   29.542140] systemd-journald[1301]: Successfully sent stream file 
>>> descriptor to service manager.
>>> [   29.561863] BUG: Kernel NULL pointer dereference on read at 
>>> 0x00000000
>>> [   29.567156] Faulting instruction address: 0xc000000000c973c0
>>> [   29.571574] cpu 0x1: Vector: 300 (Data Access) at [c000000006f97640]
>>> [   29.576637]     pc: c000000000c973c0: .drm_gem_object_free+0x20/0x70
>>> [   29.581708]     lr: c000000000d28dd8: .radeon_bo_unref+0x58/0x90
>>> [   29.586428]     sp: c000000006f978e0
>>> [   29.588695]    msr: 9000000000009032
>>> [   29.590962]    dar: 0
>>> [   29.591925]  dsisr: 40000000
>>> [   29.593496]   current = 0xc0000000085b1f00
>>> [   29.596286]   paca    = 0xc00000003ffff680     irqmask: 0x03 
>>> irq_happened: 0x01
>>> [   29.602119]     pid   = 1524, comm = Xorg.wrap
>>> [   29.605257] Linux version 6.12.0-rc1-2-powerpc64-smp 
>>> (geeko@buildhost) (powerpc64-suse-linux-gcc (SUSE Linux) 7.5.0, GNU 
>>> ld (GNU Binutils; devel:gcc / SLE-15) 2.43.1.20240828-150300.536) #1 
>>> SMP Fri Oct  4 08:55:45 CEST 2024
>>> [   29.623892] enter ? for help
>>> [   29.625487] [c000000006f97960] c000000000d28dd8 
>>> .radeon_bo_unref+0x58/0x90
>>> [   29.631083] [c000000006f979e0] c000000000e287b0 
>>> .radeon_vm_fini+0x260/0x330
>>> [   29.636765] [c000000006f97aa0] c000000000d07c94 
>>> .radeon_driver_postclose_kms+0x1a4/0x1f0
>>> [   29.643579] [c000000006f97b30] c000000000c9374c 
>>> .drm_file_free+0x28c/0x300
>>> [   29.649174] [c000000006f97be0] c000000000c93900 
>>> .drm_release+0x90/0x170
>>> [   29.654508] [c000000006f97c70] c000000000304790 .__fput+0x120/0x3b0
>>> [   29.659495] [c000000006f97d10] c0000000002fe0fc 
>>> .__se_sys_close+0x4c/0xc0
>>> [   29.665004] [c000000006f97d90] c000000000025bac 
>>> .system_call_exception+0x22c/0x260
>>> [   29.671295] [c000000006f97e10] c00000000000b554 
>>> system_call_common+0xf4/0x258
>>> [   29.677164] --- Exception: c00 (System Call) at 00000000006b2b48
>>> [   29.681876] SP (fff4b3d0) is in userspace
>>> [   29.684577] 1:mon>  <no input ...>
>>> [   31.666727] Oops: Kernel access of bad area, sig: 11 [#1]
>>> [   31.670829] BE PAGE_SIZE=4K MMU=Hash SMP NR_CPUS=2 A-EON Amigaone 
>>> X1000
>>> [   31.676144] Modules linked in: snd_hda_codec_idt 
>>> snd_hda_codec_generic snd_hda_codec_hdmi snd_hda_intel 
>>> snd_intel_dspcfg snd_hda_codec snd_hda_core dm_mod
>>> [   31.688703] CPU: 1 UID: 0 PID: 1524 Comm: Xorg.wrap Not tainted 
>>> 6.12.0-rc1-2-powerpc64-smp #1
>>> [   31.695932] Hardware name: pasemi,nemo PA6T 0x900102 A-EON 
>>> Amigaone X1000
>>> [   31.701417] NIP:  c000000000c973c0 LR: c000000000d28dd8 CTR: 
>>> c000000000d07af0
>>> [   31.707250] REGS: c000000006f97640 TRAP: 0300   Not tainted 
>>> (6.12.0-rc1-2-powerpc64-smp)
>>> [   31.714128] MSR:  9000000000009032 <SF,HV,EE,ME,IR,DR,RI> CR: 
>>> 28002222  XER: 20000000
>>> [   31.720773] DAR: 0000000000000000 DSISR: 40000000 IRQMASK: 0
>>>                 GPR00: c000000000d28dd8 c000000006f978e0 
>>> c00000000207a800 c0000000085f5468
>>>                 GPR04: 0000000000000b9b 0000000000000b9a 
>>> 0000000179779000 c0000000086a4b00
>>>                 GPR08: 0000000000000000 0000000000000000 
>>> 0000000000000001 0000000000000000
>>>                 GPR12: 0000000048002202 c00000003ffff680 
>>> 0000000000000000 0000000000000000
>>>                 GPR16: 00000000006e3318 0000000000000001 
>>> 00000000006e289c 0000000000000063
>>>                 GPR20: 00000000c04064a0 00000000007f0088 
>>> 00000000fff4c734 00000000007d165c
>>>                 GPR24: 00000000007d1668 c000000024b6a220 
>>> c000000003588000 c000000024b6a200
>>>                 GPR28: c000000003b3cc00 c000000024b6a248 
>>> c000000002d48820 c0000000085f5468
>>> [   31.778903] NIP [c000000000c973c0] .drm_gem_object_free+0x20/0x70
>>> [   31.783701] LR [c000000000d28dd8] .radeon_bo_unref+0x58/0x90
>>> [   31.788062] Call Trace:
>>> [   31.789199] [c000000006f978e0] [c000000006f97990] 
>>> 0xc000000006f97990 (unreliable)
>>> [   31.795388] [c000000006f97960] [c000000000d28dd8] 
>>> .radeon_bo_unref+0x58/0x90
>>> [   31.801142] [c000000006f979e0] [c000000000e287b0] 
>>> .radeon_vm_fini+0x260/0x330
>>> [   31.806982] [c000000006f97aa0] [c000000000d07c94] 
>>> .radeon_driver_postclose_kms+0x1a4/0x1f0
>>> [   31.813954] [c000000006f97b30] [c000000000c9374c] 
>>> .drm_file_free+0x28c/0x300
>>> [   31.819707] [c000000006f97be0] [c000000000c93900] 
>>> .drm_release+0x90/0x170
>>> [   31.825197] [c000000006f97c70] [c000000000304790] 
>>> .__fput+0x120/0x3b0
>>> [   31.830342] [c000000006f97d10] [c0000000002fe0fc] 
>>> .__se_sys_close+0x4c/0xc0
>>> [   31.836010] [c000000006f97d90] [c000000000025bac] 
>>> .system_call_exception+0x22c/0x260
>>> [   31.842460] [c000000006f97e10] [c00000000000b554] 
>>> system_call_common+0xf4/0x258
>>> [   31.848476] --- interrupt: c00 at 0x6b2b48
>>> [   31.851267] NIP:  00000000006b2b48 LR: 00000000006b2b20 CTR: 
>>> 0000000000000000
>>> [   31.857101] REGS: c000000006f97e80 TRAP: 0c00   Not tainted 
>>> (6.12.0-rc1-2-powerpc64-smp)
>>> [   31.863978] MSR:  100000000200f032 <HV,VEC,EE,PR,FP,ME,IR,DR,RI>  
>>> CR: 28002400  XER: 00000000
>>> [   31.871235] IRQMASK: 0
>>>                 GPR00: 0000000000000006 00000000fff4b3d0 
>>> 00000000f7b7f3a0 0000000000000003
>>>                 GPR04: 0000000000000000 0000000000000000 
>>> 0000000000000000 0000000000000000
>>>                 GPR08: 0000000000000000 0000000000000000 
>>> 0000000000000000 0000000000000000
>>>                 GPR12: 0000000000000000 00000000007efff4 
>>> 0000000000000000 0000000000000000
>>>                 GPR16: 00000000006e3318 0000000000000001 
>>> 00000000006e289c 0000000000000063
>>>                 GPR20: 00000000c04064a0 00000000007f0088 
>>> 00000000fff4c734 00000000007d165c
>>>                 GPR24: 00000000007d1668 00000000fff4b400 
>>> 0000000000000001 0000000000000001
>>>                 GPR28: 00000000fff4b46c 0000000000000000 
>>> 00000000007bfff4 0000000000000003
>>> [   31.926053] NIP [00000000006b2b48] 0x6b2b48
>>> [   31.928930] LR [00000000006b2b20] 0x6b2b20
>>> [   31.931720] --- interrupt: c00
>>> [   31.933466] Code: ebe1fff8 7c0803a6 4e800020 60000000 7c0802a6 
>>> fbe1fff8 7c7f1b78 f8010010 f821ff81 60000000 60000000 e93f0140 
>>> <e9290000> 7d2a0074 794ad182 0b0a0000
>>> [   31.946913] ---[ end trace 0000000000000000 ]---
>>>
>>>
>>
>> That's a NULL pointer dereference in drm_gem_object_free().
>>
>> Trying to read obj->funcs->free while obj->funcs is NULL.
>>
>> Christophe
>
> Hello Christophe,
>
> Thank you for the hint. Could you please create a patch? I would like 
> to apply it to the RC2 tomorrow.
>
> Thanks,
> Christian

Hello Wu Hoi Pok,

Reverting of the drm-next-2024-09-19 updates solves the issue.

Please check the drm-next-2024-09-19 updates.

Thanks,
Christian

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/radeon: add late_register for connector
  2024-10-06 17:37   ` Christophe Leroy
  2024-10-06 18:01     ` Christian Zigotzky
@ 2024-10-07  4:49     ` Hoi Pok Wu
  2024-10-07 14:08       ` Christian König
  2024-10-07 13:17     ` Alex Deucher
  2 siblings, 1 reply; 9+ messages in thread
From: Hoi Pok Wu @ 2024-10-07  4:49 UTC (permalink / raw)
  To: Christophe Leroy
  Cc: Christian Zigotzky, Alex Deucher, Christian König,
	Xinhui Pan, David Airlie, Simona Vetter,
	open list:RADEON and AMDGPU DRM DRIVERS, open list:DRM DRIVERS,
	open list, linuxppc-dev, R.T.Dickinson, mad skateman, hypexed,
	Christian Zigotzky, Darren Stevens

Thank you. I am looking at the problem now.

On Mon, Oct 7, 2024 at 1:37 AM Christophe Leroy
<christophe.leroy@csgroup.eu> wrote:
>
>
>
> Le 06/10/2024 à 18:56, Christian Zigotzky a écrit :
> > On 03 October 2024 at 08:06 am, Wu Hoi Pok wrote:
> >> This is a fix patch not tested yet,
> >> for a bug I introduce in previous rework of radeon driver.
> >> The bug is a null dereference in 'aux.dev', which is the
> >> 'device' not registered, resulting in kernel panic. By having
> >> 'late_register', the connector should be registered after
> >> 'drm_dev_register' automatically.
> >>
> >> Please help testing thank you.
> > Hello Wu Hoi Pok,
> >
> > Thanks a lot for your patch. Unfortunately there is a new issue after
> > patching the RC1. Could you please fix the following issue?
> >
> > Thanks,
> > Christian
> >
> > ---
> >
> > Linux fienix 6.12.0-rc1-2-powerpc64-smp #1 SMP Fri Oct  4 08:55:45 CEST
> > 2024 ppc64 GNU/Linux
> >
> > [   29.167145] systemd[1]: Sent message type=signal sender=n/a
> > destination=n/a
> > path=/org/freedesktop/systemd1/unit/NetworkManager_2eservice
> > interface=org.freedesktop.DBus.Properties member=PropertiesChanged
> > cookie=103 reply_cookie=0 signature=sa{sv}as error-name=n/a
> > error-message=n/a
> > [   29.542140] systemd-journald[1301]: Successfully sent stream file
> > descriptor to service manager.
> > [   29.561863] BUG: Kernel NULL pointer dereference on read at 0x00000000
> > [   29.567156] Faulting instruction address: 0xc000000000c973c0
> > [   29.571574] cpu 0x1: Vector: 300 (Data Access) at [c000000006f97640]
> > [   29.576637]     pc: c000000000c973c0: .drm_gem_object_free+0x20/0x70
> > [   29.581708]     lr: c000000000d28dd8: .radeon_bo_unref+0x58/0x90
> > [   29.586428]     sp: c000000006f978e0
> > [   29.588695]    msr: 9000000000009032
> > [   29.590962]    dar: 0
> > [   29.591925]  dsisr: 40000000
> > [   29.593496]   current = 0xc0000000085b1f00
> > [   29.596286]   paca    = 0xc00000003ffff680     irqmask: 0x03
> > irq_happened: 0x01
> > [   29.602119]     pid   = 1524, comm = Xorg.wrap
> > [   29.605257] Linux version 6.12.0-rc1-2-powerpc64-smp
> > (geeko@buildhost) (powerpc64-suse-linux-gcc (SUSE Linux) 7.5.0, GNU ld
> > (GNU Binutils; devel:gcc / SLE-15) 2.43.1.20240828-150300.536) #1 SMP
> > Fri Oct  4 08:55:45 CEST 2024
> > [   29.623892] enter ? for help
> > [   29.625487] [c000000006f97960] c000000000d28dd8
> > .radeon_bo_unref+0x58/0x90
> > [   29.631083] [c000000006f979e0] c000000000e287b0
> > .radeon_vm_fini+0x260/0x330
> > [   29.636765] [c000000006f97aa0] c000000000d07c94
> > .radeon_driver_postclose_kms+0x1a4/0x1f0
> > [   29.643579] [c000000006f97b30] c000000000c9374c
> > .drm_file_free+0x28c/0x300
> > [   29.649174] [c000000006f97be0] c000000000c93900 .drm_release+0x90/0x170
> > [   29.654508] [c000000006f97c70] c000000000304790 .__fput+0x120/0x3b0
> > [   29.659495] [c000000006f97d10] c0000000002fe0fc .__se_sys_close+0x4c/0xc0
> > [   29.665004] [c000000006f97d90] c000000000025bac
> > .system_call_exception+0x22c/0x260
> > [   29.671295] [c000000006f97e10] c00000000000b554
> > system_call_common+0xf4/0x258
> > [   29.677164] --- Exception: c00 (System Call) at 00000000006b2b48
> > [   29.681876] SP (fff4b3d0) is in userspace
> > [   29.684577] 1:mon>  <no input ...>
> > [   31.666727] Oops: Kernel access of bad area, sig: 11 [#1]
> > [   31.670829] BE PAGE_SIZE=4K MMU=Hash SMP NR_CPUS=2 A-EON Amigaone X1000
> > [   31.676144] Modules linked in: snd_hda_codec_idt
> > snd_hda_codec_generic snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg
> > snd_hda_codec snd_hda_core dm_mod
> > [   31.688703] CPU: 1 UID: 0 PID: 1524 Comm: Xorg.wrap Not tainted
> > 6.12.0-rc1-2-powerpc64-smp #1
> > [   31.695932] Hardware name: pasemi,nemo PA6T 0x900102 A-EON Amigaone X1000
> > [   31.701417] NIP:  c000000000c973c0 LR: c000000000d28dd8 CTR:
> > c000000000d07af0
> > [   31.707250] REGS: c000000006f97640 TRAP: 0300   Not tainted
> > (6.12.0-rc1-2-powerpc64-smp)
> > [   31.714128] MSR:  9000000000009032 <SF,HV,EE,ME,IR,DR,RI> CR:
> > 28002222  XER: 20000000
> > [   31.720773] DAR: 0000000000000000 DSISR: 40000000 IRQMASK: 0
> >                 GPR00: c000000000d28dd8 c000000006f978e0
> > c00000000207a800 c0000000085f5468
> >                 GPR04: 0000000000000b9b 0000000000000b9a
> > 0000000179779000 c0000000086a4b00
> >                 GPR08: 0000000000000000 0000000000000000
> > 0000000000000001 0000000000000000
> >                 GPR12: 0000000048002202 c00000003ffff680
> > 0000000000000000 0000000000000000
> >                 GPR16: 00000000006e3318 0000000000000001
> > 00000000006e289c 0000000000000063
> >                 GPR20: 00000000c04064a0 00000000007f0088
> > 00000000fff4c734 00000000007d165c
> >                 GPR24: 00000000007d1668 c000000024b6a220
> > c000000003588000 c000000024b6a200
> >                 GPR28: c000000003b3cc00 c000000024b6a248
> > c000000002d48820 c0000000085f5468
> > [   31.778903] NIP [c000000000c973c0] .drm_gem_object_free+0x20/0x70
> > [   31.783701] LR [c000000000d28dd8] .radeon_bo_unref+0x58/0x90
> > [   31.788062] Call Trace:
> > [   31.789199] [c000000006f978e0] [c000000006f97990] 0xc000000006f97990
> > (unreliable)
> > [   31.795388] [c000000006f97960] [c000000000d28dd8]
> > .radeon_bo_unref+0x58/0x90
> > [   31.801142] [c000000006f979e0] [c000000000e287b0]
> > .radeon_vm_fini+0x260/0x330
> > [   31.806982] [c000000006f97aa0] [c000000000d07c94]
> > .radeon_driver_postclose_kms+0x1a4/0x1f0
> > [   31.813954] [c000000006f97b30] [c000000000c9374c]
> > .drm_file_free+0x28c/0x300
> > [   31.819707] [c000000006f97be0] [c000000000c93900] .drm_release+0x90/0x170
> > [   31.825197] [c000000006f97c70] [c000000000304790] .__fput+0x120/0x3b0
> > [   31.830342] [c000000006f97d10] [c0000000002fe0fc]
> > .__se_sys_close+0x4c/0xc0
> > [   31.836010] [c000000006f97d90] [c000000000025bac]
> > .system_call_exception+0x22c/0x260
> > [   31.842460] [c000000006f97e10] [c00000000000b554]
> > system_call_common+0xf4/0x258
> > [   31.848476] --- interrupt: c00 at 0x6b2b48
> > [   31.851267] NIP:  00000000006b2b48 LR: 00000000006b2b20 CTR:
> > 0000000000000000
> > [   31.857101] REGS: c000000006f97e80 TRAP: 0c00   Not tainted
> > (6.12.0-rc1-2-powerpc64-smp)
> > [   31.863978] MSR:  100000000200f032 <HV,VEC,EE,PR,FP,ME,IR,DR,RI>  CR:
> > 28002400  XER: 00000000
> > [   31.871235] IRQMASK: 0
> >                 GPR00: 0000000000000006 00000000fff4b3d0
> > 00000000f7b7f3a0 0000000000000003
> >                 GPR04: 0000000000000000 0000000000000000
> > 0000000000000000 0000000000000000
> >                 GPR08: 0000000000000000 0000000000000000
> > 0000000000000000 0000000000000000
> >                 GPR12: 0000000000000000 00000000007efff4
> > 0000000000000000 0000000000000000
> >                 GPR16: 00000000006e3318 0000000000000001
> > 00000000006e289c 0000000000000063
> >                 GPR20: 00000000c04064a0 00000000007f0088
> > 00000000fff4c734 00000000007d165c
> >                 GPR24: 00000000007d1668 00000000fff4b400
> > 0000000000000001 0000000000000001
> >                 GPR28: 00000000fff4b46c 0000000000000000
> > 00000000007bfff4 0000000000000003
> > [   31.926053] NIP [00000000006b2b48] 0x6b2b48
> > [   31.928930] LR [00000000006b2b20] 0x6b2b20
> > [   31.931720] --- interrupt: c00
> > [   31.933466] Code: ebe1fff8 7c0803a6 4e800020 60000000 7c0802a6
> > fbe1fff8 7c7f1b78 f8010010 f821ff81 60000000 60000000 e93f0140
> > <e9290000> 7d2a0074 794ad182 0b0a0000
> > [   31.946913] ---[ end trace 0000000000000000 ]---
> >
> >
>
> That's a NULL pointer dereference in drm_gem_object_free().
>
> Trying to read obj->funcs->free while obj->funcs is NULL.
>
> Christophe

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/radeon: add late_register for connector
  2024-10-07  4:49     ` [PATCH] drm/radeon: add late_register for connector Hoi Pok Wu
@ 2024-10-07 14:08       ` Christian König
  0 siblings, 0 replies; 9+ messages in thread
From: Christian König @ 2024-10-07 14:08 UTC (permalink / raw)
  To: Hoi Pok Wu, Christophe Leroy
  Cc: Christian Zigotzky, Alex Deucher, Xinhui Pan, David Airlie,
	Simona Vetter, open list:RADEON and AMDGPU DRM DRIVERS,
	open list:DRM DRIVERS, open list, linuxppc-dev, R.T.Dickinson,
	mad skateman, hypexed, Christian Zigotzky, Darren Stevens

That's the issue I was working on, give me 10 minutes to send out the fix.

Regards,
Christian.

Am 07.10.24 um 06:49 schrieb Hoi Pok Wu:
> Thank you. I am looking at the problem now.
>
> On Mon, Oct 7, 2024 at 1:37 AM Christophe Leroy
> <christophe.leroy@csgroup.eu> wrote:
>>
>>
>> Le 06/10/2024 à 18:56, Christian Zigotzky a écrit :
>>> On 03 October 2024 at 08:06 am, Wu Hoi Pok wrote:
>>>> This is a fix patch not tested yet,
>>>> for a bug I introduce in previous rework of radeon driver.
>>>> The bug is a null dereference in 'aux.dev', which is the
>>>> 'device' not registered, resulting in kernel panic. By having
>>>> 'late_register', the connector should be registered after
>>>> 'drm_dev_register' automatically.
>>>>
>>>> Please help testing thank you.
>>> Hello Wu Hoi Pok,
>>>
>>> Thanks a lot for your patch. Unfortunately there is a new issue after
>>> patching the RC1. Could you please fix the following issue?
>>>
>>> Thanks,
>>> Christian
>>>
>>> ---
>>>
>>> Linux fienix 6.12.0-rc1-2-powerpc64-smp #1 SMP Fri Oct  4 08:55:45 CEST
>>> 2024 ppc64 GNU/Linux
>>>
>>> [   29.167145] systemd[1]: Sent message type=signal sender=n/a
>>> destination=n/a
>>> path=/org/freedesktop/systemd1/unit/NetworkManager_2eservice
>>> interface=org.freedesktop.DBus.Properties member=PropertiesChanged
>>> cookie=103 reply_cookie=0 signature=sa{sv}as error-name=n/a
>>> error-message=n/a
>>> [   29.542140] systemd-journald[1301]: Successfully sent stream file
>>> descriptor to service manager.
>>> [   29.561863] BUG: Kernel NULL pointer dereference on read at 0x00000000
>>> [   29.567156] Faulting instruction address: 0xc000000000c973c0
>>> [   29.571574] cpu 0x1: Vector: 300 (Data Access) at [c000000006f97640]
>>> [   29.576637]     pc: c000000000c973c0: .drm_gem_object_free+0x20/0x70
>>> [   29.581708]     lr: c000000000d28dd8: .radeon_bo_unref+0x58/0x90
>>> [   29.586428]     sp: c000000006f978e0
>>> [   29.588695]    msr: 9000000000009032
>>> [   29.590962]    dar: 0
>>> [   29.591925]  dsisr: 40000000
>>> [   29.593496]   current = 0xc0000000085b1f00
>>> [   29.596286]   paca    = 0xc00000003ffff680     irqmask: 0x03
>>> irq_happened: 0x01
>>> [   29.602119]     pid   = 1524, comm = Xorg.wrap
>>> [   29.605257] Linux version 6.12.0-rc1-2-powerpc64-smp
>>> (geeko@buildhost) (powerpc64-suse-linux-gcc (SUSE Linux) 7.5.0, GNU ld
>>> (GNU Binutils; devel:gcc / SLE-15) 2.43.1.20240828-150300.536) #1 SMP
>>> Fri Oct  4 08:55:45 CEST 2024
>>> [   29.623892] enter ? for help
>>> [   29.625487] [c000000006f97960] c000000000d28dd8
>>> .radeon_bo_unref+0x58/0x90
>>> [   29.631083] [c000000006f979e0] c000000000e287b0
>>> .radeon_vm_fini+0x260/0x330
>>> [   29.636765] [c000000006f97aa0] c000000000d07c94
>>> .radeon_driver_postclose_kms+0x1a4/0x1f0
>>> [   29.643579] [c000000006f97b30] c000000000c9374c
>>> .drm_file_free+0x28c/0x300
>>> [   29.649174] [c000000006f97be0] c000000000c93900 .drm_release+0x90/0x170
>>> [   29.654508] [c000000006f97c70] c000000000304790 .__fput+0x120/0x3b0
>>> [   29.659495] [c000000006f97d10] c0000000002fe0fc .__se_sys_close+0x4c/0xc0
>>> [   29.665004] [c000000006f97d90] c000000000025bac
>>> .system_call_exception+0x22c/0x260
>>> [   29.671295] [c000000006f97e10] c00000000000b554
>>> system_call_common+0xf4/0x258
>>> [   29.677164] --- Exception: c00 (System Call) at 00000000006b2b48
>>> [   29.681876] SP (fff4b3d0) is in userspace
>>> [   29.684577] 1:mon>  <no input ...>
>>> [   31.666727] Oops: Kernel access of bad area, sig: 11 [#1]
>>> [   31.670829] BE PAGE_SIZE=4K MMU=Hash SMP NR_CPUS=2 A-EON Amigaone X1000
>>> [   31.676144] Modules linked in: snd_hda_codec_idt
>>> snd_hda_codec_generic snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg
>>> snd_hda_codec snd_hda_core dm_mod
>>> [   31.688703] CPU: 1 UID: 0 PID: 1524 Comm: Xorg.wrap Not tainted
>>> 6.12.0-rc1-2-powerpc64-smp #1
>>> [   31.695932] Hardware name: pasemi,nemo PA6T 0x900102 A-EON Amigaone X1000
>>> [   31.701417] NIP:  c000000000c973c0 LR: c000000000d28dd8 CTR:
>>> c000000000d07af0
>>> [   31.707250] REGS: c000000006f97640 TRAP: 0300   Not tainted
>>> (6.12.0-rc1-2-powerpc64-smp)
>>> [   31.714128] MSR:  9000000000009032 <SF,HV,EE,ME,IR,DR,RI> CR:
>>> 28002222  XER: 20000000
>>> [   31.720773] DAR: 0000000000000000 DSISR: 40000000 IRQMASK: 0
>>>                  GPR00: c000000000d28dd8 c000000006f978e0
>>> c00000000207a800 c0000000085f5468
>>>                  GPR04: 0000000000000b9b 0000000000000b9a
>>> 0000000179779000 c0000000086a4b00
>>>                  GPR08: 0000000000000000 0000000000000000
>>> 0000000000000001 0000000000000000
>>>                  GPR12: 0000000048002202 c00000003ffff680
>>> 0000000000000000 0000000000000000
>>>                  GPR16: 00000000006e3318 0000000000000001
>>> 00000000006e289c 0000000000000063
>>>                  GPR20: 00000000c04064a0 00000000007f0088
>>> 00000000fff4c734 00000000007d165c
>>>                  GPR24: 00000000007d1668 c000000024b6a220
>>> c000000003588000 c000000024b6a200
>>>                  GPR28: c000000003b3cc00 c000000024b6a248
>>> c000000002d48820 c0000000085f5468
>>> [   31.778903] NIP [c000000000c973c0] .drm_gem_object_free+0x20/0x70
>>> [   31.783701] LR [c000000000d28dd8] .radeon_bo_unref+0x58/0x90
>>> [   31.788062] Call Trace:
>>> [   31.789199] [c000000006f978e0] [c000000006f97990] 0xc000000006f97990
>>> (unreliable)
>>> [   31.795388] [c000000006f97960] [c000000000d28dd8]
>>> .radeon_bo_unref+0x58/0x90
>>> [   31.801142] [c000000006f979e0] [c000000000e287b0]
>>> .radeon_vm_fini+0x260/0x330
>>> [   31.806982] [c000000006f97aa0] [c000000000d07c94]
>>> .radeon_driver_postclose_kms+0x1a4/0x1f0
>>> [   31.813954] [c000000006f97b30] [c000000000c9374c]
>>> .drm_file_free+0x28c/0x300
>>> [   31.819707] [c000000006f97be0] [c000000000c93900] .drm_release+0x90/0x170
>>> [   31.825197] [c000000006f97c70] [c000000000304790] .__fput+0x120/0x3b0
>>> [   31.830342] [c000000006f97d10] [c0000000002fe0fc]
>>> .__se_sys_close+0x4c/0xc0
>>> [   31.836010] [c000000006f97d90] [c000000000025bac]
>>> .system_call_exception+0x22c/0x260
>>> [   31.842460] [c000000006f97e10] [c00000000000b554]
>>> system_call_common+0xf4/0x258
>>> [   31.848476] --- interrupt: c00 at 0x6b2b48
>>> [   31.851267] NIP:  00000000006b2b48 LR: 00000000006b2b20 CTR:
>>> 0000000000000000
>>> [   31.857101] REGS: c000000006f97e80 TRAP: 0c00   Not tainted
>>> (6.12.0-rc1-2-powerpc64-smp)
>>> [   31.863978] MSR:  100000000200f032 <HV,VEC,EE,PR,FP,ME,IR,DR,RI>  CR:
>>> 28002400  XER: 00000000
>>> [   31.871235] IRQMASK: 0
>>>                  GPR00: 0000000000000006 00000000fff4b3d0
>>> 00000000f7b7f3a0 0000000000000003
>>>                  GPR04: 0000000000000000 0000000000000000
>>> 0000000000000000 0000000000000000
>>>                  GPR08: 0000000000000000 0000000000000000
>>> 0000000000000000 0000000000000000
>>>                  GPR12: 0000000000000000 00000000007efff4
>>> 0000000000000000 0000000000000000
>>>                  GPR16: 00000000006e3318 0000000000000001
>>> 00000000006e289c 0000000000000063
>>>                  GPR20: 00000000c04064a0 00000000007f0088
>>> 00000000fff4c734 00000000007d165c
>>>                  GPR24: 00000000007d1668 00000000fff4b400
>>> 0000000000000001 0000000000000001
>>>                  GPR28: 00000000fff4b46c 0000000000000000
>>> 00000000007bfff4 0000000000000003
>>> [   31.926053] NIP [00000000006b2b48] 0x6b2b48
>>> [   31.928930] LR [00000000006b2b20] 0x6b2b20
>>> [   31.931720] --- interrupt: c00
>>> [   31.933466] Code: ebe1fff8 7c0803a6 4e800020 60000000 7c0802a6
>>> fbe1fff8 7c7f1b78 f8010010 f821ff81 60000000 60000000 e93f0140
>>> <e9290000> 7d2a0074 794ad182 0b0a0000
>>> [   31.946913] ---[ end trace 0000000000000000 ]---
>>>
>>>
>> That's a NULL pointer dereference in drm_gem_object_free().
>>
>> Trying to read obj->funcs->free while obj->funcs is NULL.
>>
>> Christophe


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/radeon: add late_register for connector
  2024-10-06 17:37   ` Christophe Leroy
  2024-10-06 18:01     ` Christian Zigotzky
  2024-10-07  4:49     ` [PATCH] drm/radeon: add late_register for connector Hoi Pok Wu
@ 2024-10-07 13:17     ` Alex Deucher
  2 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2024-10-07 13:17 UTC (permalink / raw)
  To: Christophe Leroy
  Cc: Christian Zigotzky, Wu Hoi Pok, Alex Deucher,
	Christian König, Xinhui Pan, David Airlie, Simona Vetter,
	open list:RADEON and AMDGPU DRM DRIVERS, open list:DRM DRIVERS,
	open list, linuxppc-dev, R.T.Dickinson, mad skateman, hypexed,
	Christian Zigotzky, Darren Stevens

This is a different issue related to the radeon ttm to gem conversion.
@Christian Koenig is working on the fix.

Alex

On Mon, Oct 7, 2024 at 4:23 AM Christophe Leroy
<christophe.leroy@csgroup.eu> wrote:
>
>
>
> Le 06/10/2024 à 18:56, Christian Zigotzky a écrit :
> > On 03 October 2024 at 08:06 am, Wu Hoi Pok wrote:
> >> This is a fix patch not tested yet,
> >> for a bug I introduce in previous rework of radeon driver.
> >> The bug is a null dereference in 'aux.dev', which is the
> >> 'device' not registered, resulting in kernel panic. By having
> >> 'late_register', the connector should be registered after
> >> 'drm_dev_register' automatically.
> >>
> >> Please help testing thank you.
> > Hello Wu Hoi Pok,
> >
> > Thanks a lot for your patch. Unfortunately there is a new issue after
> > patching the RC1. Could you please fix the following issue?
> >
> > Thanks,
> > Christian
> >
> > ---
> >
> > Linux fienix 6.12.0-rc1-2-powerpc64-smp #1 SMP Fri Oct  4 08:55:45 CEST
> > 2024 ppc64 GNU/Linux
> >
> > [   29.167145] systemd[1]: Sent message type=signal sender=n/a
> > destination=n/a
> > path=/org/freedesktop/systemd1/unit/NetworkManager_2eservice
> > interface=org.freedesktop.DBus.Properties member=PropertiesChanged
> > cookie=103 reply_cookie=0 signature=sa{sv}as error-name=n/a
> > error-message=n/a
> > [   29.542140] systemd-journald[1301]: Successfully sent stream file
> > descriptor to service manager.
> > [   29.561863] BUG: Kernel NULL pointer dereference on read at 0x00000000
> > [   29.567156] Faulting instruction address: 0xc000000000c973c0
> > [   29.571574] cpu 0x1: Vector: 300 (Data Access) at [c000000006f97640]
> > [   29.576637]     pc: c000000000c973c0: .drm_gem_object_free+0x20/0x70
> > [   29.581708]     lr: c000000000d28dd8: .radeon_bo_unref+0x58/0x90
> > [   29.586428]     sp: c000000006f978e0
> > [   29.588695]    msr: 9000000000009032
> > [   29.590962]    dar: 0
> > [   29.591925]  dsisr: 40000000
> > [   29.593496]   current = 0xc0000000085b1f00
> > [   29.596286]   paca    = 0xc00000003ffff680     irqmask: 0x03
> > irq_happened: 0x01
> > [   29.602119]     pid   = 1524, comm = Xorg.wrap
> > [   29.605257] Linux version 6.12.0-rc1-2-powerpc64-smp
> > (geeko@buildhost) (powerpc64-suse-linux-gcc (SUSE Linux) 7.5.0, GNU ld
> > (GNU Binutils; devel:gcc / SLE-15) 2.43.1.20240828-150300.536) #1 SMP
> > Fri Oct  4 08:55:45 CEST 2024
> > [   29.623892] enter ? for help
> > [   29.625487] [c000000006f97960] c000000000d28dd8
> > .radeon_bo_unref+0x58/0x90
> > [   29.631083] [c000000006f979e0] c000000000e287b0
> > .radeon_vm_fini+0x260/0x330
> > [   29.636765] [c000000006f97aa0] c000000000d07c94
> > .radeon_driver_postclose_kms+0x1a4/0x1f0
> > [   29.643579] [c000000006f97b30] c000000000c9374c
> > .drm_file_free+0x28c/0x300
> > [   29.649174] [c000000006f97be0] c000000000c93900 .drm_release+0x90/0x170
> > [   29.654508] [c000000006f97c70] c000000000304790 .__fput+0x120/0x3b0
> > [   29.659495] [c000000006f97d10] c0000000002fe0fc .__se_sys_close+0x4c/0xc0
> > [   29.665004] [c000000006f97d90] c000000000025bac
> > .system_call_exception+0x22c/0x260
> > [   29.671295] [c000000006f97e10] c00000000000b554
> > system_call_common+0xf4/0x258
> > [   29.677164] --- Exception: c00 (System Call) at 00000000006b2b48
> > [   29.681876] SP (fff4b3d0) is in userspace
> > [   29.684577] 1:mon>  <no input ...>
> > [   31.666727] Oops: Kernel access of bad area, sig: 11 [#1]
> > [   31.670829] BE PAGE_SIZE=4K MMU=Hash SMP NR_CPUS=2 A-EON Amigaone X1000
> > [   31.676144] Modules linked in: snd_hda_codec_idt
> > snd_hda_codec_generic snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg
> > snd_hda_codec snd_hda_core dm_mod
> > [   31.688703] CPU: 1 UID: 0 PID: 1524 Comm: Xorg.wrap Not tainted
> > 6.12.0-rc1-2-powerpc64-smp #1
> > [   31.695932] Hardware name: pasemi,nemo PA6T 0x900102 A-EON Amigaone X1000
> > [   31.701417] NIP:  c000000000c973c0 LR: c000000000d28dd8 CTR:
> > c000000000d07af0
> > [   31.707250] REGS: c000000006f97640 TRAP: 0300   Not tainted
> > (6.12.0-rc1-2-powerpc64-smp)
> > [   31.714128] MSR:  9000000000009032 <SF,HV,EE,ME,IR,DR,RI> CR:
> > 28002222  XER: 20000000
> > [   31.720773] DAR: 0000000000000000 DSISR: 40000000 IRQMASK: 0
> >                 GPR00: c000000000d28dd8 c000000006f978e0
> > c00000000207a800 c0000000085f5468
> >                 GPR04: 0000000000000b9b 0000000000000b9a
> > 0000000179779000 c0000000086a4b00
> >                 GPR08: 0000000000000000 0000000000000000
> > 0000000000000001 0000000000000000
> >                 GPR12: 0000000048002202 c00000003ffff680
> > 0000000000000000 0000000000000000
> >                 GPR16: 00000000006e3318 0000000000000001
> > 00000000006e289c 0000000000000063
> >                 GPR20: 00000000c04064a0 00000000007f0088
> > 00000000fff4c734 00000000007d165c
> >                 GPR24: 00000000007d1668 c000000024b6a220
> > c000000003588000 c000000024b6a200
> >                 GPR28: c000000003b3cc00 c000000024b6a248
> > c000000002d48820 c0000000085f5468
> > [   31.778903] NIP [c000000000c973c0] .drm_gem_object_free+0x20/0x70
> > [   31.783701] LR [c000000000d28dd8] .radeon_bo_unref+0x58/0x90
> > [   31.788062] Call Trace:
> > [   31.789199] [c000000006f978e0] [c000000006f97990] 0xc000000006f97990
> > (unreliable)
> > [   31.795388] [c000000006f97960] [c000000000d28dd8]
> > .radeon_bo_unref+0x58/0x90
> > [   31.801142] [c000000006f979e0] [c000000000e287b0]
> > .radeon_vm_fini+0x260/0x330
> > [   31.806982] [c000000006f97aa0] [c000000000d07c94]
> > .radeon_driver_postclose_kms+0x1a4/0x1f0
> > [   31.813954] [c000000006f97b30] [c000000000c9374c]
> > .drm_file_free+0x28c/0x300
> > [   31.819707] [c000000006f97be0] [c000000000c93900] .drm_release+0x90/0x170
> > [   31.825197] [c000000006f97c70] [c000000000304790] .__fput+0x120/0x3b0
> > [   31.830342] [c000000006f97d10] [c0000000002fe0fc]
> > .__se_sys_close+0x4c/0xc0
> > [   31.836010] [c000000006f97d90] [c000000000025bac]
> > .system_call_exception+0x22c/0x260
> > [   31.842460] [c000000006f97e10] [c00000000000b554]
> > system_call_common+0xf4/0x258
> > [   31.848476] --- interrupt: c00 at 0x6b2b48
> > [   31.851267] NIP:  00000000006b2b48 LR: 00000000006b2b20 CTR:
> > 0000000000000000
> > [   31.857101] REGS: c000000006f97e80 TRAP: 0c00   Not tainted
> > (6.12.0-rc1-2-powerpc64-smp)
> > [   31.863978] MSR:  100000000200f032 <HV,VEC,EE,PR,FP,ME,IR,DR,RI>  CR:
> > 28002400  XER: 00000000
> > [   31.871235] IRQMASK: 0
> >                 GPR00: 0000000000000006 00000000fff4b3d0
> > 00000000f7b7f3a0 0000000000000003
> >                 GPR04: 0000000000000000 0000000000000000
> > 0000000000000000 0000000000000000
> >                 GPR08: 0000000000000000 0000000000000000
> > 0000000000000000 0000000000000000
> >                 GPR12: 0000000000000000 00000000007efff4
> > 0000000000000000 0000000000000000
> >                 GPR16: 00000000006e3318 0000000000000001
> > 00000000006e289c 0000000000000063
> >                 GPR20: 00000000c04064a0 00000000007f0088
> > 00000000fff4c734 00000000007d165c
> >                 GPR24: 00000000007d1668 00000000fff4b400
> > 0000000000000001 0000000000000001
> >                 GPR28: 00000000fff4b46c 0000000000000000
> > 00000000007bfff4 0000000000000003
> > [   31.926053] NIP [00000000006b2b48] 0x6b2b48
> > [   31.928930] LR [00000000006b2b20] 0x6b2b20
> > [   31.931720] --- interrupt: c00
> > [   31.933466] Code: ebe1fff8 7c0803a6 4e800020 60000000 7c0802a6
> > fbe1fff8 7c7f1b78 f8010010 f821ff81 60000000 60000000 e93f0140
> > <e9290000> 7d2a0074 794ad182 0b0a0000
> > [   31.946913] ---[ end trace 0000000000000000 ]---
> >
> >
>
> That's a NULL pointer dereference in drm_gem_object_free().
>
> Trying to read obj->funcs->free while obj->funcs is NULL.
>
> Christophe

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-10-07 14:09 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-03  6:06 [PATCH] drm/radeon: add late_register for connector Wu Hoi Pok
2024-10-03 15:54 ` Alex Deucher
2024-10-03 17:48   ` Hans de Goede
     [not found] ` <d2704a2b-ceb2-4919-81d3-f6ff58a734fe@xenosoft.de>
2024-10-06 17:37   ` Christophe Leroy
2024-10-06 18:01     ` Christian Zigotzky
2024-10-07  3:19       ` Kernel doesn't boot after DRM updates (drm-next-2024-09-19) Christian Zigotzky
2024-10-07  4:49     ` [PATCH] drm/radeon: add late_register for connector Hoi Pok Wu
2024-10-07 14:08       ` Christian König
2024-10-07 13:17     ` Alex Deucher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®