mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Meelis Roos <mroos@linux.ee>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	Networking <netdev@vger.kernel.org>
Subject: Re: bisected: 4.18-rc* regression: x86-32 troubles (with timers?)
Date: Tue, 24 Jul 2018 00:04:27 +0200	[thread overview]
Message-ID: <4a48811d-4094-ee4c-33ca-2cf0446a6313@iogearbox.net> (raw)
In-Reply-To: <alpine.LRH.2.21.1807232322430.11834@math.ut.ee>

On 07/23/2018 10:34 PM, Meelis Roos wrote:
>>>> Now this seems more relevant:
>>>>
>>>> mroos@rx100s2:~/linux$ nice git bisect good
>>>> 24dea04767e6e5175f4750770281b0c17ac6a2fb is the first bad commit
>>>> commit 24dea04767e6e5175f4750770281b0c17ac6a2fb
>>>> Author: Daniel Borkmann <daniel@iogearbox.net>
>>>> Date:   Fri May 4 01:08:23 2018 +0200
>>>>
>>>>     bpf, x32: remove ld_abs/ld_ind
>>>>
>>>>     Since LD_ABS/LD_IND instructions are now removed from the core and
>>>>     reimplemented through a combination of inlined BPF instructions and
>>>>     a slow-path helper, we can get rid of the complexity from x32 JIT.
>>>
>>> This does seem much more likely than the previous bisection, given
>>> that you ended up in an x86-32 specific commit (the subject says x32,
>>> but that is a mistake). I also checked that systemd indeed does
>>> call into bpf in a number of places, possibly for the journald socket.
>>>
>>> OTOH, it's still hard to tell how that commit can have ended up
>>> corrupting the clock read function in systemd. To cross-check,
>>> could you try reverting that commit on the latest kernel and see
>>> if it still works?
>>
>> I would be curious as well about that whether revert would make it
>> work. What's the value of sysctl net.core.bpf_jit_enable ? Does it
>> change anything if you set it to 0 (only interpreter) or 1 (JIT
>> enabled). Seems a bit strange to me that bisect ended at this commit
>> given the issue you have. The JIT itself was also new in this window
>> fwiw. In any case some more debug info would be great to have.
> 
> net.core.bpf_jit_enable is 1.
> 
> Since it breaks bootup, I can not easily change the value at runtime (it 
> would be postfactum). Do you mean changing the 
> CONFIG_BPF_JIT_ALWAYS_ON=y option?

Yeah if you chance it to N, and don't have any fixed /etc/sysctl.conf
setting, then you'll boot up with interpreter first (net.core.bpf_jit_enable
as 0). Curious whether that works just fine for you.

> Anyway, I started compile of v4.18-rc5 that was the latest I tested, 
> with the commit in question reverted. Will see if I can test tomorrow 
> morning. But I will leave tomorrow for a week and can only test further 
> things if they happen to boot fine (no manual reboot possible for a 
> week).

Ok, thanks, please keep us posted on the outcome with the revert. Right
now I would doubt it's related resp. changes anything on the issue, but
lets see.

Thanks,
Daniel

  reply	other threads:[~2018-07-23 22:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-04 11:41 Meelis Roos
2018-07-04 21:02 ` Arnd Bergmann
2018-07-05  9:54   ` Meelis Roos
2018-07-05 11:04     ` Arnd Bergmann
2018-07-15 15:05     ` Meelis Roos
2018-07-15 20:51       ` Arnd Bergmann
2018-07-16 16:49         ` Meelis Roos
2018-07-16 19:00           ` Meelis Roos
2018-07-20 20:56             ` Meelis Roos
2018-07-20 23:01               ` bisected: " Meelis Roos
2018-07-23 16:03                 ` Arnd Bergmann
2018-07-23 19:41                   ` Daniel Borkmann
2018-07-23 20:34                     ` Meelis Roos
2018-07-23 22:04                       ` Daniel Borkmann [this message]
2018-07-24  4:47                         ` Meelis Roos
2018-07-24 18:40                           ` Daniel Borkmann
2018-07-24  6:11                         ` Meelis Roos
2018-07-10  9:30 ` Pavel Machek
2018-07-10  9:32 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a48811d-4094-ee4c-33ca-2cf0446a6313@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroos@linux.ee \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®