From: Joe Perches <joe@perches.com>
To: federico.vaga@cern.ch, Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org
Subject: Re: report: scripts: checkpatch: Spell Checker Does Not Run with '-f'
Date: Thu, 14 Feb 2019 06:44:55 -0800 [thread overview]
Message-ID: <4a6844c41d187d113e0c54dd156ba91c2635c361.camel@perches.com> (raw)
In-Reply-To: <3030138.e1gdHPWlgN@pcbe13614>
On Thu, 2019-02-14 at 13:48 +0100, Federico Vaga wrote:
> Hello,
>
> Recently I have produce a couple of patches but I get different warnings if I
> run checkpatch on the file (-f) or if I run it of a patch file. In particular,
> the problem I found is with the spell checker which seems to run only when the
> option '-f' is not used. I am wandering if there are other similar cases.
>
> I do not know Perl, so I cannot investigate more, but I have a practical
> example. I have this simple patch applied on my tree that introduces a spell
> error:
If you want spelling fixes on files you have to use --strict
>
> From: Federico Vaga <federico.vaga@cern.ch>
> Date: Thu, 14 Feb 2019 13:29:39 +0100
> Subject: [PATCH] script: checkpatch: buggy(?) output with -f option
>
> Signed-off-by: Federico Vaga <federico.vaga@cern.ch>
> ---
> drivers/i2c/busses/i2c-ocores.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
> index b32d67c..f4deb90 100644
> --- a/drivers/i2c/busses/i2c-ocores.c
> +++ b/drivers/i2c/busses/i2c-ocores.c
> @@ -301,7 +301,7 @@ static int ocores_poll_wait(struct ocores_i2c *i2c)
> /* on going transfer */
> mask = OCI2C_STAT_TIP;
> /*
> - * We wait for the data to be transferred (8bit),
> + * We wait for the data to be transfered (8bit),
> * then we start polling on the ACK/NACK bit
> */
> udelay((8 * 1000) / i2c->bus_clock_khz);
next prev parent reply other threads:[~2019-02-14 14:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 12:48 Federico Vaga
2019-02-14 14:44 ` Joe Perches [this message]
2019-02-14 15:03 ` Federico Vaga
2019-02-14 15:19 ` Joe Perches
2019-02-14 15:22 ` Federico Vaga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a6844c41d187d113e0c54dd156ba91c2635c361.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=federico.vaga@cern.ch \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®