mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: federico.vaga@cern.ch
Cc: Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: report: scripts: checkpatch: Spell Checker Does Not Run with '-f'
Date: Thu, 14 Feb 2019 07:19:36 -0800	[thread overview]
Message-ID: <d9ad7fb05178dd9afb4906cacdb03f86802c23c3.camel@perches.com> (raw)
In-Reply-To: <2899994.xJFnvJAAA5@pcbe13614>

On Thu, 2019-02-14 at 16:03 +0100, Federico Vaga wrote:
> On Thursday, February 14, 2019 3:44:55 PM CET Joe Perches wrote:
> > On Thu, 2019-02-14 at 13:48 +0100, Federico Vaga wrote:
> > > Hello,
> > > 
> > > Recently I have produce a couple of patches but I get different warnings
> > > if I run checkpatch on the file (-f) or if I run it of a patch file. In
> > > particular, the problem I found is with the spell checker which seems to
> > > run only when the option '-f' is not used. I am wandering if there are
> > > other similar cases.
> > > 
> > > I do not know Perl, so I cannot investigate more, but I have a practical
> > > example. I have this simple patch applied on my tree that introduces a
> > > spell
> > > error:
> > If you want spelling fixes on files you have to use --strict
> 
> Thanks
> 
> Is it a design choice to have different checks enabled with '-f'? 

Yes.

It was for a minimization of churn.

commit 66b47b4a9dad00e45c049d79966de9a3a1f4d337
Author: Kees Cook <keescook@chromium.org>
Date:   Mon Oct 13 15:51:57 2014 -0700

    checkpatch: look for common misspellings
    
    Check for misspellings, based on Debian's lintian list.  Several false
    positives were removed, and several additional words added that were
    common in the kernel:
    
            backword backwords
            invalide valide
            recieves
            singed unsinged
    
    While going back and fixing existing spelling mistakes isn't a high
    priority, it'd be nice to try to catch them before they hit the tree.



  reply	other threads:[~2019-02-14 15:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14 12:48 Federico Vaga
2019-02-14 14:44 ` Joe Perches
2019-02-14 15:03   ` Federico Vaga
2019-02-14 15:19     ` Joe Perches [this message]
2019-02-14 15:22       ` Federico Vaga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9ad7fb05178dd9afb4906cacdb03f86802c23c3.camel@perches.com \
    --to=joe@perches.com \
    --cc=apw@canonical.com \
    --cc=federico.vaga@cern.ch \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®