* Re: [PATCH v2] lib: fix incomplete comment in refcount_dec_and_lock_irqsave()
@ 2020-09-21 11:41 linmiaohe
0 siblings, 0 replies; 3+ messages in thread
From: linmiaohe @ 2020-09-21 11:41 UTC (permalink / raw)
To: Will Deacon; +Cc: ardb, keescook, mingo, linux-kernel
Will Deacon <will@kernel.org> wrote:
> On Mon, Sep 21, 2020 at 07:23:58AM -0400, Miaohe Lin wrote:
>> The description of arg flags is incomplete. The flags is saved
>> IRQ-flags when the @lock is acquired.
>>
>> + * @flags: saved IRQ-flags if the is @lock acquired
>
>This still isn't quite right. If we go with:
>
> @flags: saved IRQ-flags if @lock is acquired
>
This is what I mean to do... Sorry for this overlook.
>then:
>
>Acked-by: Will Deacon <will@kernel.org>
>
>Will
Thanks for acked-by tag and kindly reply.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] lib: fix incomplete comment in refcount_dec_and_lock_irqsave()
@ 2020-09-21 11:23 Miaohe Lin
2020-09-21 11:31 ` Will Deacon
0 siblings, 1 reply; 3+ messages in thread
From: Miaohe Lin @ 2020-09-21 11:23 UTC (permalink / raw)
To: ardb, will, keescook, mingo; +Cc: linux-kernel, linmiaohe
The description of arg flags is incomplete. The flags is saved IRQ-flags
when the @lock is acquired.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
lib/refcount.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/refcount.c b/lib/refcount.c
index ebac8b7d15a7..dcfd092f66c7 100644
--- a/lib/refcount.c
+++ b/lib/refcount.c
@@ -161,7 +161,7 @@ EXPORT_SYMBOL(refcount_dec_and_lock);
* interrupts if able to decrement refcount to 0
* @r: the refcount
* @lock: the spinlock to be locked
- * @flags: saved IRQ-flags if the is acquired
+ * @flags: saved IRQ-flags if the is @lock acquired
*
* Same as refcount_dec_and_lock() above except that the spinlock is acquired
* with disabled interupts.
--
2.19.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] lib: fix incomplete comment in refcount_dec_and_lock_irqsave()
2020-09-21 11:23 Miaohe Lin
@ 2020-09-21 11:31 ` Will Deacon
0 siblings, 0 replies; 3+ messages in thread
From: Will Deacon @ 2020-09-21 11:31 UTC (permalink / raw)
To: Miaohe Lin; +Cc: ardb, keescook, mingo, linux-kernel
On Mon, Sep 21, 2020 at 07:23:58AM -0400, Miaohe Lin wrote:
> The description of arg flags is incomplete. The flags is saved IRQ-flags
> when the @lock is acquired.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> lib/refcount.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/refcount.c b/lib/refcount.c
> index ebac8b7d15a7..dcfd092f66c7 100644
> --- a/lib/refcount.c
> +++ b/lib/refcount.c
> @@ -161,7 +161,7 @@ EXPORT_SYMBOL(refcount_dec_and_lock);
> * interrupts if able to decrement refcount to 0
> * @r: the refcount
> * @lock: the spinlock to be locked
> - * @flags: saved IRQ-flags if the is acquired
> + * @flags: saved IRQ-flags if the is @lock acquired
This still isn't quite right. If we go with:
@flags: saved IRQ-flags if @lock is acquired
then:
Acked-by: Will Deacon <will@kernel.org>
Will
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-21 11:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 11:41 [PATCH v2] lib: fix incomplete comment in refcount_dec_and_lock_irqsave() linmiaohe
-- strict thread matches above, loose matches on Subject: below --
2020-09-21 11:23 Miaohe Lin
2020-09-21 11:31 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®