From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Val Packett <val@packett.cool>,
nacht@dxdmail.cc, Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Aaron Kling <webgeek1234@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm8550: Add missing CPU7 3.36GHz OPP
Date: Thu, 5 Nov 2026 08:58:52 +0100 [thread overview]
Message-ID: <4a733192-37c5-459a-9fee-079f8f813b8b@oss.qualcomm.com> (raw)
In-Reply-To: <ef120d58-fb97-4c67-a29b-6b9b07839227@packett.cool>
On 11/4/26 10:24 PM, Val Packett wrote:
>
> On 11/4/26 4:41 PM, Nizat Mikayilli via B4 Relay wrote:
>> From: Nizat Mikayilli <nacht@dxdmail.cc>
>>
>> The cpufreq LUT on the Samsung Galaxy Tab S9 Wi-Fi has a 3.36GHz boost
>> entry for CPU7 without a matching OPP, so the frequency is dropped:
>>
>> cpu cpu7: Voltage update failed freq=3360000
>> cpu cpu7: failed to update OPP for freq=3360000
>>
>> Fixes: 3f5dcc05cd33 ("arm64: dts: qcom: sm8550: add cpu OPP table with DDR, LLCC & L3 bandwidths")
>> Signed-off-by: Nizat Mikayilli <nacht@dxdmail.cc>
>> ---
>> arch/arm64/boot/dts/qcom/sm8550.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
>> index 03f6d40edea7..ed6e34ac8d56 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
>> @@ -752,6 +752,11 @@ opp-3187200000 {
>> opp-hz = /bits/ 64 <3187200000>;
>> opp-peak-kBps = <(933000 * 16) (3686000 * 4) (1689600 * 32)>;
>> };
>> +
>> + opp-3360000000 {
>> + opp-hz = /bits/ 64 <3360000000>;
>> + opp-peak-kBps = <(933000 * 16) (3686000 * 4) (1689600 * 32)>;
>> + };
>> };
>> pmu-a510 {
>>
> This seems variant/speedbin dependent and does not apply to all sm8550.
>
> In fact a quick web search shows that your device has a "Snapdragon 8 Gen 2 for Galaxy" which is a customized chip for Smasnug.
>
> You should just add the OPP in your tablet's .dts I think.
It's fine to have a superset of supported frequencies in this OPP table,
the frequencies available are retrieved from the LUT exposed by the
microcontroller anyway
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
prev parent reply other threads:[~2026-11-05 7:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 19:41 Nizat Mikayilli via B4 Relay
2026-11-04 21:24 ` Val Packett
2026-11-05 7:58 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a733192-37c5-459a-9fee-079f8f813b8b@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nacht@dxdmail.cc \
--cc=robh@kernel.org \
--cc=val@packett.cool \
--cc=webgeek1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®