mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: sm8550: Add missing CPU7 3.36GHz OPP
@ 2026-11-04 19:41 Nizat Mikayilli via B4 Relay
  2026-11-04 21:24 ` Val Packett
  0 siblings, 1 reply; 3+ messages in thread
From: Nizat Mikayilli via B4 Relay @ 2026-11-04 19:41 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Aaron Kling, Dmitry Baryshkov
  Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel, Nizat Mikayilli

From: Nizat Mikayilli <nacht@dxdmail.cc>

The cpufreq LUT on the Samsung Galaxy Tab S9 Wi-Fi has a 3.36GHz boost
entry for CPU7 without a matching OPP, so the frequency is dropped:

cpu cpu7: Voltage update failed freq=3360000
cpu cpu7: failed to update OPP for freq=3360000

Fixes: 3f5dcc05cd33 ("arm64: dts: qcom: sm8550: add cpu OPP table with DDR, LLCC & L3 bandwidths")
Signed-off-by: Nizat Mikayilli <nacht@dxdmail.cc>
---
 arch/arm64/boot/dts/qcom/sm8550.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index 03f6d40edea7..ed6e34ac8d56 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -752,6 +752,11 @@ opp-3187200000 {
 			opp-hz = /bits/ 64 <3187200000>;
 			opp-peak-kBps = <(933000 * 16) (3686000 * 4) (1689600 * 32)>;
 		};
+
+		opp-3360000000 {
+			opp-hz = /bits/ 64 <3360000000>;
+			opp-peak-kBps = <(933000 * 16) (3686000 * 4) (1689600 * 32)>;
+		};
 	};
 
 	pmu-a510 {

---
base-commit: f5672a3dff0291d6a45eb0c258b9d2baeb4dc577
change-id: 20261104-sm8550-prime-3p36ghz-77ece710cc0d

Best regards,
-- 
Nizat Mikayilli <nacht@dxdmail.cc>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: sm8550: Add missing CPU7 3.36GHz OPP
  2026-11-04 19:41 [PATCH] arm64: dts: qcom: sm8550: Add missing CPU7 3.36GHz OPP Nizat Mikayilli via B4 Relay
@ 2026-11-04 21:24 ` Val Packett
  2026-11-05  7:58   ` Konrad Dybcio
  0 siblings, 1 reply; 3+ messages in thread
From: Val Packett @ 2026-11-04 21:24 UTC (permalink / raw)
  To: nacht, Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Aaron Kling, Dmitry Baryshkov
  Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel


On 11/4/26 4:41 PM, Nizat Mikayilli via B4 Relay wrote:
> From: Nizat Mikayilli <nacht@dxdmail.cc>
>
> The cpufreq LUT on the Samsung Galaxy Tab S9 Wi-Fi has a 3.36GHz boost
> entry for CPU7 without a matching OPP, so the frequency is dropped:
>
> cpu cpu7: Voltage update failed freq=3360000
> cpu cpu7: failed to update OPP for freq=3360000
>
> Fixes: 3f5dcc05cd33 ("arm64: dts: qcom: sm8550: add cpu OPP table with DDR, LLCC & L3 bandwidths")
> Signed-off-by: Nizat Mikayilli <nacht@dxdmail.cc>
> ---
>   arch/arm64/boot/dts/qcom/sm8550.dtsi | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index 03f6d40edea7..ed6e34ac8d56 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -752,6 +752,11 @@ opp-3187200000 {
>   			opp-hz = /bits/ 64 <3187200000>;
>   			opp-peak-kBps = <(933000 * 16) (3686000 * 4) (1689600 * 32)>;
>   		};
> +
> +		opp-3360000000 {
> +			opp-hz = /bits/ 64 <3360000000>;
> +			opp-peak-kBps = <(933000 * 16) (3686000 * 4) (1689600 * 32)>;
> +		};
>   	};
>   
>   	pmu-a510 {
>
This seems variant/speedbin dependent and does not apply to all sm8550.

In fact a quick web search shows that your device has a "Snapdragon 8 
Gen 2 for Galaxy" which is a customized chip for Smasnug.

You should just add the OPP in your tablet's .dts I think.


Thanks,
~val


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: sm8550: Add missing CPU7 3.36GHz OPP
  2026-11-04 21:24 ` Val Packett
@ 2026-11-05  7:58   ` Konrad Dybcio
  0 siblings, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2026-11-05  7:58 UTC (permalink / raw)
  To: Val Packett, nacht, Bjorn Andersson, Konrad Dybcio, Abel Vesa,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Aaron Kling,
	Dmitry Baryshkov
  Cc: linux-arm-msm, devicetree, linux-kernel

On 11/4/26 10:24 PM, Val Packett wrote:
> 
> On 11/4/26 4:41 PM, Nizat Mikayilli via B4 Relay wrote:
>> From: Nizat Mikayilli <nacht@dxdmail.cc>
>>
>> The cpufreq LUT on the Samsung Galaxy Tab S9 Wi-Fi has a 3.36GHz boost
>> entry for CPU7 without a matching OPP, so the frequency is dropped:
>>
>> cpu cpu7: Voltage update failed freq=3360000
>> cpu cpu7: failed to update OPP for freq=3360000
>>
>> Fixes: 3f5dcc05cd33 ("arm64: dts: qcom: sm8550: add cpu OPP table with DDR, LLCC & L3 bandwidths")
>> Signed-off-by: Nizat Mikayilli <nacht@dxdmail.cc>
>> ---
>>   arch/arm64/boot/dts/qcom/sm8550.dtsi | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
>> index 03f6d40edea7..ed6e34ac8d56 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
>> @@ -752,6 +752,11 @@ opp-3187200000 {
>>               opp-hz = /bits/ 64 <3187200000>;
>>               opp-peak-kBps = <(933000 * 16) (3686000 * 4) (1689600 * 32)>;
>>           };
>> +
>> +        opp-3360000000 {
>> +            opp-hz = /bits/ 64 <3360000000>;
>> +            opp-peak-kBps = <(933000 * 16) (3686000 * 4) (1689600 * 32)>;
>> +        };
>>       };
>>         pmu-a510 {
>>
> This seems variant/speedbin dependent and does not apply to all sm8550.
> 
> In fact a quick web search shows that your device has a "Snapdragon 8 Gen 2 for Galaxy" which is a customized chip for Smasnug.
> 
> You should just add the OPP in your tablet's .dts I think.

It's fine to have a superset of supported frequencies in this OPP table,
the frequencies available are retrieved from the LUT exposed by the
microcontroller anyway

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-05  7:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-04 19:41 [PATCH] arm64: dts: qcom: sm8550: Add missing CPU7 3.36GHz OPP Nizat Mikayilli via B4 Relay
2026-11-04 21:24 ` Val Packett
2026-11-05  7:58   ` Konrad Dybcio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®