mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Zi Yan <ziy@nvidia.com>
Cc: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>,
	linux-mm@kvack.org, akpm@linux-foundation.org, vbabka@suse.cz,
	surenb@google.com, mhocko@suse.com, jackmanb@google.com,
	hannes@cmpxchg.org, npiggin@gmail.com,
	linux-kernel@vger.kernel.org, kasong@tencent.com,
	hughd@google.com, chrisl@kernel.org, ryncsn@gmail.com,
	stable@vger.kernel.org, willy@infradead.org
Subject: Re: [PATCH v3] mm/page_alloc: clear page->private in free_pages_prepare()
Date: Mon, 9 Feb 2026 20:39:22 +0100	[thread overview]
Message-ID: <4a759288-baf9-4fe6-9d16-034edf6615f0@kernel.org> (raw)
In-Reply-To: <3E055DAD-647A-456B-9230-4DD2574D4E8E@nvidia.com>

On 2/9/26 18:44, Zi Yan wrote:
> On 9 Feb 2026, at 12:36, David Hildenbrand (Arm) wrote:
> 
>> On 2/9/26 17:33, Zi Yan wrote:
>>>
>>>
>>> I agree. Silently fixing non zero ->private just moves the work/responsibility
>>> from users to core mm. They could do better. :)
>>>
>>> We can have a patch or multiple patches to fix users do not zero ->private
>>> when freeing a page and add the patch below.
>>
>> Do we know roughly which ones don't zero it out?
> 
> So far based on [1], I found:
> 
> 1. shmem_swapin_folio() in mm/shmem.c does not zero ->swap.val (overlapping
> with private);
> 2. __free_slab() in mm/slub.c does not zero ->inuse, ->objects, ->frozen
> (overlapping with private).
> 
> Mikhail found ttm_pool_unmap_and_free() in drivers/gpu/drm/ttm/ttm_pool.c
> does not zero ->private, which stores page order.
>

Looks doable then :) Should we take v3 as a quick fix to backport then?

-- 
Cheers,

David

  reply	other threads:[~2026-02-09 19:39 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <209207FE-D3A9-4BE2-8DA7-9BE38A19F387@nvidia.com>
2026-02-07 17:36 ` Mikhail Gavrilov
2026-02-07 22:02   ` David Hildenbrand (Arm)
2026-02-07 22:08     ` David Hildenbrand (Arm)
2026-02-09 11:17       ` Vlastimil Babka
2026-02-09 15:46         ` David Hildenbrand (Arm)
2026-02-09 16:00           ` Zi Yan
2026-02-09 16:03             ` David Hildenbrand (Arm)
2026-02-09 16:05               ` Zi Yan
2026-02-09 16:06                 ` David Hildenbrand (Arm)
2026-02-09 16:08                   ` Zi Yan
2026-02-07 23:00     ` Zi Yan
2026-02-09 16:16       ` David Hildenbrand (Arm)
2026-02-09 16:20         ` David Hildenbrand (Arm)
2026-02-09 16:33           ` Zi Yan
2026-02-09 17:36             ` David Hildenbrand (Arm)
2026-02-09 17:44               ` Zi Yan
2026-02-09 19:39                 ` David Hildenbrand (Arm) [this message]
2026-02-09 19:42                   ` Zi Yan
2026-02-10  1:20                     ` Baolin Wang
2026-02-10  2:12                       ` Zi Yan
2026-02-10  2:25                         ` Baolin Wang
2026-02-10  2:32                           ` Zi Yan
2026-02-09 19:46   ` David Hildenbrand (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a759288-baf9-4fe6-9d16-034edf6615f0@kernel.org \
    --to=david@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=chrisl@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=jackmanb@google.com \
    --cc=kasong@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=mikhail.v.gavrilov@gmail.com \
    --cc=npiggin@gmail.com \
    --cc=ryncsn@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome