mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>, linux-mm@kvack.org
Cc: akpm@linux-foundation.org, vbabka@suse.cz, surenb@google.com,
	mhocko@suse.com, jackmanb@google.com, hannes@cmpxchg.org,
	ziy@nvidia.com, npiggin@gmail.com, linux-kernel@vger.kernel.org,
	kasong@tencent.com, hughd@google.com, chrisl@kernel.org,
	ryncsn@gmail.com, stable@vger.kernel.org, willy@infradead.org
Subject: Re: [PATCH v3] mm/page_alloc: clear page->private in free_pages_prepare()
Date: Mon, 9 Feb 2026 20:46:06 +0100	[thread overview]
Message-ID: <7e86e2f0-e581-4772-b468-1da04a214f07@kernel.org> (raw)
In-Reply-To: <20260207173615.146159-1-mikhail.v.gavrilov@gmail.com>

On 2/7/26 18:36, Mikhail Gavrilov wrote:
> Several subsystems (slub, shmem, ttm, etc.) use page->private but don't
> clear it before freeing pages. When these pages are later allocated as
> high-order pages and split via split_page(), tail pages retain stale
> page->private values.
> 
> This causes a use-after-free in the swap subsystem. The swap code uses
> page->private to track swap count continuations, assuming freshly
> allocated pages have page->private == 0. When stale values are present,
> swap_count_continued() incorrectly assumes the continuation list is valid
> and iterates over uninitialized page->lru containing LIST_POISON values,
> causing a crash:
> 
>    KASAN: maybe wild-memory-access in range [0xdead000000000100-0xdead000000000107]
>    RIP: 0010:__do_sys_swapoff+0x1151/0x1860
> 
> Fix this by clearing page->private in free_pages_prepare(), ensuring all
> freed pages have clean state regardless of previous use.
> 
> Fixes: 3b8000ae185c ("mm/vmalloc: huge vmalloc backing pages should be split rather than compound")
> Cc: stable@vger.kernel.org
> Suggested-by: Zi Yan <ziy@nvidia.com>
> Acked-by: Zi Yan <ziy@nvidia.com>
> Signed-off-by: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
> ---

Okay, let's do this as a fix, and cleanup the page->private handling 
separately.

Thanks!

Acked-by: David Hildenbrand (Arm) <david@kernel.org>

-- 
Cheers,

David

      parent reply	other threads:[~2026-02-09 19:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <209207FE-D3A9-4BE2-8DA7-9BE38A19F387@nvidia.com>
2026-02-07 17:36 ` Mikhail Gavrilov
2026-02-07 22:02   ` David Hildenbrand (Arm)
2026-02-07 22:08     ` David Hildenbrand (Arm)
2026-02-09 11:17       ` Vlastimil Babka
2026-02-09 15:46         ` David Hildenbrand (Arm)
2026-02-09 16:00           ` Zi Yan
2026-02-09 16:03             ` David Hildenbrand (Arm)
2026-02-09 16:05               ` Zi Yan
2026-02-09 16:06                 ` David Hildenbrand (Arm)
2026-02-09 16:08                   ` Zi Yan
2026-02-07 23:00     ` Zi Yan
2026-02-09 16:16       ` David Hildenbrand (Arm)
2026-02-09 16:20         ` David Hildenbrand (Arm)
2026-02-09 16:33           ` Zi Yan
2026-02-09 17:36             ` David Hildenbrand (Arm)
2026-02-09 17:44               ` Zi Yan
2026-02-09 19:39                 ` David Hildenbrand (Arm)
2026-02-09 19:42                   ` Zi Yan
2026-02-10  1:20                     ` Baolin Wang
2026-02-10  2:12                       ` Zi Yan
2026-02-10  2:25                         ` Baolin Wang
2026-02-10  2:32                           ` Zi Yan
2026-02-09 19:46   ` David Hildenbrand (Arm) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e86e2f0-e581-4772-b468-1da04a214f07@kernel.org \
    --to=david@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=chrisl@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=jackmanb@google.com \
    --cc=kasong@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=mikhail.v.gavrilov@gmail.com \
    --cc=npiggin@gmail.com \
    --cc=ryncsn@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome