From: Andrew Lunn <andrew@lunn.ch>
To: Matheus Alves de Almeida <matheus.aalmeida@inf.ufrgs.br>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
nic_swsd@realtek.com, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] r8169: propagate errors from PHY write operations
Date: Wed, 16 Sep 2026 23:14:36 +0200 [thread overview]
Message-ID: <4a9c817f-e8b5-455b-8e78-a57cb6bcdaec@lunn.ch> (raw)
In-Reply-To: <02943cee3bbe56fafe76a98eeb78c682@inf.ufrgs.br>
On Wed, Sep 16, 2026 at 06:10:00PM -0300, Matheus Alves de Almeida wrote:
> > Maybe rewrite rtl_loop_wait_low(), _high() and rtl_loop_wait() to use
> > iopoll.h?
>
> While I don’t think this fits the scope of this series, I’d be willing
> to look into it as a follow-up.
You trimmed too much context.
The nice thing about iopoll.h is that they all return -ETIMEDOUT, or
some other error code on error. So your current patch looking at the
Boolean return value becomes redundant, you just follow the normal
pattern:
ret = rtl_loop_wait_low();
if (ret)
return ret;
So i think this is in scope, otherwise you are going to rewrite 90% of
this patch when you do introduce it.
Andrew
next prev parent reply other threads:[~2026-09-16 21:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 15:24 [PATCH net-next 0/3] r8169: handle firmware application errors Matheus Alves de Almeida
2026-09-16 15:24 ` [PATCH net-next 1/3] r8169: propagate errors from PHY write operations Matheus Alves de Almeida
2026-09-16 18:38 ` Andrew Lunn
2026-09-16 21:10 ` Matheus Alves de Almeida
2026-09-16 21:14 ` Andrew Lunn [this message]
2026-09-16 21:19 ` Matheus Alves de Almeida
2026-09-16 15:24 ` [PATCH net-next 2/3] r8169: propagate firmware access errors Matheus Alves de Almeida
2026-09-16 15:24 ` [PATCH net-next 3/3] r8169: release firmware on application failure Matheus Alves de Almeida
2026-09-16 18:42 ` Andrew Lunn
2026-09-16 21:15 ` Matheus Alves de Almeida
2026-09-16 22:02 ` Andrew Lunn
2026-09-16 22:21 ` Matheus Alves de Almeida
2026-09-17 2:19 ` Matheus Alves de Almeida
2026-09-17 12:14 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a9c817f-e8b5-455b-8e78-a57cb6bcdaec@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matheus.aalmeida@inf.ufrgs.br \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®