mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Taniya Das <taniya.das@oss.qualcomm.com>
To: "Bryan O'Donoghue" <bod@kernel.org>,
	"Erikas Bitovtas" <xerikasxx@gmail.com>,
	"Vikash Garodia" <vikash.garodia@oss.qualcomm.com>,
	"Dikshita Agarwal" <dikshita.agarwal@oss.qualcomm.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"André Apitzsch" <git@apitzsch.eu>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Brian Masney" <bmasney@redhat.com>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org
Subject: Re: [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled
Date: Mon, 1 Jun 2026 13:59:52 +0530	[thread overview]
Message-ID: <4ab6aa28-6b0b-436f-95d3-23b54d73a992@oss.qualcomm.com> (raw)
In-Reply-To: <82f7a200-ab07-4ff4-b84e-305351f78460@kernel.org>



On 5/26/2026 4:20 AM, Bryan O'Donoghue wrote:
> On 25/05/2026 10:56, Erikas Bitovtas wrote:
>> +    for (; i < res->vcodec_pmdomains_num; i++) {
>> +        pd_dev = core->pmdomains->pd_devs[i];
>> +        ret = pm_runtime_resume_and_get(pd_dev);
>> +        if (ret)
>> +            goto err;
>> +
>> +        ret = dev_pm_genpd_set_hwmode(pd_dev, true);
>> +        if (ret && ret != -EOPNOTSUPP) {
>> +            pm_runtime_put_sync(pd_dev);
>> +            goto err;
>> +        }
>> +    }
> 
> In Iris we do
> 
> - enable_power_domains
> - enable_clocks
> - set hwmode
> 

This sequence will always ensure clock can be polled as the GDSC is
still in SW mode.


> Instead of
> 
> - enable_power_domains
> - set hwmode
> - enable clocks
> 

This sequence will require the clock to have SKIP or DELAY as the GDSC
is moved to HW mode and it is not guaranteed to match the SW expectation.


-- 
Thanks,
Taniya Das


  reply	other threads:[~2026-06-01  8:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 15:10 [PATCH v8 0/9] media: qcom: venus: add MSM8939 support Erikas Bitovtas
2026-05-19 15:10 ` [PATCH v8 1/9] media: dt-bindings: venus: Add qcom,msm8939 schema Erikas Bitovtas
2026-05-19 15:10 ` [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled Erikas Bitovtas
2026-05-20  8:32   ` Bryan O'Donoghue
2026-05-20  8:41     ` Bryan O'Donoghue
2026-05-21  9:29     ` Taniya Das
2026-05-22 10:48       ` Erikas Bitovtas
2026-05-25  5:51         ` Taniya Das
2026-05-25  9:56           ` Erikas Bitovtas
2026-05-25 10:38             ` Taniya Das
2026-05-25 22:50             ` Bryan O'Donoghue
2026-06-01  8:29               ` Taniya Das [this message]
2026-06-01  8:48                 ` Erikas Bitovtas
2026-05-19 15:10 ` [PATCH v8 3/9] media: qcom: venus: add power domain enable logic for Venus cores Erikas Bitovtas
2026-05-19 15:10 ` [PATCH v8 4/9] media: qcom: venus: add codec blacklist mechanism Erikas Bitovtas
2026-05-20  8:38   ` Bryan O'Donoghue
2026-05-19 15:10 ` [PATCH v8 5/9] media: qcom: venus: migrate MSM8916 to new " Erikas Bitovtas
2026-05-20  8:39   ` Bryan O'Donoghue
2026-05-20 12:45   ` Dmitry Baryshkov
2026-05-19 15:10 ` [PATCH v8 6/9] media: qcom: venus: Add msm8939 resource struct Erikas Bitovtas
2026-05-19 15:10 ` [PATCH v8 7/9] arm64: dts: qcom: msm8939: Add venus node Erikas Bitovtas
2026-05-19 15:10 ` [PATCH v8 8/9] arm64: dts: qcom: msm8939-longcheer-l9100: Enable " Erikas Bitovtas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ab6aa28-6b0b-436f-95d3-23b54d73a992@oss.qualcomm.com \
    --to=taniya.das@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=bmasney@redhat.com \
    --cc=bod@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dikshita.agarwal@oss.qualcomm.com \
    --cc=git@apitzsch.eu \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=vikash.garodia@oss.qualcomm.com \
    --cc=xerikasxx@gmail.com \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox