mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: srinivas.kandagatla@oss.qualcomm.com, andersson@kernel.org,
	konradybcio@kernel.org
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	cros-qcom-dts-watchers@chromium.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/23] arm64: dts: qcom: x1e80100: move dsp audio nodes to dedicated dts
Date: Thu, 24 Jul 2025 13:32:47 +0200	[thread overview]
Message-ID: <4ab97f28-ac2c-44d8-847c-d3a49e4f38a6@oss.qualcomm.com> (raw)
In-Reply-To: <20250723222737.35561-2-srinivas.kandagatla@oss.qualcomm.com>

On 7/24/25 12:27 AM, srinivas.kandagatla@oss.qualcomm.com wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> 
> All the device tree nodes for audioreach dsp are duplicated across all
> the SoC dtsi files, Move this to a dedicated dtsi file so to remove some
> duplication, make it consistent across all device trees and also make it
> easy for new SoC's to add audio support.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> ---

[...]

> -				gpr {
> -					compatible = "qcom,gpr";
> -					qcom,glink-channels = "adsp_apps";

This seems to never change, maybe we can add some internal bus-like
matching to glink that we could put a cookie in the GPR driver for?

> -					qcom,domain = <GPR_DOMAIN_ID_ADSP>;

Similarly, this never changes (unless call audio would go through
modem and require a similar structure or something, I really don't
know)

> -					qcom,intents = <512 20>;

This is also always the very same

> -					#address-cells = <1>;
> -					#size-cells = <0>;
> -
> -					q6apm: service@1 {
> -						compatible = "qcom,q6apm";
> -						reg = <GPR_APM_MODULE_IID>;
> -						#sound-dai-cells = <0>;
> -						qcom,protection-domain = "avs/audio",
> -									 "msm/adsp/audio_pd";

These never change either

Konrad

  parent reply	other threads:[~2025-07-24 11:32 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-23 22:27 [PATCH 00/23] arm64: dts: qcom: cleanup DSP audio services srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 01/23] arm64: dts: qcom: x1e80100: move dsp audio nodes to dedicated dts srinivas.kandagatla
2025-07-24  7:23   ` Stephan Gerhold
2025-07-24  9:50     ` Srinivas Kandagatla
2025-07-24 11:32   ` Konrad Dybcio [this message]
2025-07-23 22:27 ` [PATCH 02/23] arm64: dts: qcom: sc8280xp: use dedicated audioreach dtsi srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 03/23] arm64: dts: qcom: sm8650: " srinivas.kandagatla
2025-07-24  8:26   ` neil.armstrong
2025-07-24  9:54     ` Srinivas Kandagatla
2025-07-23 22:27 ` [PATCH 04/23] arm64: dts: qcom: sm8550: " srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 05/23] arm64: dts: qcom: sm8450: " srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 06/23] arm64: dts: qcom: sar2130p: " srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 07/23] arm64: dts: qcom: sm8350: move dsp audio nodes to dedicated dts srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 08/23] arm64: dts: qcom: sm8250: use dedicated elite dtsi srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 09/23] arm64: dts: qcom: sm6115: " srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 10/23] arm64: dts: qcom: sdm845: use dedicated elite-audio dtsi srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 11/23] arm64: dts: qcom: sdm630: " srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 12/23] arm64: dts: qcom: sc7280: " srinivas.kandagatla
2025-07-24  7:34   ` Stephan Gerhold
2025-07-23 22:27 ` [PATCH 13/23] arm64: dts: qcom: sc7180: " srinivas.kandagatla
2025-07-24  7:38   ` Stephan Gerhold
2025-07-24 10:41     ` Srinivas Kandagatla
2025-07-23 22:27 ` [PATCH 14/23] arm64: dts: qcom: sm8750: use dedicated audioreach dtsi srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 15/23] arm64: dts: qcom: msm8916: use dedicated elite-audio dtsi srinivas.kandagatla
2025-07-24  7:42   ` Stephan Gerhold
2025-07-23 22:27 ` [PATCH 16/23] arm64: dts: qcom: msm8939: " srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 17/23] arm64: dts: qcom: msm8996: " srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 18/23] arm64: dts: qcom: sm6350: " srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 19/23] arm64: dts: qcom: msm8953: " srinivas.kandagatla
2025-07-24  7:45   ` Stephan Gerhold
2025-07-23 22:27 ` [PATCH 20/23] arm64: dts: qcom: sm8450: add sound prefix for wsa2 srinivas.kandagatla
2025-07-23 22:44   ` Dmitry Baryshkov
2025-07-24  7:47     ` Stephan Gerhold
2025-07-23 22:27 ` [PATCH 21/23] arm64: dts: qcom: sm8550: " srinivas.kandagatla
2025-07-24  8:20   ` neil.armstrong
2025-07-23 22:27 ` [PATCH 22/23] arm64: dts: qcom: sm8750: " srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 23/23] arm64: dts: qcom: sm8650: " srinivas.kandagatla
2025-07-24  8:20   ` neil.armstrong
2025-07-25  3:19 ` [PATCH 00/23] arm64: dts: qcom: cleanup DSP audio services Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ab97f28-ac2c-44d8-847c-d3a49e4f38a6@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=srinivas.kandagatla@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®