mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: neil.armstrong@linaro.org
To: srinivas.kandagatla@oss.qualcomm.com, andersson@kernel.org,
	konradybcio@kernel.org
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	cros-qcom-dts-watchers@chromium.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/23] arm64: dts: qcom: sm8650: use dedicated audioreach dtsi
Date: Thu, 24 Jul 2025 10:26:16 +0200	[thread overview]
Message-ID: <93d80822-afa0-4bff-9e73-3ece36e8c23a@linaro.org> (raw)
In-Reply-To: <20250723222737.35561-4-srinivas.kandagatla@oss.qualcomm.com>

On 24/07/2025 00:27, srinivas.kandagatla@oss.qualcomm.com wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> 
> Make use of audioreach-audio.dtsi and remove the gpr nodes from SoC dtsi.
> This move removes duplication.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> ---
>   arch/arm64/boot/dts/qcom/sm8650-audio.dtsi | 10 +++++
>   arch/arm64/boot/dts/qcom/sm8650-hdk.dts    |  1 +
>   arch/arm64/boot/dts/qcom/sm8650-mtp.dts    |  1 +
>   arch/arm64/boot/dts/qcom/sm8650-qrd.dts    |  1 +
>   arch/arm64/boot/dts/qcom/sm8650.dtsi       | 43 ++--------------------
>   5 files changed, 16 insertions(+), 40 deletions(-)
>   create mode 100644 arch/arm64/boot/dts/qcom/sm8650-audio.dtsi
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8650-audio.dtsi b/arch/arm64/boot/dts/qcom/sm8650-audio.dtsi
> new file mode 100644
> index 000000000000..14ae50e72e4b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm8650-audio.dtsi
> @@ -0,0 +1,10 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2025 Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +#include "audioreach-audio.dtsi"
> +
> +&q6apmdai{
> +	iommus = <&apps_smmu 0x1001 0x80>,
> +		 <&apps_smmu 0x1061 0x0>;

As patch 1 comment, I'm not fan either of this intermediate dtsi, or perhaps there's
some bigger plans for those files ?

Anyway per-se, it's not necessary and it should be in the SoC dtsi.

Thanks,
Neil

> +};
> diff --git a/arch/arm64/boot/dts/qcom/sm8650-hdk.dts b/arch/arm64/boot/dts/qcom/sm8650-hdk.dts
> index 259649d7dcd7..94fa52437d79 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8650-hdk.dts
> @@ -8,6 +8,7 @@
>   #include <dt-bindings/leds/common.h>
>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>   #include "sm8650.dtsi"
> +#include "sm8650-audio.dtsi"
>   #include "pm8010.dtsi"
>   #include "pm8550.dtsi"
>   #include "pm8550b.dtsi"
> diff --git a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
> index 8a957adbfb38..07e62918422e 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
> @@ -7,6 +7,7 @@
>   
>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>   #include "sm8650.dtsi"
> +#include "sm8650-audio.dtsi"
>   #include "pm8010.dtsi"
>   #include "pm8550.dtsi"
>   #include "pm8550b.dtsi"
> diff --git a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts
> index 7552d5d3fb40..7f26095e6f07 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts
> @@ -8,6 +8,7 @@
>   #include <dt-bindings/leds/common.h>
>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>   #include "sm8650.dtsi"
> +#include "sm8650-audio.dtsi"
>   #include "pm8010.dtsi"
>   #include "pm8550.dtsi"
>   #include "pm8550b.dtsi"
> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> index e14d3d778b71..5212000bf34c 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> @@ -23,7 +23,6 @@
>   #include <dt-bindings/power/qcom,rpmhpd.h>
>   #include <dt-bindings/power/qcom-rpmpd.h>
>   #include <dt-bindings/reset/qcom,sm8650-gpucc.h>
> -#include <dt-bindings/soc/qcom,gpr.h>
>   #include <dt-bindings/soc/qcom,rpmh-rsc.h>
>   #include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h>
>   #include <dt-bindings/thermal/thermal.h>
> @@ -4447,6 +4446,9 @@ IPCC_MPROC_SIGNAL_GLINK_QMP
>   
>   				label = "lpass";
>   
> +				gpr: gpr {
> +				};
> +
>   				fastrpc {
>   					compatible = "qcom,fastrpc";
>   
> @@ -4506,45 +4508,6 @@ compute-cb@7 {
>   					};
>   				};
>   
> -				gpr {
> -					compatible = "qcom,gpr";
> -					qcom,glink-channels = "adsp_apps";
> -					qcom,domain = <GPR_DOMAIN_ID_ADSP>;
> -					qcom,intents = <512 20>;
> -					#address-cells = <1>;
> -					#size-cells = <0>;
> -
> -					q6apm: service@1 {
> -						compatible = "qcom,q6apm";
> -						reg = <GPR_APM_MODULE_IID>;
> -						#sound-dai-cells = <0>;
> -						qcom,protection-domain = "avs/audio",
> -									 "msm/adsp/audio_pd";
> -
> -						q6apmbedai: bedais {
> -							compatible = "qcom,q6apm-lpass-dais";
> -							#sound-dai-cells = <1>;
> -						};
> -
> -						q6apmdai: dais {
> -							compatible = "qcom,q6apm-dais";
> -							iommus = <&apps_smmu 0x1001 0x80>,
> -								 <&apps_smmu 0x1061 0x0>;
> -						};
> -					};
> -
> -					q6prm: service@2 {
> -						compatible = "qcom,q6prm";
> -						reg = <GPR_PRM_MODULE_IID>;
> -						qcom,protection-domain = "avs/audio",
> -									 "msm/adsp/audio_pd";
> -
> -						q6prmcc: clock-controller {
> -							compatible = "qcom,q6prm-lpass-clocks";
> -							#clock-cells = <2>;
> -						};
> -					};
> -				};
>   			};
>   		};
>   


  reply	other threads:[~2025-07-24  8:26 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-23 22:27 [PATCH 00/23] arm64: dts: qcom: cleanup DSP audio services srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 01/23] arm64: dts: qcom: x1e80100: move dsp audio nodes to dedicated dts srinivas.kandagatla
2025-07-24  7:23   ` Stephan Gerhold
2025-07-24  9:50     ` Srinivas Kandagatla
2025-07-24 11:32   ` Konrad Dybcio
2025-07-23 22:27 ` [PATCH 02/23] arm64: dts: qcom: sc8280xp: use dedicated audioreach dtsi srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 03/23] arm64: dts: qcom: sm8650: " srinivas.kandagatla
2025-07-24  8:26   ` neil.armstrong [this message]
2025-07-24  9:54     ` Srinivas Kandagatla
2025-07-23 22:27 ` [PATCH 04/23] arm64: dts: qcom: sm8550: " srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 05/23] arm64: dts: qcom: sm8450: " srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 06/23] arm64: dts: qcom: sar2130p: " srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 07/23] arm64: dts: qcom: sm8350: move dsp audio nodes to dedicated dts srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 08/23] arm64: dts: qcom: sm8250: use dedicated elite dtsi srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 09/23] arm64: dts: qcom: sm6115: " srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 10/23] arm64: dts: qcom: sdm845: use dedicated elite-audio dtsi srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 11/23] arm64: dts: qcom: sdm630: " srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 12/23] arm64: dts: qcom: sc7280: " srinivas.kandagatla
2025-07-24  7:34   ` Stephan Gerhold
2025-07-23 22:27 ` [PATCH 13/23] arm64: dts: qcom: sc7180: " srinivas.kandagatla
2025-07-24  7:38   ` Stephan Gerhold
2025-07-24 10:41     ` Srinivas Kandagatla
2025-07-23 22:27 ` [PATCH 14/23] arm64: dts: qcom: sm8750: use dedicated audioreach dtsi srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 15/23] arm64: dts: qcom: msm8916: use dedicated elite-audio dtsi srinivas.kandagatla
2025-07-24  7:42   ` Stephan Gerhold
2025-07-23 22:27 ` [PATCH 16/23] arm64: dts: qcom: msm8939: " srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 17/23] arm64: dts: qcom: msm8996: " srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 18/23] arm64: dts: qcom: sm6350: " srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 19/23] arm64: dts: qcom: msm8953: " srinivas.kandagatla
2025-07-24  7:45   ` Stephan Gerhold
2025-07-23 22:27 ` [PATCH 20/23] arm64: dts: qcom: sm8450: add sound prefix for wsa2 srinivas.kandagatla
2025-07-23 22:44   ` Dmitry Baryshkov
2025-07-24  7:47     ` Stephan Gerhold
2025-07-23 22:27 ` [PATCH 21/23] arm64: dts: qcom: sm8550: " srinivas.kandagatla
2025-07-24  8:20   ` neil.armstrong
2025-07-23 22:27 ` [PATCH 22/23] arm64: dts: qcom: sm8750: " srinivas.kandagatla
2025-07-23 22:27 ` [PATCH 23/23] arm64: dts: qcom: sm8650: " srinivas.kandagatla
2025-07-24  8:20   ` neil.armstrong
2025-07-25  3:19 ` [PATCH 00/23] arm64: dts: qcom: cleanup DSP audio services Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93d80822-afa0-4bff-9e73-3ece36e8c23a@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=srinivas.kandagatla@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®