mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gerhard Engleder <gerhard@engleder-embedded.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	Gerhard Engleder <eg@keba.com>,
	Andi Shyti <andi.shyti@kernel.org>
Subject: Re: [PATCH] i2c: I2C_KEBA should depend on KEBA_CP500
Date: Tue, 24 Sep 2024 20:32:13 +0200	[thread overview]
Message-ID: <4abb8472-5b93-4709-b37e-9f19b9fe77b7@engleder-embedded.com> (raw)
In-Reply-To: <HE1PR0702MB37698642CB041A4D981B7B70BA682@HE1PR0702MB3769.eurprd07.prod.outlook.com>

On 24.09.24 11:34, Geert Uytterhoeven wrote:
> The KEBA I2C controller is only present on KEBA PLC devices.  Hence add
> a dependency on KEBA_CP500, to prevent asking the user about this driver
> when configuring a kernel without KEBA CP500 system FPGA support.
> 
> Fixes: c7e08c816cd2fdf8 ("i2c: keba: Add KEBA I2C controller support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>   drivers/i2c/busses/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index 0ea437c76167ad2d..229b8166ccc03803 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -782,6 +782,7 @@ config I2C_JZ4780
>   config I2C_KEBA
>          tristate "KEBA I2C controller support"
>          depends on HAS_IOMEM
> +       depends on KEBA_CP500 || COMPILE_TEST

Makes sense. I will add that dependency to the next similar drivers.

Thanks!

Reviewed-by: Gerhard Engleder <eg@keba.com>

  parent reply	other threads:[~2024-09-24 19:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-24  9:34 Geert Uytterhoeven
     [not found] ` <HE1PR0702MB37698642CB041A4D981B7B70BA682@HE1PR0702MB3769.eurprd07.prod.outlook.com>
2024-09-24 18:32   ` Gerhard Engleder [this message]
2024-09-25 13:52 ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4abb8472-5b93-4709-b37e-9f19b9fe77b7@engleder-embedded.com \
    --to=gerhard@engleder-embedded.com \
    --cc=andi.shyti@kernel.org \
    --cc=eg@keba.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®