mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] i2c: I2C_KEBA should depend on KEBA_CP500
@ 2024-09-24  9:34 Geert Uytterhoeven
       [not found] ` <HE1PR0702MB37698642CB041A4D981B7B70BA682@HE1PR0702MB3769.eurprd07.prod.outlook.com>
  2024-09-25 13:52 ` Andi Shyti
  0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2024-09-24  9:34 UTC (permalink / raw)
  To: Andi Shyti, Gerhard Engleder; +Cc: linux-i2c, linux-kernel, Geert Uytterhoeven

The KEBA I2C controller is only present on KEBA PLC devices.  Hence add
a dependency on KEBA_CP500, to prevent asking the user about this driver
when configuring a kernel without KEBA CP500 system FPGA support.

Fixes: c7e08c816cd2fdf8 ("i2c: keba: Add KEBA I2C controller support")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/i2c/busses/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 0ea437c76167ad2d..229b8166ccc03803 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -782,6 +782,7 @@ config I2C_JZ4780
 config I2C_KEBA
 	tristate "KEBA I2C controller support"
 	depends on HAS_IOMEM
+	depends on KEBA_CP500 || COMPILE_TEST
 	select AUXILIARY_BUS
 	help
 	  This driver supports the I2C controller found in KEBA system FPGA
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: I2C_KEBA should depend on KEBA_CP500
       [not found] ` <HE1PR0702MB37698642CB041A4D981B7B70BA682@HE1PR0702MB3769.eurprd07.prod.outlook.com>
@ 2024-09-24 18:32   ` Gerhard Engleder
  0 siblings, 0 replies; 3+ messages in thread
From: Gerhard Engleder @ 2024-09-24 18:32 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: linux-i2c, linux-kernel, Gerhard Engleder, Andi Shyti

On 24.09.24 11:34, Geert Uytterhoeven wrote:
> The KEBA I2C controller is only present on KEBA PLC devices.  Hence add
> a dependency on KEBA_CP500, to prevent asking the user about this driver
> when configuring a kernel without KEBA CP500 system FPGA support.
> 
> Fixes: c7e08c816cd2fdf8 ("i2c: keba: Add KEBA I2C controller support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>   drivers/i2c/busses/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index 0ea437c76167ad2d..229b8166ccc03803 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -782,6 +782,7 @@ config I2C_JZ4780
>   config I2C_KEBA
>          tristate "KEBA I2C controller support"
>          depends on HAS_IOMEM
> +       depends on KEBA_CP500 || COMPILE_TEST

Makes sense. I will add that dependency to the next similar drivers.

Thanks!

Reviewed-by: Gerhard Engleder <eg@keba.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: I2C_KEBA should depend on KEBA_CP500
  2024-09-24  9:34 [PATCH] i2c: I2C_KEBA should depend on KEBA_CP500 Geert Uytterhoeven
       [not found] ` <HE1PR0702MB37698642CB041A4D981B7B70BA682@HE1PR0702MB3769.eurprd07.prod.outlook.com>
@ 2024-09-25 13:52 ` Andi Shyti
  1 sibling, 0 replies; 3+ messages in thread
From: Andi Shyti @ 2024-09-25 13:52 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Gerhard Engleder, linux-i2c, linux-kernel

Hi Geert,

On Tue, Sep 24, 2024 at 11:34:18AM GMT, Geert Uytterhoeven wrote:
> The KEBA I2C controller is only present on KEBA PLC devices.  Hence add
> a dependency on KEBA_CP500, to prevent asking the user about this driver
> when configuring a kernel without KEBA CP500 system FPGA support.
> 
> Fixes: c7e08c816cd2fdf8 ("i2c: keba: Add KEBA I2C controller support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks for your fix, merged to i2c/i2c-host-fixes.

Thanks,
Andi

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-25 13:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-24  9:34 [PATCH] i2c: I2C_KEBA should depend on KEBA_CP500 Geert Uytterhoeven
     [not found] ` <HE1PR0702MB37698642CB041A4D981B7B70BA682@HE1PR0702MB3769.eurprd07.prod.outlook.com>
2024-09-24 18:32   ` Gerhard Engleder
2024-09-25 13:52 ` Andi Shyti

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®