mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* nfs3 implementation issue?
@ 2005-11-17  5:35 Xin Zhao
  2005-11-17  5:52 ` Trond Myklebust
  0 siblings, 1 reply; 2+ messages in thread
From: Xin Zhao @ 2005-11-17  5:35 UTC (permalink / raw)
  To: linux-kernel

In nfs/nfs3proc.c: nfs3_read_done(), I saw the following line:

   struct nfs_write_data *data = (struct nfs_write_data *) task->tk_calldata;

I don't know why the tk_calldata is regarded as nfs_write_data instead
of nfs_read_data. When this rpc call is set up, we put
task->tk_calldata as a nfs_read_data object, why will it become a
nfs_write_data after the rpc call is done?

Can someone explain this a little bit?

Thanks!

Xin

^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: nfs3 implementation issue?
  2005-11-17  5:35 nfs3 implementation issue? Xin Zhao
@ 2005-11-17  5:52 ` Trond Myklebust
  0 siblings, 0 replies; 2+ messages in thread
From: Trond Myklebust @ 2005-11-17  5:52 UTC (permalink / raw)
  To: Xin Zhao; +Cc: linux-kernel

On Thu, 2005-11-17 at 00:35 -0500, Xin Zhao wrote:
> In nfs/nfs3proc.c: nfs3_read_done(), I saw the following line:
> 
>    struct nfs_write_data *data = (struct nfs_write_data *) task->tk_calldata;
> 
> I don't know why the tk_calldata is regarded as nfs_write_data instead
> of nfs_read_data. When this rpc call is set up, we put
> task->tk_calldata as a nfs_read_data object, why will it become a
> nfs_write_data after the rpc call is done?
> 
> Can someone explain this a little bit?

Already fixed. See

http://kernel.org/git/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=34123da66e613602de5a886b05c875b6a91b8ed2

Cheers,
  Trond


^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-11-17  5:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-11-17  5:35 nfs3 implementation issue? Xin Zhao
2005-11-17  5:52 ` Trond Myklebust

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®