From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Komal Bajaj <komal.bajaj@oss.qualcomm.com>,
Anurag Pateriya <apateriy@qti.qualcomm.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Richard Cochran <richardcochran@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH PRELIMINARY 1/5] arm64: dts: qcom: shikra-iqs-som: fix GPIO138 reservation
Date: Wed, 9 Sep 2026 13:24:02 +0200 [thread overview]
Message-ID: <4aee70eb-bd1d-4320-8921-e55bb8e0d176@kernel.org> (raw)
In-Reply-To: <20260908-shikra_ethernet_dts-v1-1-69c0c5c7c124@oss.qualcomm.com>
On 08/09/2026 08:23, Mohd Ayaan Anwar wrote:
> The GPIO mappings on the IQS variant differ from the CQ variants.
> GPIO138 is connected to the RGMII1_RX_CTL pin rather than the NFC ESE
> Secure IO pin; the latter is connected to GPIO49. This incorrect
> reservation causes the probe of the second Ethernet port to fail:
>
> shikra-tlmm 500000.pinctrl: error -EINVAL: pin-138 (5d20000.ethernet)
> shikra-tlmm 500000.pinctrl: error -EINVAL: could not request pin 138
> (GPIO_138) from group gpio138 on device 500000.pinctrl
> qcom-ethqos 5d20000.ethernet: Error applying setting, reverse things back
>
> Replace gpio138 with gpio49 in the reserved list.
>
> Fixes: 779aead2dace ("arm64: dts: qcom: shikra: Add gpio-reserved-ranges to tlmm")
> Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/shikra-iqs-som.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
This looks duplicating:
https://lore.kernel.org/all/20260820085347.822-1-xueyao.an@oss.qualcomm.com/
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-09 11:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 6:23 [PATCH PRELIMINARY 0/5] arm64: dts: qcom: shikra: add Ethernet support Mohd Ayaan Anwar
2026-09-08 6:23 ` [PATCH PRELIMINARY 1/5] arm64: dts: qcom: shikra-iqs-som: fix GPIO138 reservation Mohd Ayaan Anwar
2026-09-08 12:11 ` Andrew Lunn
2026-09-08 13:43 ` Mohd Ayaan Anwar
2026-09-08 13:57 ` Andrew Lunn
2026-09-09 11:20 ` Konrad Dybcio
2026-09-09 11:19 ` Konrad Dybcio
2026-09-09 11:24 ` Krzysztof Kozlowski [this message]
2026-09-09 11:30 ` Krzysztof Kozlowski
2026-09-09 11:33 ` Krzysztof Kozlowski
2026-09-09 11:39 ` Mohd Ayaan Anwar
2026-09-09 11:34 ` Mohd Ayaan Anwar
2026-09-08 6:23 ` [PATCH PRELIMINARY 2/5] arm64: dts: qcom: shikra: add ethernet nodes Mohd Ayaan Anwar
2026-09-08 6:23 ` [PATCH PRELIMINARY 3/5] arm64: dts: qcom: shikra-cqm-evk: enable the first Ethernet port Mohd Ayaan Anwar
2026-09-08 6:23 ` [PATCH PRELIMINARY 4/5] arm64: dts: qcom: shikra-cqs-evk: " Mohd Ayaan Anwar
2026-09-08 6:23 ` [PATCH PRELIMINARY 5/5] arm64: dts: qcom: shikra-iqs-evk: enable both Ethernet ports Mohd Ayaan Anwar
2026-09-08 6:56 ` [PATCH PRELIMINARY 0/5] arm64: dts: qcom: shikra: add Ethernet support Krzysztof Kozlowski
2026-09-08 7:04 ` Mohd Ayaan Anwar
2026-09-08 7:14 ` Krzysztof Kozlowski
2026-09-08 7:23 ` Mohd Ayaan Anwar
2026-09-08 7:39 ` Mohd Ayaan Anwar
2026-09-08 8:42 ` Krzysztof Kozlowski
2026-09-08 10:02 ` Mohd Ayaan Anwar
2026-09-08 8:40 ` Krzysztof Kozlowski
2026-09-08 9:31 ` Mohd Ayaan Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4aee70eb-bd1d-4320-8921-e55bb8e0d176@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=apateriy@qti.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=komal.bajaj@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=mohd.anwar@oss.qualcomm.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®