Re: [PATCH PRELIMINARY 1/5] arm64: dts: qcom: shikra-iqs-som: fix GPIO138 reservation

[Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>]

On Wed, Sep 09, 2026 at 01:33:57PM +0200, Krzysztof Kozlowski wrote:
> On 09/09/2026 13:30, Krzysztof Kozlowski wrote:
> > On 09/09/2026 13:24, Krzysztof Kozlowski wrote:
> >> On 08/09/2026 08:23, Mohd Ayaan Anwar wrote:
> >>> The GPIO mappings on the IQS variant differ from the CQ variants.
> >>> GPIO138 is connected to the RGMII1_RX_CTL pin rather than the NFC ESE
> >>> Secure IO pin; the latter is connected to GPIO49. This incorrect
> >>> reservation causes the probe of the second Ethernet port to fail:
> >>>
> >>>   shikra-tlmm 500000.pinctrl: error -EINVAL: pin-138 (5d20000.ethernet)
> >>>   shikra-tlmm 500000.pinctrl: error -EINVAL: could not request pin 138
> >>>   (GPIO_138) from group gpio138 on device 500000.pinctrl
> >>>   qcom-ethqos 5d20000.ethernet: Error applying setting, reverse things back
> > 
> > 
> > Apply this patch and reproduce it. Is is possible? Didn't we talk about
> > this already?
> > 
> >>>
> >>> Replace gpio138 with gpio49 in the reserved list.
> >>>
> >>> Fixes: 779aead2dace ("arm64: dts: qcom: shikra: Add gpio-reserved-ranges to tlmm")
> >>> Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
> >>> ---
> >>>  arch/arm64/boot/dts/qcom/shikra-iqs-som.dtsi | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>
> >> This looks duplicating:
> >> https://lore.kernel.org/all/20260820085347.822-1-xueyao.an@oss.qualcomm.com/
> >>
> > 
> > Ah, no, mixed patches. Duplication is between other works:
> > https://lore.kernel.org/all/20260820085347.822-1-xueyao.an@oss.qualcomm.com/
> > https://lore.kernel.org/all/20260826-shikra-dtpm-v4-1-8476223184de@oss.qualcomm.com/
> > 
> > But nevertheless I am sure we talked about this, that commit msg and is
> > not accurate... Cannot find the thread, though...
> 
> So here was v1:
> https://lore.kernel.org/all/20260612-shikra_ethernet-v1-9-f0f4a1d19929@oss.qualcomm.com/
> Where I commented that code needs changes and now we see again v1.
> 
> What is with this patch versioning? How is it supposed to work:
> 
> b4 diff '<20260908-shikra_ethernet_dts-v1-0-69c0c5c7c124@oss.qualcomm.com>'
> 
> ???
> 

During the RFC, I mentioned that I will split out the series after
initial feedback. So the RFC (after incorporating the feedback) was split
into:
1. This series (v1)
2. Changes for net-next (v1 and v2 have been sent out):
  https://lore.kernel.org/netdev/20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com/

This particular commit message needs to be rewritten as its not breaking
anything in the current tree. I will fix that and drop the Fixes: tag.

	Ayaan