mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Kristina Martšenko" <kristina.martsenko@arm.com>
To: "Liao, Chang" <liaochang1@huawei.com>
Cc: linux-kernel@vger.kernel.org,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com,
	sashal@kernel.org, yangjiangshui@h-partners.com,
	zouyipeng@huawei.com, justin.he@arm.com, zengheng4@huawei.com,
	yangyicong@hisilicon.com, ruanjinjie <ruanjinjie@huawei.com>
Subject: Re: [RFC] SCTLR_EL1.TIDCP toggling for performance
Date: Fri, 18 Jul 2025 18:28:43 +0100	[thread overview]
Message-ID: <4b010cc5-9244-450d-9a03-4ff6bf5c9a20@arm.com> (raw)
In-Reply-To: <24afb8de-622a-4865-bd8e-8e89ccfff8f4@huawei.com>

Hi Chang,

On 18/07/2025 03:32, Liao, Chang wrote:
> Hi, Kristina
> 
> I've reviewed your patch [1] for FEAT_TIDCP1 support, which by default traps EL0
> accesses to implementation-defined system registers and instructions at EL1/EL2.
> 
> Do you have any plans to add support for toggling the SCTLR_EL1.TIDCP1 bit? I'm
> encountering performance degradation on CPU where certain implementation-defined
> registers and instructions are designed for EL0 performance use. The trapping
> overhead is substantial enough to compromise any benefits, and it's even worse
> in virtualization. Therefore, I'm hoping there's a way to clear the SCTLR_EL1.TIDCP1
> bit on such platforms, perhaps via a kernel config option or command-line parameter.
> Alternatively, do you have a better solution for gracefully toggling this bit on
> and off?
> 
> Thanks
> 
> [1] https://lore.kernel.org/linux-arm-kernel/Yrw3NWkH6D0CgRsF@sirena.org.uk/T/#m5cfdb27b48d9d7e30db73e991fc6c232ba8a7349

I don't have any plans to add support for toggling it. You could try sending a
patch for a Kconfig option or kernel command-line parameter. I'm not really
sure what the maintainers' view on supporting IMP-DEF features is.

Thanks,
Kristina


  reply	other threads:[~2025-07-18 17:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-18  2:32 Liao, Chang
2025-07-18 17:28 ` Kristina Martšenko [this message]
2025-07-22  1:47   ` Liao, Chang
2025-07-18 19:03 ` Catalin Marinas
2025-07-22  1:47   ` Liao, Chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b010cc5-9244-450d-9a03-4ff6bf5c9a20@arm.com \
    --to=kristina.martsenko@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=justin.he@arm.com \
    --cc=liaochang1@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=ruanjinjie@huawei.com \
    --cc=sashal@kernel.org \
    --cc=will@kernel.org \
    --cc=yangjiangshui@h-partners.com \
    --cc=yangyicong@hisilicon.com \
    --cc=zengheng4@huawei.com \
    --cc=zouyipeng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®