From: Stephen Boyd <sboyd@codeaurora.org>
To: Manu Gautam <mgautam@codeaurora.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Felipe Balbi <balbi@kernel.org>
Cc: linux-arm-msm@vger.kernel.org,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
"open list:GENERIC PHY FRAMEWORK" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 4/6] phy: qcom-qusb2: Add support for runtime PM
Date: Fri, 21 Jul 2017 10:24:03 -0700 [thread overview]
Message-ID: <4b267088-e925-0842-9773-b5634565618c@codeaurora.org> (raw)
In-Reply-To: <1500634921-25914-5-git-send-email-mgautam@codeaurora.org>
On 07/21/2017 04:01 AM, Manu Gautam wrote:
> Driver can turn off clocks during runtime suspend.
> Also, runtime suspend is not as a result of host mode
> selective suspend then PHY can be powered off as well.
>
> Signed-off-by: Manu Gautam <mgautam@codeaurora.org>
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c
> index fa60a99..b505681 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qusb2.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c
> @@ -132,6 +132,9 @@ struct qusb2_phy {
>
> const struct qusb2_phy_cfg *cfg;
> bool has_se_clk_scheme;
> + bool phy_initialized;
> + bool powered_on;
Is the powered_on flag here because the controller driver has unbalanced
power on calls to the phy? Same comment applies for the phy_initialized
flag. Both of these look like workarounds for some odd behavior in the
controller driver.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-07-21 17:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1500634921-25914-1-git-send-email-mgautam@codeaurora.org>
2017-07-21 11:01 ` [PATCH v1 1/6] phy: qcom-qmp: Fix phy pipe clock gating Manu Gautam
2017-07-21 16:59 ` Stephen Boyd
2017-07-24 9:50 ` Manu Gautam
2017-07-21 11:01 ` [PATCH v1 2/6] phy: qcom-qmp: Power-on PHY before initialization Manu Gautam
2017-08-09 10:51 ` Manu Gautam
2017-07-21 11:01 ` [PATCH v1 3/6] phy: qcom-qusb2: " Manu Gautam
2017-07-21 11:01 ` [PATCH v1 4/6] phy: qcom-qusb2: Add support for runtime PM Manu Gautam
2017-07-21 17:24 ` Stephen Boyd [this message]
2017-07-24 10:03 ` Manu Gautam
2017-07-21 11:02 ` [PATCH v1 5/6] phy: qcom-qmp: " Manu Gautam
2017-07-21 11:02 ` [PATCH v1 6/6] usb: dwc3: core: Notify USB3 PHY as well for DRD modes Manu Gautam
2017-07-21 17:09 ` Stephen Boyd
2017-07-24 9:59 ` Manu Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b267088-e925-0842-9773-b5634565618c@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=balbi@kernel.org \
--cc=kishon@ti.com \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgautam@codeaurora.org \
--cc=viresh.kumar@linaro.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome