From: Zhiqiang Liu <liuzhiqiang26@huawei.com>
To: <agk@redhat.com>, Mike Snitzer <snitzer@redhat.com>
Cc: <dm-devel@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linfeilong <linfeilong@huawei.com>,
lixiaokeng <lixiaokeng@huawei.com>,
wuguanghao <wuguanghao3@huawei.com>, <liuzhiqiang26@huawei.com>
Subject: Re: [PATCH] md: remove unused dm_thin_remove_block()
Date: Mon, 14 Mar 2022 21:23:44 +0800 [thread overview]
Message-ID: <4b7e5e2c-a847-4e40-1f23-de71753fe9e8@huawei.com> (raw)
In-Reply-To: <b0ec028e-bc9e-f705-9674-ffc4a01ee2f0@huawei.com>
friendly ping..
On 2022/2/16 14:37, Zhiqiang Liu wrote:
> dm_thin_remove_block() is no longer unused, just remove it.
>
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
> ---
> drivers/md/dm-thin-metadata.c | 12 ------------
> drivers/md/dm-thin-metadata.h | 1 -
> 2 files changed, 13 deletions(-)
>
> diff --git a/drivers/md/dm-thin-metadata.c b/drivers/md/dm-thin-metadata.c
> index 1a96a07cbf44..986a2dc9a686 100644
> --- a/drivers/md/dm-thin-metadata.c
> +++ b/drivers/md/dm-thin-metadata.c
> @@ -1740,18 +1740,6 @@ static int __remove_range(struct dm_thin_device *td, dm_block_t begin, dm_block_
> return dm_btree_insert(&pmd->tl_info, pmd->root, keys, &value, &pmd->root);
> }
>
> -int dm_thin_remove_block(struct dm_thin_device *td, dm_block_t block)
> -{
> - int r = -EINVAL;
> -
> - pmd_write_lock(td->pmd);
> - if (!td->pmd->fail_io)
> - r = __remove(td, block);
> - pmd_write_unlock(td->pmd);
> -
> - return r;
> -}
> -
> int dm_thin_remove_range(struct dm_thin_device *td,
> dm_block_t begin, dm_block_t end)
> {
> diff --git a/drivers/md/dm-thin-metadata.h b/drivers/md/dm-thin-metadata.h
> index 7ef56bd2a7e3..4d7a2caf21d9 100644
> --- a/drivers/md/dm-thin-metadata.h
> +++ b/drivers/md/dm-thin-metadata.h
> @@ -166,7 +166,6 @@ int dm_pool_alloc_data_block(struct dm_pool_metadata *pmd, dm_block_t *result);
> int dm_thin_insert_block(struct dm_thin_device *td, dm_block_t block,
> dm_block_t data_block);
>
> -int dm_thin_remove_block(struct dm_thin_device *td, dm_block_t block);
> int dm_thin_remove_range(struct dm_thin_device *td,
> dm_block_t begin, dm_block_t end);
>
prev parent reply other threads:[~2022-03-14 13:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 6:37 Zhiqiang Liu
2022-03-14 13:23 ` Zhiqiang Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b7e5e2c-a847-4e40-1f23-de71753fe9e8@huawei.com \
--to=liuzhiqiang26@huawei.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=linfeilong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lixiaokeng@huawei.com \
--cc=snitzer@redhat.com \
--cc=wuguanghao3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®