[PATCH] Input: atkbd - skip deactivate for Lenovo IdeaPad Slim 3 15IWC11

[PATCH] Input: atkbd - skip deactivate for Lenovo IdeaPad Slim 3 15IWC11

[Martino Papero]

The internal keyboard on the Lenovo IdeaPad Slim 3 15IWC11 (83RR)
does not work correctly with the default i8042 settings. Using
i8042.nopnp=1 and i8042.dumbkbd=1 restores keyboard input, but prevents
the Caps Lock LED from working. Using i8042.nopnp=1 alone does not fix
the keyboard.

The laptop works correctly when atkbd_deactivate_fixup is used instead.
Add a DMI quirk for the 83RR to enable it.

This was tested without any i8042 command-line parameters. Keyboard
input and the Caps Lock LED work correctly, including after suspend
and resume and after a cold boot.

Link: https://lore.kernel.org/all/4f43465f-98ba-4722-8e29-03df20315369@kernel.org/
Signed-off-by: Martino Papero <martino.papero@lcb.to.it>
---
 drivers/input/keyboard/atkbd.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index 93650c982..b5ee5697a 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -1938,6 +1938,14 @@ static const struct dmi_system_id atkbd_dmi_quirk_table[] __initconst = {
 		},
 		.callback = atkbd_deactivate_fixup,
 	},
+	{
+		/* Lenovo IdeaPad Slim 3 15IWC11 (83RR) */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "83RR"),
+		},
+		.callback = atkbd_deactivate_fixup,
+	},
 	{
 		/* Xiaomi Book Pro 14 (TM2424) */
 		.matches = {

base-commit: 551c722f40809618230001baccf219193e22fc5a
-- 
2.55.0

Re: [PATCH] Input: atkbd - skip deactivate for Lenovo IdeaPad Slim 3 15IWC11

[Hans de Goede]

Hi,

On 30-Sep-26 22:10, Martino Papero wrote:
> The internal keyboard on the Lenovo IdeaPad Slim 3 15IWC11 (83RR)
> does not work correctly with the default i8042 settings. Using
> i8042.nopnp=1 and i8042.dumbkbd=1 restores keyboard input, but prevents
> the Caps Lock LED from working. Using i8042.nopnp=1 alone does not fix
> the keyboard.
> 
> The laptop works correctly when atkbd_deactivate_fixup is used instead.
> Add a DMI quirk for the 83RR to enable it.
> 
> This was tested without any i8042 command-line parameters. Keyboard
> input and the Caps Lock LED work correctly, including after suspend
> and resume and after a cold boot.
> 
> Link: https://lore.kernel.org/all/4f43465f-98ba-4722-8e29-03df20315369@kernel.org/
> Signed-off-by: Martino Papero <martino.papero@lcb.to.it>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Cc: stable@vger.kernel.org

Regards,

Hans


> ---
>  drivers/input/keyboard/atkbd.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> index 93650c982..b5ee5697a 100644
> --- a/drivers/input/keyboard/atkbd.c
> +++ b/drivers/input/keyboard/atkbd.c
> @@ -1938,6 +1938,14 @@ static const struct dmi_system_id atkbd_dmi_quirk_table[] __initconst = {
>  		},
>  		.callback = atkbd_deactivate_fixup,
>  	},
> +	{
> +		/* Lenovo IdeaPad Slim 3 15IWC11 (83RR) */
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "83RR"),
> +		},
> +		.callback = atkbd_deactivate_fixup,
> +	},
>  	{
>  		/* Xiaomi Book Pro 14 (TM2424) */
>  		.matches = {
> 
> base-commit: 551c722f40809618230001baccf219193e22fc5a