* Re: [PATCH v4 45/66] selftests/proc: Drop define _GNU_SOURCE
@ 2024-05-16 19:05 Alexey Dobriyan
0 siblings, 0 replies; 2+ messages in thread
From: Alexey Dobriyan @ 2024-05-16 19:05 UTC (permalink / raw)
To: Edward Liaw; +Cc: Shuah Khan, linux-kernel
> --- a/tools/testing/selftests/proc/proc-empty-vm.c
> +++ b/tools/testing/selftests/proc/proc-empty-vm.c
> -#undef _GNU_SOURCE
> -#define _GNU_SOURCE
No! Don't do this. It makes individual test program non-standalone.
Right now you can copy it to some other machine which triggers test
fauilure, compile and start debugging instead of remembering which
stupid compile flags it requires.
NAK for /proc, sorry. I'd like to keep #define.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v4 45/66] selftests/proc: Drop define _GNU_SOURCE
2024-05-10 0:06 [PATCH v4 00/66] Define _GNU_SOURCE for sources using Edward Liaw
@ 2024-05-10 0:07 ` Edward Liaw
0 siblings, 0 replies; 2+ messages in thread
From: Edward Liaw @ 2024-05-10 0:07 UTC (permalink / raw)
To: shuah, Mickaël Salaün, Günther Noack,
Christian Brauner, Richard Cochran, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Alexei Starovoitov, Daniel Borkmann,
David S. Miller, Jakub Kicinski, Jesper Dangaard Brouer,
John Fastabend
Cc: linux-kernel, linux-kselftest, kernel-team, Edward Liaw,
linux-security-module, netdev, linux-riscv, bpf, linux-fsdevel
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw <edliaw@google.com>
---
tools/testing/selftests/proc/proc-empty-vm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/testing/selftests/proc/proc-empty-vm.c b/tools/testing/selftests/proc/proc-empty-vm.c
index 56198d4ca2bf..f92a8dce58cf 100644
--- a/tools/testing/selftests/proc/proc-empty-vm.c
+++ b/tools/testing/selftests/proc/proc-empty-vm.c
@@ -23,9 +23,6 @@
* /proc/${pid}/smaps
* /proc/${pid}/smaps_rollup
*/
-#undef _GNU_SOURCE
-#define _GNU_SOURCE
-
#undef NDEBUG
#include <assert.h>
#include <errno.h>
--
2.45.0.118.g7fe29c98d7-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-16 19:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-16 19:05 [PATCH v4 45/66] selftests/proc: Drop define _GNU_SOURCE Alexey Dobriyan
-- strict thread matches above, loose matches on Subject: below --
2024-05-10 0:06 [PATCH v4 00/66] Define _GNU_SOURCE for sources using Edward Liaw
2024-05-10 0:07 ` [PATCH v4 45/66] selftests/proc: Drop define _GNU_SOURCE Edward Liaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®