From: Sumit Gupta <sumitg@nvidia.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: viresh.kumar@linaro.org, pierre.gondois@arm.com,
zhenglifeng1@huawei.com, ionela.voinescu@arm.com,
lenb@kernel.org, robert.moore@intel.com, corbet@lwn.net,
rdunlap@infradead.org, ray.huang@amd.com, gautham.shenoy@amd.com,
mario.limonciello@amd.com, perry.yuan@amd.com,
zhanjie9@hisilicon.com, linux-pm@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org,
acpica-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, treding@nvidia.com,
jonathanh@nvidia.com, vsethi@nvidia.com, ksitaraman@nvidia.com,
sanjayc@nvidia.com, nhartman@nvidia.com, bbasu@nvidia.com,
sumitg@nvidia.com
Subject: Re: [PATCH v6 2/9] ACPI: CPPC: Clean up cppc_perf_caps and cppc_perf_ctrls structs
Date: Wed, 28 Jan 2026 00:41:01 +0530 [thread overview]
Message-ID: <4bcd55a1-da5f-4161-aadf-594724c76627@nvidia.com> (raw)
In-Reply-To: <CAJZ5v0i-fgbpfd-iHcNNtnFU79Whs+Maknx3ou4oNOADzAZmxg@mail.gmail.com>
On 27/01/26 21:57, Rafael J. Wysocki wrote:
> External email: Use caution opening links or attachments
>
>
> On Tue, Jan 20, 2026 at 3:57 PM Sumit Gupta <sumitg@nvidia.com> wrote:
>> - Remove redundant energy_perf field from 'struct cppc_perf_caps' as
>> the same is available in 'struct cppc_perf_ctrls' which is used.
>> - Move the 'auto_sel' field from 'struct cppc_perf_caps' to
>> 'struct cppc_perf_ctrls' as it represents a control register.
>>
>> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
>> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
>> ---
>> include/acpi/cppc_acpi.h | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/include/acpi/cppc_acpi.h b/include/acpi/cppc_acpi.h
>> index 4bcdcaf8bf2c..6573a759eb8d 100644
>> --- a/include/acpi/cppc_acpi.h
>> +++ b/include/acpi/cppc_acpi.h
>> @@ -119,8 +119,6 @@ struct cppc_perf_caps {
>> u32 lowest_nonlinear_perf;
>> u32 lowest_freq;
>> u32 nominal_freq;
>> - u32 energy_perf;
>> - bool auto_sel;
>> };
>>
>> struct cppc_perf_ctrls {
>> @@ -128,6 +126,7 @@ struct cppc_perf_ctrls {
>> u32 min_perf;
>> u32 desired_perf;
>> u32 energy_perf;
>> + bool auto_sel;
>> };
>>
>> struct cppc_perf_fb_ctrs {
>> --
> It looks like this patch and the next one can be applied independently
> of the other patches in the series.
>
> Do you want me to do that?
Yes, this patch is independent and can be applied.
Also, the 'patch 3' can be applied independently.
- patch 3: 'ACPI: CPPC: Rename EPP constants for clarity'
Thank you,
Sumit Gupta
next prev parent reply other threads:[~2026-01-27 19:11 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 14:56 [PATCH v6 0/9] Enhanced autonomous selection and improvements Sumit Gupta
2026-01-20 14:56 ` [PATCH v6 1/9] cpufreq: CPPC: Add generic helpers for sysfs show/store Sumit Gupta
2026-01-22 8:27 ` zhenglifeng (A)
2026-01-27 16:24 ` Rafael J. Wysocki
2026-01-27 19:01 ` Sumit Gupta
2026-01-27 20:17 ` Rafael J. Wysocki
2026-01-20 14:56 ` [PATCH v6 2/9] ACPI: CPPC: Clean up cppc_perf_caps and cppc_perf_ctrls structs Sumit Gupta
2026-01-22 8:28 ` zhenglifeng (A)
2026-01-27 16:27 ` Rafael J. Wysocki
2026-01-27 19:11 ` Sumit Gupta [this message]
2026-01-20 14:56 ` [PATCH v6 3/9] ACPI: CPPC: Rename EPP constants for clarity Sumit Gupta
2026-01-22 8:31 ` zhenglifeng (A)
2026-01-20 14:56 ` [PATCH v6 4/9] ACPI: CPPC: Add cppc_get_perf() API to read performance controls Sumit Gupta
2026-01-22 8:56 ` zhenglifeng (A)
2026-01-22 11:30 ` Pierre Gondois
2026-01-22 11:42 ` zhenglifeng (A)
2026-01-24 20:05 ` Sumit Gupta
2026-01-24 20:19 ` Sumit Gupta
2026-01-26 11:20 ` Pierre Gondois
2026-01-27 11:08 ` Sumit Gupta
2026-01-20 14:56 ` [PATCH v6 5/9] ACPI: CPPC: Extend cppc_set_epp_perf() for FFH/SystemMemory Sumit Gupta
2026-01-22 9:18 ` zhenglifeng (A)
2026-01-24 20:08 ` Sumit Gupta
2026-01-26 8:10 ` zhenglifeng (A)
2026-01-27 11:17 ` Sumit Gupta
2026-01-20 14:56 ` [PATCH v6 6/9] ACPI: CPPC: add APIs and sysfs interface for min/max_perf Sumit Gupta
2026-01-22 11:36 ` Pierre Gondois
2026-01-24 20:32 ` Sumit Gupta
2026-01-26 10:51 ` Pierre Gondois
2026-01-27 11:22 ` Sumit Gupta
2026-01-22 12:35 ` zhenglifeng (A)
2026-01-24 20:52 ` Sumit Gupta
2026-01-20 14:56 ` [PATCH v6 7/9] ACPI: CPPC: add APIs and sysfs interface for perf_limited Sumit Gupta
2026-01-22 11:51 ` Pierre Gondois
2026-01-24 21:04 ` Sumit Gupta
2026-01-26 11:23 ` Pierre Gondois
2026-01-20 14:56 ` [PATCH v6 8/9] cpufreq: CPPC: Add sysfs for min/max_perf and perf_limited Sumit Gupta
2026-01-20 14:56 ` [PATCH v6 9/9] cpufreq: CPPC: Update cached perf_ctrls on sysfs write Sumit Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bcd55a1-da5f-4161-aadf-594724c76627@nvidia.com \
--to=sumitg@nvidia.com \
--cc=acpica-devel@lists.linux.dev \
--cc=bbasu@nvidia.com \
--cc=corbet@lwn.net \
--cc=gautham.shenoy@amd.com \
--cc=ionela.voinescu@arm.com \
--cc=jonathanh@nvidia.com \
--cc=ksitaraman@nvidia.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=nhartman@nvidia.com \
--cc=perry.yuan@amd.com \
--cc=pierre.gondois@arm.com \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=rdunlap@infradead.org \
--cc=robert.moore@intel.com \
--cc=sanjayc@nvidia.com \
--cc=treding@nvidia.com \
--cc=viresh.kumar@linaro.org \
--cc=vsethi@nvidia.com \
--cc=zhanjie9@hisilicon.com \
--cc=zhenglifeng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome