From: Andrew Lunn <andrew@lunn.ch>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Christian Marangi <ansuelsmth@gmail.com>,
Tim Harvey <tharvey@gateworks.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH RFC] net: dsa: mv88e6xxx: Support LED control
Date: Sun, 26 Nov 2023 17:45:31 +0100 [thread overview]
Message-ID: <4bd8642c-988f-4b99-944a-da573d0ef2c3@lunn.ch> (raw)
In-Reply-To: <CACRpkdY+T8Rqg_irkLNvAC+o_QfwO2N+eB9X-y24t34_9Rg3ww@mail.gmail.com>
On Sun, Nov 26, 2023 at 12:46:03AM +0100, Linus Walleij wrote:
> On Thu, Nov 23, 2023 at 5:13 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> > What i would really like to see happen is that the DSA core handles
> > the registration of the LEDs, similar to how phylib does. The DT
> > binding should be identical for all DSA devices, so there is no need
> > for each driver to do its own parsing.
> >
> > There are some WIP patches at
> >
> > https://github.com/lunn/linux.git leds-offload-support-reduced-auto-netdev
> >
> > which implement this. Feel free to make use of them.
>
> Oh it's quite a lot of patches, I really cannot drive that because there are
> so many things about them that I don't understand the thinking behind...
> But I like what I see!
O.K. Let me dust them off, rebase them on net-next and see what is
missing. You have some fibre things i don't have. I don't have a
machine with fibre so i cannot test that.
Andrew
next prev parent reply other threads:[~2023-11-26 16:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 9:37 Linus Walleij
2023-11-23 16:13 ` Andrew Lunn
2023-11-25 23:46 ` Linus Walleij
2023-11-26 16:45 ` Andrew Lunn [this message]
2023-11-26 20:11 ` Linus Walleij
2023-11-26 22:09 ` Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bd8642c-988f-4b99-944a-da573d0ef2c3@lunn.ch \
--to=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®