From: "André Draszik" <andre.draszik@linaro.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Lee Jones <lee@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Linus Walleij <linusw@kernel.org>,
Peter Griffin <peter.griffin@linaro.org>,
Will McVicker <willmcvicker@google.com>,
Juan Yescas <jyescas@google.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v5 21/21] regulator: s2mps11: enable-gpios is optional on s2mpg1x
Date: Fri, 02 Jan 2026 11:26:42 +0000 [thread overview]
Message-ID: <4bfcb1420b9684f67bd4b8f583313c1a08a1616d.camel@linaro.org> (raw)
In-Reply-To: <CAMRc=Meu6-5569rMcV0zf2V+Sz_QZgShoEhmhw41k6fczULcoA@mail.gmail.com>
On Fri, 2026-01-02 at 11:19 +0100, Bartosz Golaszewski wrote:
> On Sat, Dec 27, 2025 at 1:24 PM André Draszik <andre.draszik@linaro.org> wrote:
> >
> > For s2mpg1x, enable-gpios is optional, but when not given, the driver
> > is complaining quite verbosely about the missing property.
> >
> > Refactor the code slightly to avoid printing those messages to the
> > kernel log in that case.
> >
>
> I don't get the point of this - you added this function in the same
> series, why can't it be done right the first time it's implemented?
Sure, I can merge this patch into the refactoring patch 15 - the intention
was to have incremental changes to simplify review.
Cheers,
Andre
next prev parent reply other threads:[~2026-01-02 11:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-27 12:24 [PATCH v5 00/21] Samsung S2MPG10 regulator and S2MPG11 PMIC drivers André Draszik
2025-12-27 12:24 ` [PATCH v5 01/21] dt-bindings: firmware: google,gs101-acpm-ipc: convert regulators to lowercase André Draszik
2025-12-27 12:24 ` [PATCH v5 02/21] regulator: dt-bindings: add s2mpg10-pmic regulators André Draszik
2025-12-27 12:24 ` [PATCH v5 03/21] regulator: dt-bindings: add s2mpg11-pmic regulators André Draszik
2025-12-27 12:24 ` [PATCH v5 04/21] dt-bindings: mfd: samsung,s2mps11: Split s2mpg10-pmic into separate file André Draszik
2025-12-27 12:24 ` [PATCH v5 05/21] dt-bindings: mfd: samsung,s2mpg10-pmic: Link to its regulators André Draszik
2025-12-27 12:24 ` [PATCH v5 06/21] dt-bindings: mfd: Add samsung,s2mpg11-pmic André Draszik
2025-12-27 12:24 ` [PATCH v5 07/21] dt-bindings: firmware: google,gs101-acpm-ipc: add S2MPG11 secondary PMIC André Draszik
2025-12-27 12:24 ` [PATCH v5 08/21] mfd: sec: s2mpg10: reorder regulators for better probe performance André Draszik
2025-12-27 12:24 ` [PATCH v5 09/21] mfd: sec: Add support for S2MPG11 PMIC via ACPM André Draszik
2025-12-27 12:24 ` [PATCH v5 10/21] regulator: add REGULATOR_LINEAR_VRANGE macro André Draszik
2025-12-27 12:24 ` [PATCH v5 11/21] regulator: s2mps11: drop two needless variable initialisations André Draszik
2025-12-27 12:24 ` [PATCH v5 12/21] regulator: s2mps11: use dev_err_probe() where appropriate André Draszik
2025-12-27 12:24 ` [PATCH v5 13/21] regulator: s2mps11: place constants on right side of comparison tests André Draszik
2025-12-27 12:24 ` [PATCH v5 14/21] regulator: s2mps11: update node parsing (allow -supply properties) André Draszik
2025-12-27 12:24 ` [PATCH v5 15/21] regulator: s2mps11: refactor handling of external rail control André Draszik
2025-12-27 12:24 ` [PATCH v5 16/21] regulator: s2mps11: add S2MPG10 regulator André Draszik
2025-12-27 12:24 ` [PATCH v5 17/21] regulator: s2mps11: refactor S2MPG10 ::set_voltage_time() for S2MPG11 reuse André Draszik
2025-12-27 12:24 ` [PATCH v5 18/21] regulator: s2mps11: refactor S2MPG10 regulator macros " André Draszik
2025-12-27 12:24 ` [PATCH v5 19/21] regulator: s2mps11: add S2MPG11 regulator André Draszik
2025-12-27 12:24 ` [PATCH v5 20/21] regulator: s2mps11: more descriptive gpio consumer name André Draszik
2026-01-02 10:08 ` Bartosz Golaszewski
2025-12-27 12:24 ` [PATCH v5 21/21] regulator: s2mps11: enable-gpios is optional on s2mpg1x André Draszik
2026-01-02 10:19 ` Bartosz Golaszewski
2026-01-02 11:26 ` André Draszik [this message]
2026-01-02 11:31 ` Bartosz Golaszewski
2026-01-02 11:32 ` Krzysztof Kozlowski
2025-12-29 6:48 ` [PATCH v5 00/21] Samsung S2MPG10 regulator and S2MPG11 PMIC drivers André Draszik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bfcb1420b9684f67bd4b8f583313c1a08a1616d.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jyescas@google.com \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®